mbox series

[0/3] scsi|phy: Add SM8450 UFS & Phy support

Message ID 20211201074456.3969849-1-vkoul@kernel.org
Headers show
Series scsi|phy: Add SM8450 UFS & Phy support | expand

Message

Vinod Koul Dec. 1, 2021, 7:44 a.m. UTC 
Add the binding documentation for ufs SM8450 compatible, phy compatible and
SM8450 UFS QMP Phy support.

Vinod Koul (3):
  scsi: ufs: dt-bindings: Add SM8450 compatible strings
  dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible
  phy: qcom-qmp: Add SM8450 UFS QMP Phy

 .../devicetree/bindings/phy/qcom,qmp-phy.yaml |  1 +
 .../devicetree/bindings/ufs/ufshcd-pltfrm.txt |  1 +
 drivers/phy/qualcomm/phy-qcom-qmp.c           | 32 +++++++++++++++++++
 3 files changed, 34 insertions(+)

Comments

Martin K. Petersen Dec. 3, 2021, 2:58 a.m. UTC | #1 
Vinod,

> Add the binding documentation for ufs SM8450 compatible, phy
> compatible and SM8450 UFS QMP Phy support.

>  .../devicetree/bindings/phy/qcom,qmp-phy.yaml |  1 +
>  .../devicetree/bindings/ufs/ufshcd-pltfrm.txt |  1 +
>  drivers/phy/qualcomm/phy-qcom-qmp.c           | 32 +++++++++++++++++++

No objections from me. However, these patches should go through the DT
and phy trees.
Bjorn Andersson Dec. 3, 2021, 3:20 a.m. UTC | #2 
On Wed 01 Dec 01:44 CST 2021, Vinod Koul wrote:

> SM8450 UFS seems to use same sequence as SM8350, so reuse the sequence
> from SM8450. Add the new clock list for this phy and the new compatible
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Co-developed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>  drivers/phy/qualcomm/phy-qcom-qmp.c | 32 +++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 456a59d8c7d0..a959c97a699f 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -3091,6 +3091,10 @@ static const char * const qmp_v4_sm8250_usbphy_clk_l[] = {
>  	"aux", "ref_clk_src", "com_aux"
>  };
>  
> +static const char * const sm8450_ufs_phy_clk_l[] = {
> +	"qref", "ref", "ref_aux",
> +};
> +
>  static const char * const sdm845_ufs_phy_clk_l[] = {
>  	"ref", "ref_aux",
>  };
> @@ -4087,6 +4091,31 @@ static const struct qmp_phy_cfg sm8350_usb3_uniphy_cfg = {
>  	.pwrdn_delay_max	= POWER_DOWN_DELAY_US_MAX,
>  };
>  
> +static const struct qmp_phy_cfg sm8450_ufsphy_cfg = {
> +	.type			= PHY_TYPE_UFS,
> +	.nlanes			= 2,
> +
> +	.serdes_tbl		= sm8350_ufsphy_serdes_tbl,
> +	.serdes_tbl_num		= ARRAY_SIZE(sm8350_ufsphy_serdes_tbl),
> +	.tx_tbl			= sm8350_ufsphy_tx_tbl,
> +	.tx_tbl_num		= ARRAY_SIZE(sm8350_ufsphy_tx_tbl),
> +	.rx_tbl			= sm8350_ufsphy_rx_tbl,
> +	.rx_tbl_num		= ARRAY_SIZE(sm8350_ufsphy_rx_tbl),
> +	.pcs_tbl		= sm8350_ufsphy_pcs_tbl,
> +	.pcs_tbl_num		= ARRAY_SIZE(sm8350_ufsphy_pcs_tbl),
> +	.clk_list		= sm8450_ufs_phy_clk_l,
> +	.num_clks		= ARRAY_SIZE(sm8450_ufs_phy_clk_l),
> +	.vreg_list		= qmp_phy_vreg_l,
> +	.num_vregs		= ARRAY_SIZE(qmp_phy_vreg_l),
> +	.regs			= sm8150_ufsphy_regs_layout,
> +
> +	.start_ctrl		= SERDES_START,
> +	.pwrdn_ctrl		= SW_PWRDN,
> +	.phy_status		= PHYSTATUS,
> +
> +	.is_dual_lane_phy	= true,
> +};
> +
>  static const struct qmp_phy_cfg qcm2290_usb3phy_cfg = {
>  	.type			= PHY_TYPE_USB3,
>  	.nlanes			= 1,
> @@ -5745,6 +5774,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
>  	}, {
>  		.compatible = "qcom,sm8350-qmp-usb3-uni-phy",
>  		.data = &sm8350_usb3_uniphy_cfg,
> +	}, {
> +		.compatible = "qcom,sm8450-qmp-ufs-phy",
> +		.data = &sm8450_ufsphy_cfg,
>  	}, {
>  		.compatible = "qcom,qcm2290-qmp-usb3-phy",
>  		.data = &qcm2290_usb3phy_cfg,
> -- 
> 2.31.1
>
Vinod Koul Dec. 3, 2021, 5:42 p.m. UTC | #3 
On 02-12-21, 21:58, Martin K. Petersen wrote:
> 
> Vinod,
> 
> > Add the binding documentation for ufs SM8450 compatible, phy
> > compatible and SM8450 UFS QMP Phy support.
> 
> >  .../devicetree/bindings/phy/qcom,qmp-phy.yaml |  1 +
> >  .../devicetree/bindings/ufs/ufshcd-pltfrm.txt |  1 +
> >  drivers/phy/qualcomm/phy-qcom-qmp.c           | 32 +++++++++++++++++++
> 
> No objections from me. However, these patches should go through the DT
> and phy trees.

Ok I can pick these up wearing my phy maintainer hat, can u pls ack
it...

Thanks
Martin K. Petersen Dec. 7, 2021, 2:35 a.m. UTC | #4 
Vinod,

>> No objections from me. However, these patches should go through the
>> DT and phy trees.
>
> Ok I can pick these up wearing my phy maintainer hat, can u pls ack
> it...

This series doesn't touch anything under SCSI. But it does look OK to
me, so...

Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Vinod Koul Dec. 7, 2021, 11:59 a.m. UTC | #5 
On 06-12-21, 21:35, Martin K. Petersen wrote:
> 
> Vinod,
> 
> >> No objections from me. However, these patches should go through the
> >> DT and phy trees.
> >
> > Ok I can pick these up wearing my phy maintainer hat, can u pls ack
> > it...
> 
> This series doesn't touch anything under SCSI. But it does look OK to
> me, so...

I would consider scsi dt-update in your bucket :)
> 
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

Thanks for that

I have picked the series now.