mbox series

[v1,0/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail

Message ID 20210819124844.12424-1-yangcong5@huaqin.corp-partner.google.com
Headers show
Series drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail | expand

Message

Cong Yang Aug. 19, 2021, 12:48 p.m. UTC 
The auo,b101uan08.3 panel (already supported by this driver) has
a 3.3V rail that needs to be turned on. For previous users of
this panel this voltage was directly output by pmic. On a new 
user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
to turn the 3.3V rail on. Add support in the driver for this.

yangcong (2):
  drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
  dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail

 .../bindings/display/panel/boe,tv101wum-nl6.yaml      |  4 ++++
 drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c        | 11 +++++++++++
 2 files changed, 15 insertions(+)

Comments

Cong Yang Aug. 20, 2021, 7:01 a.m. UTC | #1 
Compared to v1, "pp3300-supply" is removed in the required list:
dt-bindings: drm/panel:
   - reg
   - enable-gpios
   - pp1800-supply
-  - pp3300-supply
   - avdd-supply
   - avee-supply

yangcong (2):
  drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
  dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail

 .../bindings/display/panel/boe,tv101wum-nl6.yaml      |  3 +++
 drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c        | 11 +++++++++++
 2 files changed, 14 insertions(+)
Doug Anderson Aug. 20, 2021, 3:46 p.m. UTC | #2 
Hi,

On Fri, Aug 20, 2021 at 12:01 AM yangcong
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> The auo,b101uan08.3 panel (already supported by this driver) has
> a 3.3V rail that needs to be turned on. For previous users of
> this panel this voltage was directly output by pmic. On a new
> user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
> to turn the 3.3V rail on. Add support in the driver for this.
>
> Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Doug Anderson Aug. 26, 2021, 7:48 p.m. UTC | #3 
Sam / Thierry,

On Fri, Aug 20, 2021 at 12:01 AM yangcong
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> Compared to v1, "pp3300-supply" is removed in the required list:
> dt-bindings: drm/panel:
>    - reg
>    - enable-gpios
>    - pp1800-supply
> -  - pp3300-supply
>    - avdd-supply
>    - avee-supply
>
> yangcong (2):
>   drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
>   dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
>
>  .../bindings/display/panel/boe,tv101wum-nl6.yaml      |  3 +++
>  drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c        | 11 +++++++++++
>  2 files changed, 14 insertions(+)

I've been keeping track of this series since this panel is supposed to
be used on a future Chrome OS project. It's quite simple and the
bindings now have Rob's Review. I'm happy to take care of landing them
in drm-misc-next if that's OK with you two (since you're listed as
maintainers in the bindings).

-Doug