| Message ID | 20210805091727.942471-1-iskren.chernev@gmail.com |
|---|---|
| Headers | show |
| Series | Add UFS PHY support for SM6115/4250 | expand |
On 05-08-21, 12:17, Iskren Chernev wrote: > +/* Only for QMP V3 660 PHY - QSERDES COM registers*/ > +#define QSERDES_V3_660_COM_ATB_SEL1 0x000 > +#define QSERDES_V3_660_COM_ATB_SEL2 0x004 > +#define QSERDES_V3_660_COM_FREQ_UPDATE 0x008 > +#define QSERDES_V3_660_COM_BG_TIMER 0x00c > +#define QSERDES_V3_660_COM_SSC_EN_CENTER 0x010 > +#define QSERDES_V3_660_COM_SSC_ADJ_PER1 0x014 > +#define QSERDES_V3_660_COM_SSC_ADJ_PER2 0x018 > +#define QSERDES_V3_660_COM_SSC_PER1 0x01c > +#define QSERDES_V3_660_COM_SSC_PER2 0x020 > +#define QSERDES_V3_660_COM_SSC_STEP_SIZE1 0x024 > +#define QSERDES_V3_660_COM_SSC_STEP_SIZE2 0x028 > +#define QSERDES_V3_660_COM_POST_DIV 0x02c > +#define QSERDES_V3_660_COM_POST_DIV_MUX 0x030 > +#define QSERDES_V3_660_COM_BIAS_EN_CLKBUFLR_EN 0x034 > +#define QSERDES_V3_660_COM_CLK_ENABLE1 0x038 > +#define QSERDES_V3_660_COM_SYS_CLK_CTRL 0x03c > +#define QSERDES_V3_660_COM_SYSCLK_BUF_ENABLE 0x040 > +#define QSERDES_V3_660_COM_PLL_EN 0x044 > +#define QSERDES_V3_660_COM_PLL_IVCO 0x048 > +#define QSERDES_V3_660_COM_LOCK_CMP1_MODE0 0x04c > +#define QSERDES_V3_660_COM_LOCK_CMP2_MODE0 0x050 > +#define QSERDES_V3_660_COM_LOCK_CMP3_MODE0 0x054 > +#define QSERDES_V3_660_COM_LOCK_CMP1_MODE1 0x058 > +#define QSERDES_V3_660_COM_LOCK_CMP2_MODE1 0x05c > +#define QSERDES_V3_660_COM_LOCK_CMP3_MODE1 0x060 > +#define QSERDES_V3_660_COM_CMD_RSVD0 0x064 > +#define QSERDES_V3_660_COM_EP_CLOCK_DETECT_CTRL 0x068 > +#define QSERDES_V3_660_COM_SYSCLK_DET_COMP_STATUS 0x06c > +#define QSERDES_V3_660_COM_BG_TRIM 0x070 > +#define QSERDES_V3_660_COM_CLK_EP_DIV 0x074 > +#define QSERDES_V3_660_COM_CP_CTRL_MODE0 0x078 > +#define QSERDES_V3_660_COM_CP_CTRL_MODE1 0x07c > +#define QSERDES_V3_660_COM_CMN_RSVD1 0x080 > +#define QSERDES_V3_660_COM_PLL_RCTRL_MODE0 0x084 > +#define QSERDES_V3_660_COM_PLL_RCTRL_MODE1 0x088 > +#define QSERDES_V3_660_COM_CMN_RSVD2 0x08c > +#define QSERDES_V3_660_COM_PLL_CCTRL_MODE0 0x090 > +#define QSERDES_V3_660_COM_PLL_CCTRL_MODE1 0x094 > +#define QSERDES_V3_660_COM_CMN_RSVD3 0x098 > +#define QSERDES_V3_660_COM_PLL_CNTRL 0x09c > +#define QSERDES_V3_660_COM_PHASE_SEL_CTRL 0x0a0 > +#define QSERDES_V3_660_COM_PHASE_SEL_DC 0x0a4 > +#define QSERDES_V3_660_COM_BIAS_EN_CTRL_BY_PSM 0x0a8 > +#define QSERDES_V3_660_COM_SYSCLK_EN_SEL 0x0ac > +#define QSERDES_V3_660_COM_CML_SYSCLK_SEL 0x0b0 > +#define QSERDES_V3_660_COM_RESETSM_CNTRL 0x0b4 > +#define QSERDES_V3_660_COM_RESETSM_CNTRL2 0x0b8 > +#define QSERDES_V3_660_COM_RESTRIM_CTRL 0x0bc > +#define QSERDES_V3_660_COM_RESTRIM_CTRL2 0x0c0 > +#define QSERDES_V3_660_COM_LOCK_CMP_EN 0x0c8 > +#define QSERDES_V3_660_COM_LOCK_CMP_CFG 0x0cc > +#define QSERDES_V3_660_COM_DEC_START_MODE0 0x0d0 > +#define QSERDES_V3_660_COM_DEC_START_MODE1 0x0d4 > +#define QSERDES_V3_660_COM_VCOCAL_DEADMAN_CTRL 0x0d8 > +#define QSERDES_V3_660_COM_DIV_FRAC_START1_MODE0 0x0dc > +#define QSERDES_V3_660_COM_DIV_FRAC_START2_MODE0 0x0e0 > +#define QSERDES_V3_660_COM_DIV_FRAC_START3_MODE0 0x0e4 > +#define QSERDES_V3_660_COM_DIV_FRAC_START1_MODE1 0x0e8 > +#define QSERDES_V3_660_COM_DIV_FRAC_START2_MODE1 0x0ec > +#define QSERDES_V3_660_COM_DIV_FRAC_START3_MODE1 0x0f0 > +#define QSERDES_V3_660_COM_VCO_TUNE_MINVAL1 0x0f4 > +#define QSERDES_V3_660_COM_VCO_TUNE_MINVAL2 0x0f8 > +#define QSERDES_V3_660_COM_CMN_RSVD4 0x0fc > +#define QSERDES_V3_660_COM_INTEGLOOP_INITVAL 0x100 > +#define QSERDES_V3_660_COM_INTEGLOOP_EN 0x104 > +#define QSERDES_V3_660_COM_INTEGLOOP_GAIN0_MODE0 0x108 > +#define QSERDES_V3_660_COM_INTEGLOOP_GAIN1_MODE0 0x10c > +#define QSERDES_V3_660_COM_INTEGLOOP_GAIN0_MODE1 0x110 > +#define QSERDES_V3_660_COM_INTEGLOOP_GAIN1_MODE1 0x114 > +#define QSERDES_V3_660_COM_VCO_TUNE_MAXVAL1 0x118 > +#define QSERDES_V3_660_COM_VCO_TUNE_MAXVAL2 0x11c > +#define QSERDES_V3_660_COM_RES_TRIM_CONTROL2 0x120 > +#define QSERDES_V3_660_COM_VCO_TUNE_CTRL 0x124 > +#define QSERDES_V3_660_COM_VCO_TUNE_MAP 0x128 > +#define QSERDES_V3_660_COM_VCO_TUNE1_MODE0 0x12c > +#define QSERDES_V3_660_COM_VCO_TUNE2_MODE0 0x130 > +#define QSERDES_V3_660_COM_VCO_TUNE1_MODE1 0x134 > +#define QSERDES_V3_660_COM_VCO_TUNE2_MODE1 0x138 > +#define QSERDES_V3_660_COM_VCO_TUNE_INITVAL1 0x13c > +#define QSERDES_V3_660_COM_VCO_TUNE_INITVAL2 0x140 > +#define QSERDES_V3_660_COM_VCO_TUNE_TIMER1 0x144 > +#define QSERDES_V3_660_COM_VCO_TUNE_TIMER2 0x148 > +#define QSERDES_V3_660_COM_SAR 0x14c > +#define QSERDES_V3_660_COM_SAR_CLK 0x150 > +#define QSERDES_V3_660_COM_SAR_CODE_OUT_STATUS 0x154 > +#define QSERDES_V3_660_COM_SAR_CODE_READY_STATUS 0x158 > +#define QSERDES_V3_660_COM_CMN_STATUS 0x15c > +#define QSERDES_V3_660_COM_RESET_SM_STATUS 0x160 > +#define QSERDES_V3_660_COM_RESTRIM_CODE_STATUS 0x164 > +#define QSERDES_V3_660_COM_PLLCAL_CODE1_STATUS 0x168 > +#define QSERDES_V3_660_COM_PLLCAL_CODE2_STATUS 0x16c > +#define QSERDES_V3_660_COM_BG_CTRL 0x170 > +#define QSERDES_V3_660_COM_CLK_SELECT 0x174 > +#define QSERDES_V3_660_COM_HSCLK_SEL 0x178 > +#define QSERDES_V3_660_COM_INTEGLOOP_BINCODE_STATUS 0x17c > +#define QSERDES_V3_660_COM_PLL_ANALOG 0x180 > +#define QSERDES_V3_660_COM_CORECLK_DIV 0x184 > +#define QSERDES_V3_660_COM_SW_RESET 0x188 > +#define QSERDES_V3_660_COM_CORE_CLK_EN 0x18c > +#define QSERDES_V3_660_COM_C_READY_STATUS 0x190 > +#define QSERDES_V3_660_COM_CMN_CONFIG 0x194 > +#define QSERDES_V3_660_COM_CMN_RATE_OVERRIDE 0x198 > +#define QSERDES_V3_660_COM_SVS_MODE_CLK_SEL 0x19c > +#define QSERDES_V3_660_COM_DEBUG_BUS0 0x1a0 > +#define QSERDES_V3_660_COM_DEBUG_BUS1 0x1a4 > +#define QSERDES_V3_660_COM_DEBUG_BUS2 0x1a8 > +#define QSERDES_V3_660_COM_DEBUG_BUS3 0x1ac > +#define QSERDES_V3_660_COM_DEBUG_BUS_SEL 0x1b0 > +#define QSERDES_V3_660_COM_CMN_MISC1 0x1b4 > +#define QSERDES_V3_660_COM_CORECLK_DIV_MODE1 0x1bc > +#define QSERDES_V3_660_COM_CMN_RSVD5 0x1c0 why are these registers 660 specific and not V3 like we have for other generations..? Quick looks with V3 regs tells me that seem similar....
On 8/6/21 3:57 PM, Vinod Koul wrote: > On 05-08-21, 12:17, Iskren Chernev wrote: > >> +/* Only for QMP V3 660 PHY - QSERDES COM registers*/ >> +#define QSERDES_V3_660_COM_ATB_SEL1 0x000 >> +#define QSERDES_V3_660_COM_ATB_SEL2 0x004 >> +#define QSERDES_V3_660_COM_FREQ_UPDATE 0x008 >> +#define QSERDES_V3_660_COM_BG_TIMER 0x00c >> +#define QSERDES_V3_660_COM_SSC_EN_CENTER 0x010 >> +#define QSERDES_V3_660_COM_SSC_ADJ_PER1 0x014 >> +#define QSERDES_V3_660_COM_SSC_ADJ_PER2 0x018 >> +#define QSERDES_V3_660_COM_SSC_PER1 0x01c >> +#define QSERDES_V3_660_COM_SSC_PER2 0x020 >> +#define QSERDES_V3_660_COM_SSC_STEP_SIZE1 0x024 >> +#define QSERDES_V3_660_COM_SSC_STEP_SIZE2 0x028 >> +#define QSERDES_V3_660_COM_POST_DIV 0x02c >> +#define QSERDES_V3_660_COM_POST_DIV_MUX 0x030 >> +#define QSERDES_V3_660_COM_BIAS_EN_CLKBUFLR_EN 0x034 >> +#define QSERDES_V3_660_COM_CLK_ENABLE1 0x038 >> +#define QSERDES_V3_660_COM_SYS_CLK_CTRL 0x03c >> +#define QSERDES_V3_660_COM_SYSCLK_BUF_ENABLE 0x040 >> +#define QSERDES_V3_660_COM_PLL_EN 0x044 >> +#define QSERDES_V3_660_COM_PLL_IVCO 0x048 >> +#define QSERDES_V3_660_COM_LOCK_CMP1_MODE0 0x04c >> +#define QSERDES_V3_660_COM_LOCK_CMP2_MODE0 0x050 >> +#define QSERDES_V3_660_COM_LOCK_CMP3_MODE0 0x054 >> +#define QSERDES_V3_660_COM_LOCK_CMP1_MODE1 0x058 >> +#define QSERDES_V3_660_COM_LOCK_CMP2_MODE1 0x05c >> +#define QSERDES_V3_660_COM_LOCK_CMP3_MODE1 0x060 >> +#define QSERDES_V3_660_COM_CMD_RSVD0 0x064 >> +#define QSERDES_V3_660_COM_EP_CLOCK_DETECT_CTRL 0x068 >> +#define QSERDES_V3_660_COM_SYSCLK_DET_COMP_STATUS 0x06c >> +#define QSERDES_V3_660_COM_BG_TRIM 0x070 >> +#define QSERDES_V3_660_COM_CLK_EP_DIV 0x074 >> +#define QSERDES_V3_660_COM_CP_CTRL_MODE0 0x078 >> +#define QSERDES_V3_660_COM_CP_CTRL_MODE1 0x07c >> +#define QSERDES_V3_660_COM_CMN_RSVD1 0x080 >> +#define QSERDES_V3_660_COM_PLL_RCTRL_MODE0 0x084 >> +#define QSERDES_V3_660_COM_PLL_RCTRL_MODE1 0x088 >> +#define QSERDES_V3_660_COM_CMN_RSVD2 0x08c >> +#define QSERDES_V3_660_COM_PLL_CCTRL_MODE0 0x090 >> +#define QSERDES_V3_660_COM_PLL_CCTRL_MODE1 0x094 >> +#define QSERDES_V3_660_COM_CMN_RSVD3 0x098 >> +#define QSERDES_V3_660_COM_PLL_CNTRL 0x09c >> +#define QSERDES_V3_660_COM_PHASE_SEL_CTRL 0x0a0 >> +#define QSERDES_V3_660_COM_PHASE_SEL_DC 0x0a4 >> +#define QSERDES_V3_660_COM_BIAS_EN_CTRL_BY_PSM 0x0a8 >> +#define QSERDES_V3_660_COM_SYSCLK_EN_SEL 0x0ac >> +#define QSERDES_V3_660_COM_CML_SYSCLK_SEL 0x0b0 >> +#define QSERDES_V3_660_COM_RESETSM_CNTRL 0x0b4 >> +#define QSERDES_V3_660_COM_RESETSM_CNTRL2 0x0b8 >> +#define QSERDES_V3_660_COM_RESTRIM_CTRL 0x0bc >> +#define QSERDES_V3_660_COM_RESTRIM_CTRL2 0x0c0 >> +#define QSERDES_V3_660_COM_LOCK_CMP_EN 0x0c8 >> +#define QSERDES_V3_660_COM_LOCK_CMP_CFG 0x0cc >> +#define QSERDES_V3_660_COM_DEC_START_MODE0 0x0d0 >> +#define QSERDES_V3_660_COM_DEC_START_MODE1 0x0d4 >> +#define QSERDES_V3_660_COM_VCOCAL_DEADMAN_CTRL 0x0d8 >> +#define QSERDES_V3_660_COM_DIV_FRAC_START1_MODE0 0x0dc >> +#define QSERDES_V3_660_COM_DIV_FRAC_START2_MODE0 0x0e0 >> +#define QSERDES_V3_660_COM_DIV_FRAC_START3_MODE0 0x0e4 >> +#define QSERDES_V3_660_COM_DIV_FRAC_START1_MODE1 0x0e8 >> +#define QSERDES_V3_660_COM_DIV_FRAC_START2_MODE1 0x0ec >> +#define QSERDES_V3_660_COM_DIV_FRAC_START3_MODE1 0x0f0 >> +#define QSERDES_V3_660_COM_VCO_TUNE_MINVAL1 0x0f4 >> +#define QSERDES_V3_660_COM_VCO_TUNE_MINVAL2 0x0f8 >> +#define QSERDES_V3_660_COM_CMN_RSVD4 0x0fc >> +#define QSERDES_V3_660_COM_INTEGLOOP_INITVAL 0x100 >> +#define QSERDES_V3_660_COM_INTEGLOOP_EN 0x104 >> +#define QSERDES_V3_660_COM_INTEGLOOP_GAIN0_MODE0 0x108 >> +#define QSERDES_V3_660_COM_INTEGLOOP_GAIN1_MODE0 0x10c >> +#define QSERDES_V3_660_COM_INTEGLOOP_GAIN0_MODE1 0x110 >> +#define QSERDES_V3_660_COM_INTEGLOOP_GAIN1_MODE1 0x114 >> +#define QSERDES_V3_660_COM_VCO_TUNE_MAXVAL1 0x118 >> +#define QSERDES_V3_660_COM_VCO_TUNE_MAXVAL2 0x11c >> +#define QSERDES_V3_660_COM_RES_TRIM_CONTROL2 0x120 >> +#define QSERDES_V3_660_COM_VCO_TUNE_CTRL 0x124 >> +#define QSERDES_V3_660_COM_VCO_TUNE_MAP 0x128 >> +#define QSERDES_V3_660_COM_VCO_TUNE1_MODE0 0x12c >> +#define QSERDES_V3_660_COM_VCO_TUNE2_MODE0 0x130 >> +#define QSERDES_V3_660_COM_VCO_TUNE1_MODE1 0x134 >> +#define QSERDES_V3_660_COM_VCO_TUNE2_MODE1 0x138 >> +#define QSERDES_V3_660_COM_VCO_TUNE_INITVAL1 0x13c >> +#define QSERDES_V3_660_COM_VCO_TUNE_INITVAL2 0x140 >> +#define QSERDES_V3_660_COM_VCO_TUNE_TIMER1 0x144 >> +#define QSERDES_V3_660_COM_VCO_TUNE_TIMER2 0x148 >> +#define QSERDES_V3_660_COM_SAR 0x14c >> +#define QSERDES_V3_660_COM_SAR_CLK 0x150 >> +#define QSERDES_V3_660_COM_SAR_CODE_OUT_STATUS 0x154 >> +#define QSERDES_V3_660_COM_SAR_CODE_READY_STATUS 0x158 >> +#define QSERDES_V3_660_COM_CMN_STATUS 0x15c >> +#define QSERDES_V3_660_COM_RESET_SM_STATUS 0x160 >> +#define QSERDES_V3_660_COM_RESTRIM_CODE_STATUS 0x164 >> +#define QSERDES_V3_660_COM_PLLCAL_CODE1_STATUS 0x168 >> +#define QSERDES_V3_660_COM_PLLCAL_CODE2_STATUS 0x16c >> +#define QSERDES_V3_660_COM_BG_CTRL 0x170 >> +#define QSERDES_V3_660_COM_CLK_SELECT 0x174 >> +#define QSERDES_V3_660_COM_HSCLK_SEL 0x178 >> +#define QSERDES_V3_660_COM_INTEGLOOP_BINCODE_STATUS 0x17c >> +#define QSERDES_V3_660_COM_PLL_ANALOG 0x180 >> +#define QSERDES_V3_660_COM_CORECLK_DIV 0x184 >> +#define QSERDES_V3_660_COM_SW_RESET 0x188 >> +#define QSERDES_V3_660_COM_CORE_CLK_EN 0x18c >> +#define QSERDES_V3_660_COM_C_READY_STATUS 0x190 >> +#define QSERDES_V3_660_COM_CMN_CONFIG 0x194 >> +#define QSERDES_V3_660_COM_CMN_RATE_OVERRIDE 0x198 >> +#define QSERDES_V3_660_COM_SVS_MODE_CLK_SEL 0x19c >> +#define QSERDES_V3_660_COM_DEBUG_BUS0 0x1a0 >> +#define QSERDES_V3_660_COM_DEBUG_BUS1 0x1a4 >> +#define QSERDES_V3_660_COM_DEBUG_BUS2 0x1a8 >> +#define QSERDES_V3_660_COM_DEBUG_BUS3 0x1ac >> +#define QSERDES_V3_660_COM_DEBUG_BUS_SEL 0x1b0 >> +#define QSERDES_V3_660_COM_CMN_MISC1 0x1b4 >> +#define QSERDES_V3_660_COM_CORECLK_DIV_MODE1 0x1bc >> +#define QSERDES_V3_660_COM_CMN_RSVD5 0x1c0 > > why are these registers 660 specific and not V3 like we have for > other generations..? Quick looks with V3 regs tells me that seem > similar.... > Well, I looked at them for a long time and the only thing that is similar are the first few QSERDES registers from COM_ATB_SEL1=0x000 to COM_BIAS_EN_CLKBUFLR_EN=0x034. Everything else is different. So I can re-use the V3 for the similar regs, but they are 10%, so I figured instead of combing through all of the sequences to save 10% of the constants and make it slightly less readable just use new constants. Let me know if I should reuse the 14 regs from V3. Regards, Iskren
On 06-08-21, 19:09, Iskren Chernev wrote: > On 8/6/21 3:57 PM, Vinod Koul wrote: > > On 05-08-21, 12:17, Iskren Chernev wrote: > > why are these registers 660 specific and not V3 like we have for > > other generations..? Quick looks with V3 regs tells me that seem > > similar.... > > > > Well, I looked at them for a long time and the only thing that is similar > are the first few QSERDES registers from COM_ATB_SEL1=0x000 to > COM_BIAS_EN_CLKBUFLR_EN=0x034. Everything else is different. So I can re-use Is the offset different? I thought all Vn registers across chips do have same offsets.. > the V3 for the similar regs, but they are 10%, so I figured instead of combing > through all of the sequences to save 10% of the constants and make it slightly > less readable just use new constants. > > Let me know if I should reuse the 14 regs from V3. reuse yes, but would like to understand more why offsets are different, Can you point me to downstream code reference for this?
On 8/9/21 7:48 AM, Vinod Koul wrote: > On 06-08-21, 19:09, Iskren Chernev wrote: >> On 8/6/21 3:57 PM, Vinod Koul wrote: >>> On 05-08-21, 12:17, Iskren Chernev wrote: > >>> why are these registers 660 specific and not V3 like we have for >>> other generations..? Quick looks with V3 regs tells me that seem >>> similar.... >>> >> >> Well, I looked at them for a long time and the only thing that is similar >> are the first few QSERDES registers from COM_ATB_SEL1=0x000 to >> COM_BIAS_EN_CLKBUFLR_EN=0x034. Everything else is different. So I can re-use > > Is the offset different? I thought all Vn registers across chips do have > same offsets.. Upon closer inspection, for the SERDES registers they are 19 common (the first 19), the others are different (different values, different names). About the offsets that stay in DT -- they are the same for V3 and V3-660 (I haven't send DT yet). Just to be clear, offset the is thing you add to each register to get an actual register value, mainline uses relative offsets (base / offset in DT), downstream uses a macro for each register group and the offset is hardcoded in code. Link to the DT (will be submitted after core drivers are merged) [1] [1] https://gitlab.com/ichernev/linux-postmarketos/-/blob/b44c853caf37dd73e059628a1831ad185356a33e/arch/arm64/boot/dts/qcom/sm4250.dtsi#L878 > >> the V3 for the similar regs, but they are 10%, so I figured instead of combing >> through all of the sequences to save 10% of the constants and make it slightly >> less readable just use new constants. >> >> Let me know if I should reuse the 14 regs from V3. > > reuse yes, but would like to understand more why offsets are different, > > Can you point me to downstream code reference for this? As I said, the offsets are the same, the first 19 serdes relative addresses/names are the same (can be reused), the rest is all different. I wrote a tool to compare names and values, I can paste those as well if needed. This is a link to the downstream code (header) [2] [2] https://github.com/OnePlusOSS/android_kernel_oneplus_sm4250/blob/oneplus/SM4250_Q_10.0/drivers/phy/qualcomm/phy-qcom-ufs-qmp-v3-660.h I will do a v2 with the 19 regs reused from the v3 bunch. Regards, Iskren