mbox series

[hwmon-next,v7,0/3] Add support for MPS Multi-phase mp2888 controller

Message ID 20210511055619.118104-1-vadimp@nvidia.com
Headers show
Series Add support for MPS Multi-phase mp2888 controller | expand

Message

Vadim Pasternak May 11, 2021, 5:56 a.m. UTC 
Add driver and documentation for mp2888 device from Monolithic Power
Systems, Inc. (MPS) vendor. This is a digital, multi-phase, pulse-width
modulation controller.

Patch set includes:
Patch #1 - increases maximum number of phases.
Patch #2 - provides mp2888 driver and documentation.
Patch #3 - providesy binding documentation.

Vadim Pasternak (3):
  hwmon: (pmbus) Increase maximum number of phases per page
  hwmon: (pmbus) Add support for MPS Multi-phase mp2888 controller
  dt-bindings: Add MP2888 voltage regulator device

 .../devicetree/bindings/trivial-devices.yaml       |   2 +
 Documentation/hwmon/mp2888.rst                     | 113 ++++++
 drivers/hwmon/pmbus/Kconfig                        |   9 +
 drivers/hwmon/pmbus/Makefile                       |   1 +
 drivers/hwmon/pmbus/mp2888.c                       | 407 +++++++++++++++++++++
 drivers/hwmon/pmbus/pmbus.h                        |   2 +-
 6 files changed, 533 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/hwmon/mp2888.rst
 create mode 100644 drivers/hwmon/pmbus/mp2888.c

Comments

Guenter Roeck May 11, 2021, 1:32 p.m. UTC | #1 
On 5/10/21 10:56 PM, Vadim Pasternak wrote:
> Add driver and documentation for mp2888 device from Monolithic Power
> Systems, Inc. (MPS) vendor. This is a digital, multi-phase, pulse-width
> modulation controller.
> 
> Patch set includes:
> Patch #1 - increases maximum number of phases.
> Patch #2 - provides mp2888 driver and documentation.
> Patch #3 - providesy binding documentation.
> 

Series applied.

Thanks,
Guenter
Vadim Pasternak May 11, 2021, 1:34 p.m. UTC | #2 
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Tuesday, May 11, 2021 4:32 PM
> To: Vadim Pasternak <vadimp@nvidia.com>; robh+dt@kernel.org
> Cc: linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH hwmon-next v7 0/3] Add support for MPS Multi-phase
> mp2888 controller
> 
> On 5/10/21 10:56 PM, Vadim Pasternak wrote:
> > Add driver and documentation for mp2888 device from Monolithic Power
> > Systems, Inc. (MPS) vendor. This is a digital, multi-phase,
> > pulse-width modulation controller.
> >
> > Patch set includes:
> > Patch #1 - increases maximum number of phases.
> > Patch #2 - provides mp2888 driver and documentation.
> > Patch #3 - providesy binding documentation.
> >
> 
> Series applied.

Thank you, Guenter.

I see from the following errors from robot:
>> ERROR: modpost: module mp2888 uses symbol pmbus_do_probe from namespace PMBUS, but does not import it.
>> ERROR: modpost: module mp2888 uses symbol pmbus_read_word_data from namespace PMBUS, but does not import it.
>> ERROR: modpost: module mp2888 uses symbol pmbus_write_word_data from namespace PMBUS, but does not import it.
>> ERROR: modpost: module mp2888 uses symbol pmbus_get_driver_info from namespace PMBUS, but does not import it.

What does it mean?

> 
> Thanks,
> Guenter
Guenter Roeck May 11, 2021, 5:03 p.m. UTC | #3 
On 5/11/21 6:34 AM, Vadim Pasternak wrote:
> 
> 
>> -----Original Message-----
>> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
>> Sent: Tuesday, May 11, 2021 4:32 PM
>> To: Vadim Pasternak <vadimp@nvidia.com>; robh+dt@kernel.org
>> Cc: linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org
>> Subject: Re: [PATCH hwmon-next v7 0/3] Add support for MPS Multi-phase
>> mp2888 controller
>>
>> On 5/10/21 10:56 PM, Vadim Pasternak wrote:
>>> Add driver and documentation for mp2888 device from Monolithic Power
>>> Systems, Inc. (MPS) vendor. This is a digital, multi-phase,
>>> pulse-width modulation controller.
>>>
>>> Patch set includes:
>>> Patch #1 - increases maximum number of phases.
>>> Patch #2 - provides mp2888 driver and documentation.
>>> Patch #3 - providesy binding documentation.
>>>
>>
>> Series applied.
> 
> Thank you, Guenter.
> 
> I see from the following errors from robot:
>>> ERROR: modpost: module mp2888 uses symbol pmbus_do_probe from namespace PMBUS, but does not import it.
>>> ERROR: modpost: module mp2888 uses symbol pmbus_read_word_data from namespace PMBUS, but does not import it.
>>> ERROR: modpost: module mp2888 uses symbol pmbus_write_word_data from namespace PMBUS, but does not import it.
>>> ERROR: modpost: module mp2888 uses symbol pmbus_get_driver_info from namespace PMBUS, but does not import it.
> 
> What does it mean?
> 

It needs

MODULE_IMPORT_NS(PMBUS);

No worries, I'll fix it up.

Guenter