Message ID | 20201223212947.160565-1-paul.kocialkowski@bootlin.com |
---|---|
Headers | show |
Series | drm: LogiCVC display controller support | expand |
nouveau already has something for colorkey: https://drmdb.emersion.fr/properties/4008636142/colorkey I know this is marked "not for merge", but it would be nice to discuss with them and come up with a standardized property.
FWIW this is something I added, hoping it was going to get used at some point, but I never followed up with support in xf86-video-nouveau for Xv. At this point, I'm not sure I ever will. I encoded the "enabled" part into the value with a high bit (1<<24) -- not sure that was such a great idea. All NVIDIA hardware supports colorkey (and not actual alpha, until the very latest GPUs - Volta/Turing families), although my implementation only covers the pre-G80 series (i.e. DX9 and earlier GPUs - pre-2008). Should a determination of usefulness be reached, it would be easy to implement on the remainder though. Cheers, -ilia On Wed, Dec 23, 2020 at 5:20 PM Simon Ser <contact@emersion.fr> wrote: > > nouveau already has something for colorkey: > https://drmdb.emersion.fr/properties/4008636142/colorkey > > I know this is marked "not for merge", but it would be nice to discuss > with them and come up with a standardized property. > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi, On Wed 23 Dec 20, 18:31, Ilia Mirkin wrote: > FWIW this is something I added, hoping it was going to get used at > some point, but I never followed up with support in xf86-video-nouveau > for Xv. At this point, I'm not sure I ever will. I encoded the > "enabled" part into the value with a high bit (1<<24) -- not sure that > was such a great idea. All NVIDIA hardware supports colorkey (and not > actual alpha, until the very latest GPUs - Volta/Turing families), > although my implementation only covers the pre-G80 series (i.e. DX9 > and earlier GPUs - pre-2008). Should a determination of usefulness be > reached, it would be easy to implement on the remainder though. Interesting to know! Regarding a generic colorkey property, there was a discussion under thread: drm: Add generic colorkey properties for display planes and the latest proposal (RFC v4) can be found here: https://patchwork.ozlabs.org/project/linux-tegra/patch/20180807172202.1961-2-digetx@gmail.com/ It looks like this was much more complex than anticipated and the series was more or less abandonned. I didn't feel like picking it up in my logicvc series so I kept the colorkey patch as not for merge. If someone's up for picking the proposal and continuing the discussion, I could provide insight on how it would fit with logicvc though! Cheers, Paul > On Wed, Dec 23, 2020 at 5:20 PM Simon Ser <contact@emersion.fr> wrote: > > > > nouveau already has something for colorkey: > > https://drmdb.emersion.fr/properties/4008636142/colorkey > > > > I know this is marked "not for merge", but it would be nice to discuss > > with them and come up with a standardized property.