| Message ID | 20201112045020.9766-1-f.fainelli@gmail.com |
|---|---|
| Headers | show |
| Series | Broadcom b53 YAML bindings | expand |
On 12.11.2020 05:50, Florian Fainelli wrote: > Provide a default compatible string which is based on the 53011 SRAB > compatible by default. The 4709 and 47094 default to the 53012 SRAB > compatible. > > (...) > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Looks good, thanks! Acked-by: Rafał Miłecki <rafal@milecki.pl>
On 12.11.2020 05:50, Florian Fainelli wrote: > Provide an empty 'ports' container node with the correct #address-cells > and #size-cells properties. This silences the following warning: > > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: > ethernet-switch@18007000: 'oneOf' conditional failed, one must be fixed: > 'ports' is a required property > 'ethernet-ports' is a required property > From schema: > Documentation/devicetree/bindings/net/dsa/b53.yaml > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Nice! Acked-by: Rafał Miłecki <rafal@milecki.pl>
On Wed, Nov 11, 2020 at 08:50:18PM -0800, Florian Fainelli wrote: > Provide a valid compatible string for the Ethernet switch node based on > the board including the switch. This allows us to have sane defaults and > silences the following warnings: > > arch/arm/boot/dts/bcm958522er.dt.yaml: > ethernet-switch@36000: compatible: 'oneOf' conditional failed, > one > must be fixed: > ['brcm,bcm5301x-srab'] is too short > 'brcm,bcm5325' was expected > 'brcm,bcm53115' was expected > 'brcm,bcm53125' was expected > 'brcm,bcm53128' was expected > 'brcm,bcm5365' was expected > 'brcm,bcm5395' was expected > 'brcm,bcm5389' was expected > 'brcm,bcm5397' was expected > 'brcm,bcm5398' was expected > 'brcm,bcm11360-srab' was expected > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab', > 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab', > 'brcm,bcm53019-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab', > 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab', > 'brcm,bcm58311-srab', 'brcm,bcm58313-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab', > 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab', > 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch', > 'brcm,bcm6328-switch', 'brcm,bcm6368-switch'] > From schema: > Documentation/devicetree/bindings/net/dsa/b53.yaml > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
On Wed, Nov 11, 2020 at 08:50:19PM -0800, Florian Fainelli wrote: > Provide an empty 'ports' container node with the correct #address-cells > and #size-cells properties. This silences the following warning: > > arch/arm/boot/dts/bcm958522er.dt.yaml: > ethernet-switch@36000: 'oneOf' conditional failed, one must be fixed: > 'ports' is a required property > 'ethernet-ports' is a required property > From schema: > Documentation/devicetree/bindings/net/dsa/b53.yaml > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- So 'ports' is not going away and getting bulk-replaced with 'ethernet-ports'. Good. Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
On 11/11/2020 8:50 PM, Florian Fainelli wrote: > Hi, > > This patch series fixes the various Broadcom SoCs DTS files and the > existing YAML binding for missing properties before adding a proper b53 > switch YAML binding from Kurt. > > If this all looks good, given that there are quite a few changes to the > DTS files, it might be best if I take them through the upcoming Broadcom > ARM SoC pull requests. Let me know if you would like those patches to be > applied differently. > > Thanks! Series applied to devicetree/next, thanks everyone.
Hi, This patch series fixes the various Broadcom SoCs DTS files and the existing YAML binding for missing properties before adding a proper b53 switch YAML binding from Kurt. If this all looks good, given that there are quite a few changes to the DTS files, it might be best if I take them through the upcoming Broadcom ARM SoC pull requests. Let me know if you would like those patches to be applied differently. Thanks! Changes in v2: - collected Reviewed-by and Acked-by tags from Vladimir and Rob - corrected BCM5301X default compatibles based on data provided by Rafal on his different devices - updated strategy for NSP to tackle each board separately - provide both a ports {} container node and its #address-cells and #size-cells properties - renamed binding from b53.yaml to brcm,b53.yaml Florian Fainelli (9): dt-bindings: net: dsa: Extend switch nodes pattern dt-bindings: net: dsa: Document sfp and managed properties ARM: dts: BCM5301X: Update Ethernet switch node name ARM: dts: BCM5301X: Add a default compatible for switch node ARM: dts: BCM5301X: Provide defaults ports container node ARM: dts: NSP: Update ethernet switch node name ARM: dts: NSP: Fix Ethernet switch SGMII register name ARM: dts: NSP: Add a SRAB compatible string for each board ARM: dts: NSP: Provide defaults ports container node Kurt Kanzenbach (1): dt-bindings: net: dsa: b53: Add YAML bindings .../devicetree/bindings/net/dsa/b53.txt | 149 ----------- .../devicetree/bindings/net/dsa/brcm,b53.yaml | 249 ++++++++++++++++++ .../devicetree/bindings/net/dsa/dsa.yaml | 6 +- MAINTAINERS | 2 +- arch/arm/boot/dts/bcm-nsp.dtsi | 8 +- arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts | 3 - arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts | 3 - arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 3 - arch/arm/boot/dts/bcm47081-luxul-xap-1410.dts | 3 - arch/arm/boot/dts/bcm47081-luxul-xwr-1200.dts | 3 - arch/arm/boot/dts/bcm4709.dtsi | 4 + .../boot/dts/bcm47094-linksys-panamera.dts | 3 - arch/arm/boot/dts/bcm47094-luxul-xap-1610.dts | 3 - arch/arm/boot/dts/bcm47094-luxul-xwc-2000.dts | 3 - arch/arm/boot/dts/bcm47094-luxul-xwr-3100.dts | 3 - .../boot/dts/bcm47094-luxul-xwr-3150-v1.dts | 3 - arch/arm/boot/dts/bcm47094.dtsi | 4 + arch/arm/boot/dts/bcm5301x.dtsi | 8 +- arch/arm/boot/dts/bcm953012er.dts | 3 - arch/arm/boot/dts/bcm958522er.dts | 4 + arch/arm/boot/dts/bcm958525er.dts | 4 + arch/arm/boot/dts/bcm958525xmc.dts | 4 + arch/arm/boot/dts/bcm958622hr.dts | 3 - arch/arm/boot/dts/bcm958623hr.dts | 3 - arch/arm/boot/dts/bcm958625hr.dts | 3 - arch/arm/boot/dts/bcm958625k.dts | 3 - arch/arm/boot/dts/bcm988312hr.dts | 3 - 27 files changed, 287 insertions(+), 203 deletions(-) delete mode 100644 Documentation/devicetree/bindings/net/dsa/b53.txt create mode 100644 Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml