Message ID | 20200626005601.241022-1-megous@megous.com |
---|---|
Headers | show |
Series | Add support for PinePhone LCD panel | expand |
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > This rename is done so that the driver matches the name of the > display controller and in preparation for adding support for more > panels to the driver. > > This is just a basic file rename, with no code changes. > > Signed-off-by: Ondrej Jirman <megous@megous.com> This is the right thing to do. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > This is done so that code that's not specific to a particular > jh057n panel is named after the controller. Functions specific > to the panel are kept named after the panel. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > Parametrize the driver so that it can support more panels based > on st7703 controller. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > It's better than having it spread around the driver. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > Calling sleep out and display on is a controller specific part > of the initialization process. Move it out of the panel specific > initialization function to the enable callback. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in > PinePhone. Add support for it. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > Signed-off-by: Ondrej Jirman <megous@megous.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > The datasheet suggests to issue sleep in after display off > as a part of the panel's shutdown sequence. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > The reset pin is inverted, so if we don't assert reset, the actual gpio > will be high and may keep driving the IO port of the panel. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > From: Icenowy Zheng <icenowy@aosc.io> > > PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for > display. > > Backlight levels curve was optimized by Martijn Braam using a > lux meter. > > Add its device nodes. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > Signed-off-by: Martijn Braam <martijn@brixit.nl> > Signed-off-by: Ondrej Jirman <megous@megous.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > Pinephone has a Goodix GT917S capacitive touchscreen controller on > I2C0 bus. Add support for it. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Hello Linus, On Wed, Jul 01, 2020 at 09:50:40AM +0200, Linus Walleij wrote: > On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman <megous@megous.com> wrote: > > > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in > > PinePhone. Add support for it. > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > Signed-off-by: Ondrej Jirman <megous@megous.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Thank you very much for the review. :) I've sent v6 which should fix the currently remaining issues with dt bindings + one timing issue I've found in this patch. I've kept your reviewed-by tag, because it's a fairly trivial issue. But feel free to complain. thank you again and regards, o. > Yours, > Linus Walleij