mbox series

[v5,0/7] TAS2562 issue fixes and slot programming

Message ID 20200624161459.19248-1-dmurphy@ti.com
Headers show
Series TAS2562 issue fixes and slot programming | expand

Message

Dan Murphy June 24, 2020, 4:14 p.m. UTC 
Hello

This series fixes issues tih the shut-down gpio device tree allocation and a
code format issue found.

While working on a project slot programming for the tx and rx paths needed to be
enabled.  In addition the vsense slot programming needed to be configurable and
not directly a simpler adder to the isense slot.

Finally the yaml conversion patch was moved to be the last patch in the series
so that the fixes can be applied and the yaml can be reviewed appropriately
and does not hold up the rest of the fixes.

Dan


Dan Murphy (7):
  dt-bindings: tas2562: Fix shut-down gpio property
  ASoC: tas2562: Update shutdown GPIO property
  ASoC: tas2562: Fix format issue for extra space before a comma
  ASoC: tas2562: Add rx and tx slot programming
  dt-bindings: tas2562: Add voltage sense slot property
  ASoC: tas2562: Add voltage sense slot configuration
  dt-bindings: tas2562: Convert the tas2562 binding to yaml

 .../devicetree/bindings/sound/tas2562.txt     |   34 -
 .../devicetree/bindings/sound/tas2562.yaml    |   77 +
 arch/arm/boot/compressed/fdt.h                |   66 +
 arch/arm/boot/compressed/libfdt.h             | 2072 +++++++++++++++++
 arch/arm/boot/compressed/libfdt_internal.h    |  173 ++
 sound/soc/codecs/tas2562.c                    |   88 +-
 sound/soc/codecs/tas2562.h                    |    4 +
 7 files changed, 2462 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/tas2562.txt
 create mode 100644 Documentation/devicetree/bindings/sound/tas2562.yaml
 create mode 100644 arch/arm/boot/compressed/fdt.h
 create mode 100644 arch/arm/boot/compressed/libfdt.h
 create mode 100644 arch/arm/boot/compressed/libfdt_internal.h

Comments

Mark Brown June 24, 2020, 4:29 p.m. UTC | #1 
On Wed, Jun 24, 2020 at 11:14:55AM -0500, Dan Murphy wrote:
> Fix the issue found that there is an extra space before a comma in the
> volume control.
> 
> Fixes: bf726b1c86f2c ("ASoC: tas2562: Add support for digital volume control")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  arch/arm/boot/compressed/fdt.h             |   66 +
>  arch/arm/boot/compressed/libfdt.h          | 2072 ++++++++++++++++++++
>  arch/arm/boot/compressed/libfdt_internal.h |  173 ++
>  sound/soc/codecs/tas2562.c                 |    2 +-

I'm guessing those libfdt changes weren't supposed to be here?
Dan Murphy June 24, 2020, 4:58 p.m. UTC | #2 
Mark

On 6/24/20 11:29 AM, Mark Brown wrote:
> On Wed, Jun 24, 2020 at 11:14:55AM -0500, Dan Murphy wrote:
>> Fix the issue found that there is an extra space before a comma in the
>> volume control.
>>
>> Fixes: bf726b1c86f2c ("ASoC: tas2562: Add support for digital volume control")
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>   arch/arm/boot/compressed/fdt.h             |   66 +
>>   arch/arm/boot/compressed/libfdt.h          | 2072 ++++++++++++++++++++
>>   arch/arm/boot/compressed/libfdt_internal.h |  173 ++
>>   sound/soc/codecs/tas2562.c                 |    2 +-
> I'm guessing those libfdt changes weren't supposed to be here?

No they were not those must have been added when I verified the build.

Dan
Dan Murphy June 24, 2020, 5:36 p.m. UTC | #3 
Mark

On 6/24/20 11:58 AM, Dan Murphy wrote:
> Mark
>
> On 6/24/20 11:29 AM, Mark Brown wrote:
>> On Wed, Jun 24, 2020 at 11:14:55AM -0500, Dan Murphy wrote:
>>> Fix the issue found that there is an extra space before a comma in the
>>> volume control.
>>>
>>> Fixes: bf726b1c86f2c ("ASoC: tas2562: Add support for digital volume 
>>> control")
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> ---
>>>   arch/arm/boot/compressed/fdt.h             |   66 +
>>>   arch/arm/boot/compressed/libfdt.h          | 2072 
>>> ++++++++++++++++++++
>>>   arch/arm/boot/compressed/libfdt_internal.h |  173 ++
>>>   sound/soc/codecs/tas2562.c                 |    2 +-
>> I'm guessing those libfdt changes weren't supposed to be here?
>
> No they were not those must have been added when I verified the build.
>
Can this patchset get a review as well so I can fix before I post v6?

Not sure what the current work load is for review or merge.

Dan


> Dan
>
Mark Brown June 24, 2020, 5:48 p.m. UTC | #4 
On Wed, Jun 24, 2020 at 12:36:02PM -0500, Dan Murphy wrote:

> Can this patchset get a review as well so I can fix before I post v6?

> Not sure what the current work load is for review or merge.

Well, it's less work to review if it's been fixed...
Dan Murphy June 24, 2020, 5:51 p.m. UTC | #5 
Mark

On 6/24/20 12:48 PM, Mark Brown wrote:
> On Wed, Jun 24, 2020 at 12:36:02PM -0500, Dan Murphy wrote:
>
>> Can this patchset get a review as well so I can fix before I post v6?
>> Not sure what the current work load is for review or merge.
> Well, it's less work to review if it's been fixed...

Ok fixed and sent v6