Message ID | 20191118152518.3374263-1-adrian.ratiu@collabora.com |
---|---|
Headers | show |
Series | Genericize DW MIPI DSI bridge and add i.MX 6 driver | expand |
Hi Adrian, On Mon, Nov 18, 2019 at 12:25 PM Adrian Ratiu <adrian.ratiu@collabora.com> wrote: Some nitpicks: > + > +config DRM_IMX_MIPI_DSI > + tristate "Freescale i.MX DRM MIPI DSI" This text seems too generic as there are i.MX SoCs that use different MIPI DSI IP. Maybe "Freescale i.MX6 DRM MIPI DSI" instead? > +module_platform_driver(imx_mipi_dsi_driver); > + > +MODULE_DESCRIPTION("i.MX MIPI DSI host controller driver"); i.MX6 MIPI DSI, please.
On Tue, 19 Nov 2019, Fabio Estevam <festevam@gmail.com> wrote: > Hi Adrian, Hi Fabio, > > On Mon, Nov 18, 2019 at 12:25 PM Adrian Ratiu > <adrian.ratiu@collabora.com> wrote: > > Some nitpicks: > >> + +config DRM_IMX_MIPI_DSI + tristate "Freescale i.MX DRM >> MIPI DSI" > > This text seems too generic as there are i.MX SoCs that use > different MIPI DSI IP. > > Maybe "Freescale i.MX6 DRM MIPI DSI" instead? Yes, this is a good idea, will update in a newer version to make it more specific. I'll let this version sit a little more on review so others also have time to review. Thank you! > >> +module_platform_driver(imx_mipi_dsi_driver); + >> +MODULE_DESCRIPTION("i.MX MIPI DSI host controller driver"); > > i.MX6 MIPI DSI, please. > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel