mbox series

[RESEND,v2,0/2] clk: meson8b: fix typo "ABP" -> "APB"

Message ID 20190210222603.6404-1-martin.blumenstingl@googlemail.com
Headers show
Series clk: meson8b: fix typo "ABP" -> "APB" | expand

Message

Martin Blumenstingl Feb. 10, 2019, 10:26 p.m. UTC
It turns out that I'm not good at spelling "APB". Unfortunately an ABP
(instead of APB) typo snug into two clocks in v5.0.

Currently there are no users of that clock yet, so fix it now
before it's too late (meaning before it's used by <something>).

I decided to go the "normal" route where we can have separate
branches for the dt-bindings and the drivers in the clk-meson
repo. This means:
- new (typo-free) clock #define
- change the clock controller to use the new #define
- (next development cycle) drop the old #define

resend - changes since v2 at [1]:
- include the device-tree maintainers / mailing list

Changes since v1 at [0]:
- split into a dt-bindings and clock controller driver patch


[0] https://patchwork.kernel.org/cover/10742001/
[1] https://patchwork.kernel.org/cover/10772199/


Martin Blumenstingl (2):
  dt-bindings: clock: meson8b: add APB clock definition
  clk: meson: meson8b: fix the naming of the APB clocks

 drivers/clk/meson/meson8b.c              | 26 ++++++++++++------------
 drivers/clk/meson/meson8b.h              |  2 +-
 include/dt-bindings/clock/meson8b-clkc.h |  1 +
 3 files changed, 15 insertions(+), 14 deletions(-)

Comments

Jerome Brunet Feb. 13, 2019, 8:40 a.m. UTC | #1
On Sun, 2019-02-10 at 23:26 +0100, Martin Blumenstingl wrote:
> It turns out that I'm not good at spelling "APB". Unfortunately an ABP
> (instead of APB) typo snug into two clocks in v5.0.
> 
> Currently there are no users of that clock yet, so fix it now
> before it's too late (meaning before it's used by <something>).
> 
> I decided to go the "normal" route where we can have separate
> branches for the dt-bindings and the drivers in the clk-meson
> repo. This means:
> - new (typo-free) clock #define
> - change the clock controller to use the new #define
> - (next development cycle) drop the old #define
> 
> resend - changes since v2 at [1]:
> - include the device-tree maintainers / mailing list
> 
> Changes since v1 at [0]:
> - split into a dt-bindings and clock controller driver patch
> 
> 
> [0] https://patchwork.kernel.org/cover/10742001/
> [1] https://patchwork.kernel.org/cover/10772199/
> 
> 
> Martin Blumenstingl (2):
>   dt-bindings: clock: meson8b: add APB clock definition
>   clk: meson: meson8b: fix the naming of the APB clocks
> 
>  drivers/clk/meson/meson8b.c              | 26 ++++++++++++------------
>  drivers/clk/meson/meson8b.h              |  2 +-
>  include/dt-bindings/clock/meson8b-clkc.h |  1 +
>  3 files changed, 15 insertions(+), 14 deletions(-)
> 

Acked-by: Jerome Brunet <jbrunet@baylibre.com>
Neil Armstrong Feb. 13, 2019, 9 a.m. UTC | #2
On 13/02/2019 09:40, Jerome Brunet wrote:
> On Sun, 2019-02-10 at 23:26 +0100, Martin Blumenstingl wrote:
>> It turns out that I'm not good at spelling "APB". Unfortunately an ABP
>> (instead of APB) typo snug into two clocks in v5.0.
>>
>> Currently there are no users of that clock yet, so fix it now
>> before it's too late (meaning before it's used by <something>).
>>
>> I decided to go the "normal" route where we can have separate
>> branches for the dt-bindings and the drivers in the clk-meson
>> repo. This means:
>> - new (typo-free) clock #define
>> - change the clock controller to use the new #define
>> - (next development cycle) drop the old #define
>>
>> resend - changes since v2 at [1]:
>> - include the device-tree maintainers / mailing list
>>
>> Changes since v1 at [0]:
>> - split into a dt-bindings and clock controller driver patch
>>
>>
>> [0] https://patchwork.kernel.org/cover/10742001/
>> [1] https://patchwork.kernel.org/cover/10772199/
>>
>>
>> Martin Blumenstingl (2):
>>   dt-bindings: clock: meson8b: add APB clock definition
>>   clk: meson: meson8b: fix the naming of the APB clocks
>>
>>  drivers/clk/meson/meson8b.c              | 26 ++++++++++++------------
>>  drivers/clk/meson/meson8b.h              |  2 +-
>>  include/dt-bindings/clock/meson8b-clkc.h |  1 +
>>  3 files changed, 15 insertions(+), 14 deletions(-)
>>
> 
> Acked-by: Jerome Brunet <jbrunet@baylibre.com>
> 

Applied to next/drivers for Linux 5.1-rc1