| Message ID | 1551780434-4580-1-git-send-email-claudiu.beznea@microchip.com |
|---|---|
| Headers | show |
| Series | add LCD support for SAM9X60 | expand |
On Tue, 05 Mar 2019, Claudiu.Beznea@microchip.com wrote: > From: Claudiu Beznea <claudiu.beznea@microchip.com> > > Add compatible for SAM9X60 HLCD controller. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > drivers/mfd/atmel-hlcdc.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks.
Hi Lee, On v1 of this series Thierry suggested that this patch would be good to also go through MFD tree. Would you be able to also pick this patch? Bellow is his comment on v1 version of this patch: https://patchwork.ozlabs.org/patch/1049006/ Thank you, Claudiu Beznea On 05.03.2019 12:07, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea <claudiu.beznea@microchip.com> > > Add compatible string for SAM9X60 HLCDC's PWM. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > Acked-by: Thierry Reding <thierry.reding@gmail.com> > --- > drivers/pwm/pwm-atmel-hlcdc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c > index 54c6633d9b5d..331ca0233d9e 100644 > --- a/drivers/pwm/pwm-atmel-hlcdc.c > +++ b/drivers/pwm/pwm-atmel-hlcdc.c > @@ -246,6 +246,9 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = { > .compatible = "atmel,sama5d4-hlcdc", > .data = &atmel_hlcdc_pwm_sama5d3_errata, > }, > + { > + .compatible = "microchip,sam9x60-hlcdc", > + }, > { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, atmel_hlcdc_dt_ids); >
On Tue, 05 Mar 2019, Claudiu.Beznea@microchip.com wrote: > From: Claudiu Beznea <claudiu.beznea@microchip.com> > > Add compatible string for SAM9X60 HLCDC's PWM. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > Acked-by: Thierry Reding <thierry.reding@gmail.com> > --- > drivers/pwm/pwm-atmel-hlcdc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c > index 54c6633d9b5d..331ca0233d9e 100644 > --- a/drivers/pwm/pwm-atmel-hlcdc.c > +++ b/drivers/pwm/pwm-atmel-hlcdc.c > @@ -246,6 +246,9 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = { > .compatible = "atmel,sama5d4-hlcdc", > .data = &atmel_hlcdc_pwm_sama5d3_errata, > }, > + { > + .compatible = "microchip,sam9x60-hlcdc", > + }, Please make this a single line entry, like the one below. > { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, atmel_hlcdc_dt_ids);
From: Claudiu Beznea <claudiu.beznea@microchip.com> Hi, These patches adds support for SAM9X60's LCD controller. First patches add option to specify if controller clock source is fixed. Second patch avoid a variable initialization in atmel_hlcdc_crtc_mode_set_nofb(). The 3rd one adds specific bindings for SAM9X60 LCD controller. The 4th and 5th add compatibles in the driver. The 6th patch enables sys_clk in probe since SAM9X60 needs this. Specific support was added also in suspend/resume hooks. The work in the 6th patch was done based on support added in 1st patch. The 7th patch adds SAM9X60's LCD configuration and enabled it. I kept a big series including PWM, MFD, LCD changes due to shared DT bindings. If you prefer, I'm available to send them separately. Please let me know. Thank you, Claudiu Beznea Changes in v2: - use "|" operator in patch 1/7 to set ATMEL_HLCDC_CLKSEL on cfg - collect Acked-by, Reviewed-by tags Claudiu Beznea (5): drm: atmel-hlcdc: add config option for clock selection drm: atmel-hlcdc: avoid initializing cfg with zero dt-bindings: mfd: add bindings for SAM9X60 HLCD controller mfd: atmel-hlcdc: add compatible for SAM9X60 HLCD controller pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM Sandeep Sheriker Mallikarjun (2): drm: atmel-hlcdc: enable sys_clk during initalization. drm: atmel-hlcdc: add sam9x60 LCD controller .../devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 ++-- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 120 ++++++++++++++++++++- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + drivers/mfd/atmel-hlcdc.c | 1 + drivers/pwm/pwm-atmel-hlcdc.c | 3 + 6 files changed, 135 insertions(+), 10 deletions(-)