| Message ID | 1509377627-11362-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| Headers | show |
| Series | .gitignore / kbuild: of: ignore and clean *.dtb and *.dtb.S globally | expand |
On Mon, Oct 30, 2017 at 10:33 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > We need to add "clean-files" in Makfiles to clean up DT blobs, but we > often miss to do so. > > Since there are no source files that end with .dtb or .dtb.S, so we > can clean-up those files from the top-level Makefile. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 63a4c0e..c577c63 100644 > --- a/Makefile > +++ b/Makefile > @@ -1544,7 +1544,7 @@ clean: $(clean-dirs) > $(call cmd,rmfiles) > @find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \ > \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ > - -o -name '*.ko.*' \ > + -o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \ With this we can remove all the occurrences in the kernel: $ git grep 'clean.*dtb' Otherwise, the series looks good to me. I'm happy to apply it if the kbuild folks don't. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, 2017-10-31 0:53 GMT+09:00 Rob Herring <robh+dt@kernel.org>: > On Mon, Oct 30, 2017 at 10:33 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: >> We need to add "clean-files" in Makfiles to clean up DT blobs, but we >> often miss to do so. >> >> Since there are no source files that end with .dtb or .dtb.S, so we >> can clean-up those files from the top-level Makefile. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> --- >> >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index 63a4c0e..c577c63 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1544,7 +1544,7 @@ clean: $(clean-dirs) >> $(call cmd,rmfiles) >> @find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \ >> \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ >> - -o -name '*.ko.*' \ >> + -o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \ > > With this we can remove all the occurrences in the kernel: > > $ git grep 'clean.*dtb' > > Otherwise, the series looks good to me. I'm happy to apply it if the > kbuild folks don't. > > Rob Yes, please. Thanks!
On Tue, Oct 31, 2017 at 01:32:15AM +0900, Masahiro Yamada wrote: > Hi Rob, > > 2017-10-31 0:53 GMT+09:00 Rob Herring <robh+dt@kernel.org>: > > On Mon, Oct 30, 2017 at 10:33 AM, Masahiro Yamada > > <yamada.masahiro@socionext.com> wrote: > >> We need to add "clean-files" in Makfiles to clean up DT blobs, but we > >> often miss to do so. > >> > >> Since there are no source files that end with .dtb or .dtb.S, so we > >> can clean-up those files from the top-level Makefile. > >> > >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > >> --- > >> > >> Makefile | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/Makefile b/Makefile > >> index 63a4c0e..c577c63 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -1544,7 +1544,7 @@ clean: $(clean-dirs) > >> $(call cmd,rmfiles) > >> @find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \ > >> \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ > >> - -o -name '*.ko.*' \ > >> + -o -name '*.ko.*' -o -name '*.dtb' -o -name '*.dtb.S' \ > > > > With this we can remove all the occurrences in the kernel: > > > > $ git grep 'clean.*dtb' > > > > Otherwise, the series looks good to me. I'm happy to apply it if the > > kbuild folks don't. > > > > Rob > > Yes, please. Thanks! Can you post a follow-up patch removing all the clean-files lines. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Recently, overlay test data were added to of/unittest-data, but I notice they are not ignored or cleaned. Actually, we often forget .gitignore / clean-files at the first commit. We have DT things in various places in the kernel tree, so I think it is OK to move them to the top-level. Is this OK from the DT point of view? Masahiro Yamada (3): .gitignore: sort normal pattern rules alphabetically .gitignore: move *.dtb and *.dtb.S patterns to the top-level .gitignore kbuild: clean up *.dtb and *.dtb.S patterns from top-level Makefile .gitignore | 44 +++++++++++++++++++------------------ Makefile | 2 +- arch/arc/boot/.gitignore | 1 - arch/arm/boot/.gitignore | 1 - arch/arm64/boot/dts/.gitignore | 1 - arch/metag/boot/.gitignore | 1 - arch/microblaze/boot/.gitignore | 1 - arch/mips/boot/.gitignore | 1 - arch/nios2/boot/.gitignore | 1 - arch/powerpc/boot/.gitignore | 1 - arch/xtensa/boot/.gitignore | 1 - drivers/of/unittest-data/.gitignore | 2 -- 12 files changed, 24 insertions(+), 33 deletions(-) delete mode 100644 arch/arm64/boot/dts/.gitignore delete mode 100644 drivers/of/unittest-data/.gitignore