| Message ID | 51B6C8CD.7020807@tomtom.com |
|---|---|
| State | Not Applicable |
| Headers | show |
Filipp, All, On 2013-06-11 06:49 +0000, Filipp Andjelo spake thusly: > I just built the i686-unknown-mingw32 toolchain, where I got errors > about undefined symbol building DUMA. There was one include missing to > build it for mingw32. It is my first time here and I currently don't > know a better way to commit a patch. If it was wrong, just tell how I > could make it better next time :) No problem, we are ahere to learn! :-) The patch below is a patch against duma, not against crosstool-NG. I'd suggest you submit htis patch to upstream DUMA first Then: - add this file in patches/duma/2_5_15/100-fix-mingw32-build.patch - send here a patch that adds this file Do not forget to sign-off your work: http://elinux.org/Developer_Certificate_Of_Origin > diff -durN duma_2_5_15.orig/print.c duma_2_5_15/print.c > --- duma_2_5_15.orig/print.c 2013-06-11 08:19:32.929986085 +0200 > +++ duma_2_5_15/print.c 2013-06-11 08:21:07.369983168 +0200 > @@ -42,7 +42,7 @@ > #include <windows.h> > #include <winbase.h> > #include <io.h> > - > + #include <fcntl.h> Please keep the indentation already used in this file. > #ifndef __CYGWIN__ > /* already defined in cygwin headers */ > typedef LPVOID caddr_t; Regards, Yann E. MORIN.
diff -durN duma_2_5_15.orig/print.c duma_2_5_15/print.c --- duma_2_5_15.orig/print.c 2013-06-11 08:19:32.929986085 +0200 +++ duma_2_5_15/print.c 2013-06-11 08:21:07.369983168 +0200 @@ -42,7 +42,7 @@ #include <windows.h> #include <winbase.h> #include <io.h> - + #include <fcntl.h> #ifndef __CYGWIN__ /* already defined in cygwin headers */ typedef LPVOID caddr_t;