| Message ID | e443dfcec4c084f823c718aa4c7740eddb3b628e.1426545571.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, Mar 16, 2015 at 11:41 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > At the time we introduced hashes, we did not want to be too harsh in the > beginning, and give people some time to adapt and accept to hashes. So > we so far only whined^Wwarned about a missing hash file. > > Some time has passed now, and people are still missing updating hashes > when bumping packages. > > Let's make that warning a little bit more annoying... > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Samuel Martin <s.martin49@gmail.com> > --- > support/download/check-hash | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/support/download/check-hash b/support/download/check-hash > index 4cc62f3..7971c38 100755 > --- a/support/download/check-hash > +++ b/support/download/check-hash > @@ -88,10 +88,6 @@ while read t h f; do > done <"${h_file}" > > if [ ${nb_checks} -eq 0 ]; then > - if [ -n "${BR2_ENFORCE_CHECK_HASH}" ]; then > - printf "ERROR: No hash found for %s\n" "${base}" >&2 > - exit 2 > - else > - printf "WARNING: No hash found for %s\n" "${base}" >&2 > - fi > + printf "ERROR: No hash found for %s\n" "${base}" >&2 > + exit 2 > fi > -- > 1.9.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot Regards,
On 16/03/15 23:41, Yann E. MORIN wrote: > At the time we introduced hashes, we did not want to be too harsh in the > beginning, and give people some time to adapt and accept to hashes. So > we so far only whined^Wwarned about a missing hash file. > > Some time has passed now, and people are still missing updating hashes > when bumping packages. > > Let's make that warning a little bit more annoying... If you ever revive this series (which I think would be a good idea), don't forget to remove the reference to BR2_ENFORCE_CHECK_HASH from the manual as well. Regards, Arnout > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > support/download/check-hash | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/support/download/check-hash b/support/download/check-hash > index 4cc62f3..7971c38 100755 > --- a/support/download/check-hash > +++ b/support/download/check-hash > @@ -88,10 +88,6 @@ while read t h f; do > done <"${h_file}" > > if [ ${nb_checks} -eq 0 ]; then > - if [ -n "${BR2_ENFORCE_CHECK_HASH}" ]; then > - printf "ERROR: No hash found for %s\n" "${base}" >&2 > - exit 2 > - else > - printf "WARNING: No hash found for %s\n" "${base}" >&2 > - fi > + printf "ERROR: No hash found for %s\n" "${base}" >&2 > + exit 2 > fi >
Arnout, All, On 2015-03-19 00:15 +0100, Arnout Vandecappelle spake thusly: > On 16/03/15 23:41, Yann E. MORIN wrote: > > At the time we introduced hashes, we did not want to be too harsh in the > > beginning, and give people some time to adapt and accept to hashes. So > > we so far only whined^Wwarned about a missing hash file. > > > > Some time has passed now, and people are still missing updating hashes > > when bumping packages. > > > > Let's make that warning a little bit more annoying... > > If you ever revive this series (which I think would be a good idea), don't > forget to remove the reference to BR2_ENFORCE_CHECK_HASH from the manual as well. Already done in v2: http://patchwork.ozlabs.org/patch/450979/ ;-) Regards, Yann E. MORIN.
diff --git a/support/download/check-hash b/support/download/check-hash index 4cc62f3..7971c38 100755 --- a/support/download/check-hash +++ b/support/download/check-hash @@ -88,10 +88,6 @@ while read t h f; do done <"${h_file}" if [ ${nb_checks} -eq 0 ]; then - if [ -n "${BR2_ENFORCE_CHECK_HASH}" ]; then - printf "ERROR: No hash found for %s\n" "${base}" >&2 - exit 2 - else - printf "WARNING: No hash found for %s\n" "${base}" >&2 - fi + printf "ERROR: No hash found for %s\n" "${base}" >&2 + exit 2 fi
At the time we introduced hashes, we did not want to be too harsh in the beginning, and give people some time to adapt and accept to hashes. So we so far only whined^Wwarned about a missing hash file. Some time has passed now, and people are still missing updating hashes when bumping packages. Let's make that warning a little bit more annoying... Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- support/download/check-hash | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)