From patchwork Mon May 12 14:44:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 348048 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 77529140083 for ; Tue, 13 May 2014 00:46:46 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 582B68B799; Mon, 12 May 2014 14:46:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EfbCRdqcEczm; Mon, 12 May 2014 14:46:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1332D8B66D; Mon, 12 May 2014 14:46:43 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 7757D1C2188 for ; Mon, 12 May 2014 14:46:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 733358147C for ; Mon, 12 May 2014 14:46:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a-B4+ZlgvzPE for ; Mon, 12 May 2014 14:46:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by whitealder.osuosl.org (Postfix) with ESMTPS id 9605F84956 for ; Mon, 12 May 2014 14:46:39 +0000 (UTC) Received: by mail-wg0-f49.google.com with SMTP id m15so6853380wgh.8 for ; Mon, 12 May 2014 07:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:content-transfer-encoding:subject :message-id:in-reply-to:references:user-agent:date:from:to:cc; bh=YEgDsjkoHPulBlL7hr7QteHkZ779rBaaAxzJslkoYo0=; b=dNWLL1bIMsZ3SyGHxQ6ZxUliWxem/gNNdrw2rcq3u91PVCtH6KbC6eTCj1i4Gi9kU4 FKYPrPpNjmmgJfTCL+nQ0caD9hKcdk6nzXocW9GKNY0CZ4gKA9wFIKxkq58VXhP/0e4z Lzb8OpKcuQzjwlr2z7Y8516ZDGvU8YC4dR3TEV/WyUy/tN8yv4C2oXmSbY69OcTgh2Q5 asSIxh9fauJNvwkL7rhQW1utX/u6cPC9++O3sn9fylWVq2BHZXQne5CUHLTT4/gM5GGR 1tfqQUWDMcvgyQp0tBSS0vnTBp0sqK52Ka4JghWDm72ereEkA9WGlfI4MUiQFzH3x8bx 5n4A== X-Received: by 10.180.19.167 with SMTP id g7mr16129311wie.46.1399905998082; Mon, 12 May 2014 07:46:38 -0700 (PDT) Received: from [127.0.1.1] (alc112.alcatel.be. [195.207.101.112]) by mx.google.com with ESMTPSA id h19sm16499969wiw.17.2014.05.12.07.46.36 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 12 May 2014 07:46:37 -0700 (PDT) MIME-Version: 1.0 X-Mercurial-Node: e2ad9038486eea4e435ab8df49e4ff7d20962907 Message-Id: In-Reply-To: References: User-Agent: Mercurial-patchbomb/2.2.2 Date: Mon, 12 May 2014 16:44:11 +0200 From: Thomas De Schampheleire To: buildroot@buildroot.org Cc: thomas.petazzoni@free-electrons.com, "Yann E. MORIN" Subject: [Buildroot] [PATCH 3 of 7 v2] pkg-virtual: simplify definition of FOO_VERSION to 'virtual' X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net As mentioned in the e-mail accompanying the introduction of the pkg-virtual infrastructure [1], the definition of FOO_VERSION is 'strange'. After the cleanup of single/double dollar signs in inner-generic-package, the special construction in pkg-virtual is no longer needed and can be simplified. Signed-off-by: Thomas De Schampheleire Acked-by: "Yann E. MORIN" [1] http://lists.busybox.net/pipermail/buildroot/2014-April/093670.html --- v2: no changes Note: this patch should only be applied when the first patch in this series is. package/pkg-virtual.mk | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/package/pkg-virtual.mk b/package/pkg-virtual.mk --- a/package/pkg-virtual.mk +++ b/package/pkg-virtual.mk @@ -45,8 +45,7 @@ endif $(2)_SOURCE = # Fake a version string, so it looks nicer in the build log -$(3)_VERSION = virtual -HOST_$(3)_VERSION = virtual +$(2)_VERSION = virtual # This must be repeated from inner-generic-package, otherwise we get an empty # _DEPENDENCIES