| Message ID | e1d03e22b10b073d5906a4b6df22c72d38bfd8c2.1378330371.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
Yann E. MORIN wrote: > From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > In case there are many arguments passed to the tools, the command line > can get very long, and difficult to parse visually. > > For example, the Linux kernel passes a lot of arguments to gcc (at least > 45, which gives 53 with our hard-coded args). Looking at such a command > line is daunting. > > So, add the possibility to print each argument on its own line. > > Also, enclose all args between single quotes, so the command line > can be safely copy-pasted without special chars (spaces, $) being > inrerpreted by the shell. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> This feature should be mentioned in the docs. Apart for that: Acked-by: Luca Ceresoli <luca@lucaceresoli.net> Tested-by: Luca Ceresoli <luca@lucaceresoli.net> [Tested on arm_foundationv8_defconfig] Luca
Luca, All, On 2013-09-05 14:48 +0200, Luca Ceresoli spake thusly: > Yann E. MORIN wrote: > >From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > > >In case there are many arguments passed to the tools, the command line > >can get very long, and difficult to parse visually. > > > >For example, the Linux kernel passes a lot of arguments to gcc (at least > >45, which gives 53 with our hard-coded args). Looking at such a command > >line is daunting. > > > >So, add the possibility to print each argument on its own line. > > > >Also, enclose all args between single quotes, so the command line > >can be safely copy-pasted without special chars (spaces, $) being > >inrerpreted by the shell. > > > >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > This feature should be mentioned in the docs. Well, for now, BR_DEBUG_WRAPPER is not even documented. But I agree this is missing; will add. > Apart for that: > > Acked-by: Luca Ceresoli <luca@lucaceresoli.net> > Tested-by: Luca Ceresoli <luca@lucaceresoli.net> > [Tested on arm_foundationv8_defconfig] I'll add those when I respin the patch. Thank you! :-) Regards, Yann E. MORIN.
diff --git a/toolchain/toolchain-external/ext-toolchain-wrapper.c b/toolchain/toolchain-external/ext-toolchain-wrapper.c index 565e36b..dfdfcff 100644 --- a/toolchain/toolchain-external/ext-toolchain-wrapper.c +++ b/toolchain/toolchain-external/ext-toolchain-wrapper.c @@ -74,7 +74,8 @@ int main(int argc, char **argv) char *relbasedir, *absbasedir; char *progpath = argv[0]; char *basename; - int ret, i, count = 0; + char *env_debug; + int ret, i, count = 0, debug; /* Calculate the relative paths */ basename = strrchr(progpath, '/'); @@ -157,13 +158,21 @@ int main(int argc, char **argv) /* finish with NULL termination */ *cur = NULL; - if (getenv("BR_DEBUG_WRAPPER")) { - fprintf(stderr, "Executing"); - - for (i = 0; args[i]; i++) - fprintf(stderr, " %s", args[i]); - - fprintf(stderr, "\n"); + /* Debug the wrapper to see actual arguments passed to + * the compiler: + * unset, empty, or 0: do not trace + * set to 1 : trace all arguments on a single line + * set to 2 : trace one argument per line + */ + if ((env_debug = getenv("BR_DEBUG_WRAPPER"))) { + debug = atoi(env_debug); + if (debug > 0) { + fprintf(stderr, "Toolchain wrapper executing:"); + for (i = 0; args[i]; i++) + fprintf(stderr, "%s'%s'", + (debug == 2)?"\n ":" ", args[i]); + fprintf(stderr, "\n"); + } } if (execv(path, args))