diff mbox series

[1/1] toolchain/toolchain-external/toolchain-external-custom: add gcc 14 version selection

Message ID c3811011-d5b3-4eec-99a4-dc765b98afdc@grenoble.cnrs.fr
State Accepted
Headers show
Series [1/1] toolchain/toolchain-external/toolchain-external-custom: add gcc 14 version selection | expand

Commit Message

Edgar Bonet May 17, 2024, 7:18 a.m. UTC
This patch allows to use an external toolchain based on gcc 14.

Signed-off-by: Edgar Bonet <bonet@grenoble.cnrs.fr>
---
 .../toolchain-external-custom/Config.in.options               | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Vincent Stehlé May 17, 2024, 7:34 p.m. UTC | #1
On Fri, May 17, 2024 at 09:18:25AM +0200, Edgar Bonet wrote:
> This patch allows to use an external toolchain based on gcc 14.

Thanks Edgar; this works on my side.

FWIW, feel free to add (or not):

    Tested-by: Vincent Stehlé <vincent.stehle@arm.com>

> 
> Signed-off-by: Edgar Bonet <bonet@grenoble.cnrs.fr>
> ---
>  .../toolchain-external-custom/Config.in.options               | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> index f7825cb88e..1c4b0d2554 100644
> --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> @@ -46,6 +46,10 @@ choice
>  	  Set to the gcc version that is used by your external
>  	  toolchain.
>  
> +config BR2_TOOLCHAIN_EXTERNAL_GCC_14
> +	bool "14.x"
> +	select BR2_TOOLCHAIN_GCC_AT_LEAST_14
> +
>  config BR2_TOOLCHAIN_EXTERNAL_GCC_13
>  	bool "13.x"
>  	select BR2_TOOLCHAIN_GCC_AT_LEAST_13
> -- 
> 2.34.1
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Yann E. MORIN May 17, 2024, 8:02 p.m. UTC | #2
Vincent, Edgard, All,

On 2024-05-17 21:34 +0200, Vincent Stehlé spake thusly:
> On Fri, May 17, 2024 at 09:18:25AM +0200, Edgar Bonet wrote:
> > This patch allows to use an external toolchain based on gcc 14.
> 
> Thanks Edgar; this works on my side.
> 
> FWIW, feel free to add (or not):
>     Tested-by: Vincent Stehlé <vincent.stehle@arm.com>

If you do not indent your tested-by tag, then patchwork will
automatically collect it in the patch, so that it is automatically
added to the commit when we use git-am.

Applied to master, with Vincent's tested-by tag added, thanks.

Regards,
Yann E. MORIN.

> > 
> > Signed-off-by: Edgar Bonet <bonet@grenoble.cnrs.fr>
> > ---
> >  .../toolchain-external-custom/Config.in.options               | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > index f7825cb88e..1c4b0d2554 100644
> > --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > @@ -46,6 +46,10 @@ choice
> >  	  Set to the gcc version that is used by your external
> >  	  toolchain.
> >  
> > +config BR2_TOOLCHAIN_EXTERNAL_GCC_14
> > +	bool "14.x"
> > +	select BR2_TOOLCHAIN_GCC_AT_LEAST_14
> > +
> >  config BR2_TOOLCHAIN_EXTERNAL_GCC_13
> >  	bool "13.x"
> >  	select BR2_TOOLCHAIN_GCC_AT_LEAST_13
> > -- 
> > 2.34.1
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Yann E. MORIN May 17, 2024, 8:04 p.m. UTC | #3
Edgar, All,

On 2024-05-17 22:02 +0200, Yann E. MORIN spake thusly:
> Vincent, Edgard, All,

Sorry for the typo in your name... :-(

Regards,
Yann E. MORIN.

> On 2024-05-17 21:34 +0200, Vincent Stehlé spake thusly:
> > On Fri, May 17, 2024 at 09:18:25AM +0200, Edgar Bonet wrote:
> > > This patch allows to use an external toolchain based on gcc 14.
> > 
> > Thanks Edgar; this works on my side.
> > 
> > FWIW, feel free to add (or not):
> >     Tested-by: Vincent Stehlé <vincent.stehle@arm.com>
> 
> If you do not indent your tested-by tag, then patchwork will
> automatically collect it in the patch, so that it is automatically
> added to the commit when we use git-am.
> 
> Applied to master, with Vincent's tested-by tag added, thanks.
> 
> Regards,
> Yann E. MORIN.
> 
> > > 
> > > Signed-off-by: Edgar Bonet <bonet@grenoble.cnrs.fr>
> > > ---
> > >  .../toolchain-external-custom/Config.in.options               | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > > index f7825cb88e..1c4b0d2554 100644
> > > --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > > +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > > @@ -46,6 +46,10 @@ choice
> > >  	  Set to the gcc version that is used by your external
> > >  	  toolchain.
> > >  
> > > +config BR2_TOOLCHAIN_EXTERNAL_GCC_14
> > > +	bool "14.x"
> > > +	select BR2_TOOLCHAIN_GCC_AT_LEAST_14
> > > +
> > >  config BR2_TOOLCHAIN_EXTERNAL_GCC_13
> > >  	bool "13.x"
> > >  	select BR2_TOOLCHAIN_GCC_AT_LEAST_13
> > > -- 
> > > 2.34.1
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
index f7825cb88e..1c4b0d2554 100644
--- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
+++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
@@ -46,6 +46,10 @@  choice
 	  Set to the gcc version that is used by your external
 	  toolchain.
 
+config BR2_TOOLCHAIN_EXTERNAL_GCC_14
+	bool "14.x"
+	select BR2_TOOLCHAIN_GCC_AT_LEAST_14
+
 config BR2_TOOLCHAIN_EXTERNAL_GCC_13
 	bool "13.x"
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_13