From patchwork Mon Sep 8 15:46:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ANDY KENNEDY X-Patchwork-Id: 386976 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 3D190140141 for ; Tue, 9 Sep 2014 01:53:38 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5231D94023; Mon, 8 Sep 2014 15:53:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HAXe0bYsh0Hr; Mon, 8 Sep 2014 15:53:35 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 795D3939CB; Mon, 8 Sep 2014 15:53:35 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 0B2A51BF863 for ; Mon, 8 Sep 2014 15:53:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0628DA095A for ; Mon, 8 Sep 2014 15:53:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3E-Bsz697gKV for ; Mon, 8 Sep 2014 15:53:33 +0000 (UTC) X-Greylist: delayed 00:06:32 by SQLgrey-1.7.6 Received: from p01c12o141.mxlogic.net (p01c12o141.mxlogic.net [208.65.145.64]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 2E231A0901 for ; Mon, 8 Sep 2014 15:53:33 +0000 (UTC) Received: from unknown [76.164.174.83] (EHLO p01c12o141.mxlogic.net) by p01c12o141.mxlogic.net(mxl_mta-8.1.0-0) with ESMTP id df0dd045.2b2605007940.93859.00-587.261774.p01c12o141.mxlogic.net (envelope-from ); Mon, 08 Sep 2014 09:53:33 -0600 (MDT) X-MXL-Hash: 540dd0fd10a0e681-02e9fe929970c89bc5334e7d5c637ca4b009fc4d Received: from unknown [76.164.174.83] by p01c12o141.mxlogic.net(mxl_mta-8.1.0-0) with SMTP id 1efcd045.0.88845.00-312.251924.p01c12o141.mxlogic.net (envelope-from ); Mon, 08 Sep 2014 09:48:50 -0600 (MDT) X-MXL-Hash: 540dcfe21a700247-faf707a12317a0aac32c25db2815b35a08568847 Received: from ex-mb3.corp.adtran.com ([fe80::60aa:f95:ad49:a0f1]) by ex-hc2.corp.adtran.com ([fe80::a019:449b:3f62:28e5%10]) with mapi id 14.03.0195.001; Mon, 8 Sep 2014 10:46:52 -0500 From: ANDY KENNEDY To: "buildroot@uclibc.org" Thread-Topic: [PATCH] portmap not building static Thread-Index: Ac/LfBvQAAjHR/RxTUWqbEuCtsbFgw== Date: Mon, 8 Sep 2014 15:46:51 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.115.180] MIME-Version: 1.0 X-AnalysisOut: [v=2.1 cv=EuPGrEsA c=1 sm=1 tr=0 a=5zDNsY1we+1mvVcp/5+1jQ==] X-AnalysisOut: [:117 a=5zDNsY1we+1mvVcp/5+1jQ==:17 a=9VE85oa-aBUA:10 a=TAH] X-AnalysisOut: [vZHq5cw4A:10 a=qZHQZMT3apYA:10 a=C3ZOIDTcl6cA:10 a=BLceEmw] X-AnalysisOut: [cHowA:10 a=kj9zAlcOel0A:10 a=xqWC_Br6kY4A:10 a=eJNrpioGAAA] X-AnalysisOut: [A:8 a=YlVTAMxIAAAA:8 a=veQ3HosslPaArkRdvagA:9 a=CjuIK1q_8u] X-AnalysisOut: [gA:10 a=DvnSUQUdWHYA:10] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2014090808); S=0.200(2014051901)] X-MAIL-FROM: X-SOURCE-IP: [76.164.174.83] Subject: [Buildroot] [PATCH] portmap not building static X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Portmap builds and links, however, does not get built correctly when BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in rootfs.tar, however, portmap gets linked dynamically without regards to the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of portmap. Fixed. Signed-off-by: Andy Kennedy diff -Naur a/package/portmap/portmap.mk b/package/portmap/portmap.mk --- a/package/portmap/portmap.mk 2014-02-27 14:51:23.000000000 -0600 +++ b/package/portmap/portmap.mk 2014-09-08 10:38:06.264120676 -0500 @@ -15,7 +15,7 @@ endif define PORTMAP_BUILD_CMDS - CFLAGS="$(TARGET_CFLAGS)" \ + CFLAGS="$(TARGET_CFLAGS)" LDFLAGS="$(TARGET_LDFLAGS)" \ $(MAKE) CC="$(TARGET_CC)" -C $(@D) $(PORTMAP_FLAGS) endef