diff mbox

[v3] imx6q-sabresd: Add a qt5 defconfig variant

Message ID CAOMZO5Cb2RxwAfm8n8-gXe9_4j2qkEhztX1XYktF3LnZbtC2Kg@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Fabio Estevam Aug. 21, 2017, 3:40 p.m. UTC 
Hi Arnout,

On Thu, Aug 3, 2017 at 4:49 PM, Fabio Estevam <festevam@gmail.com> wrote:

>>  Could you re-test based on the next branch?
>
> Thanks for reworking the patch and applying it.
>
> I am currently out of the office without hardware access to test it.
>
> Will test it as soon as I am back to the office (week of August 21)

I was able to test it and can confirm that it works as expected.

>>  Also, you set BR2_TOOLCHAIN_BUILDROOT_GLIBC=y but none of the packages selected
>> seem to need it. Is there a reason why it is needed? Could you either remove it
>> (after testing with uClibc-ng) or add a comment why it is needed and remove
>> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y?
>
> Sure, will do it.

I tried the following change:

,but in this case the Qt5 package is not installed anymore.

Comments

Fabio Estevam Aug. 21, 2017, 4:26 p.m. UTC | #1 
On Mon, Aug 21, 2017 at 12:40 PM, Fabio Estevam <festevam@gmail.com> wrote:

> I tried the following change:
>
> --- a/configs/imx6q-sabresd_qt5_defconfig
> +++ b/configs/imx6q-sabresd_qt5_defconfig
> @@ -8,9 +8,7 @@ BR2_ARM_FPU_VFPV3=y
>  BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_11=y
>
>  # Additional features needed for packages
> -BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>  BR2_TOOLCHAIN_BUILDROOT_CXX=y
> -BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
>
>  # System
>
> ,but in this case the Qt5 package is not installed anymore.

Ok, this is expected as Qt5 depends on BR2_TOOLCHAIN_BUILDROOT_WCHAR.

So I will only remove BR2_TOOLCHAIN_BUILDROOT_GLIBC=y from the defconfig.

Let me test it and will send a patch if it works.
diff mbox

Patch

--- a/configs/imx6q-sabresd_qt5_defconfig
+++ b/configs/imx6q-sabresd_qt5_defconfig
@@ -8,9 +8,7 @@  BR2_ARM_FPU_VFPV3=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_11=y

 # Additional features needed for packages
-BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
 BR2_TOOLCHAIN_BUILDROOT_CXX=y
-BR2_TOOLCHAIN_BUILDROOT_GLIBC=y

 # System