From patchwork Wed Mar 19 11:10:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 331679 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 9C9312C00AE for ; Wed, 19 Mar 2014 22:10:52 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 65FFE88B86; Wed, 19 Mar 2014 11:10:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id duCboqpJxaTB; Wed, 19 Mar 2014 11:10:47 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 7902188786; Wed, 19 Mar 2014 11:10:47 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 91F541C2796 for ; Wed, 19 Mar 2014 11:10:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 8C7DE88C6E for ; Wed, 19 Mar 2014 11:10:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4vV3QaE86kTw for ; Wed, 19 Mar 2014 11:10:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oa0-f46.google.com (mail-oa0-f46.google.com [209.85.219.46]) by whitealder.osuosl.org (Postfix) with ESMTPS id 5EB5D88B80 for ; Wed, 19 Mar 2014 11:10:44 +0000 (UTC) Received: by mail-oa0-f46.google.com with SMTP id i7so8164139oag.33 for ; Wed, 19 Mar 2014 04:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=rFlSCAfbmXm1ZSxmMA+4GbTr+5EDKd2bmyFv9gn0YNc=; b=FNcl92YGESePoK/wK2hRwv5UXoWDJl6woiepZ3ZigGqHwn/3exw62d0UO4l2ybS3Zo 7fxCFWYfd67uj+4OVqUN5tkzpKH99rvb/xwr200A6BWBsInvqZUG4/yYpXoWisuk08BR 8hgjEiloTBy4KywGzceh9JUIpndO6Hs0A2a1EovloLZG4orh476OTpBeW6RhC0KV0FEs mFLijuPcPCQVnrPQNxhKFg7M1BMs8rwTsyUTbns9AFCThis5XYyTCZF2SpdvSJHhj9oQ SX5WBGiiX4+JAfo8+BWTzSKCM7MWDQua0A5duEG31v5NClKNGbuQ9kIeJUVwzEJh6ekV NkWQ== X-Received: by 10.182.176.10 with SMTP id ce10mr1442847obc.31.1395227443450; Wed, 19 Mar 2014 04:10:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.176.39 with HTTP; Wed, 19 Mar 2014 04:10:23 -0700 (PDT) In-Reply-To: <5326A778.7070507@mind.be> References: <1394540278-28740-1-git-send-email-fabio.porcedda@gmail.com> <1394540278-28740-7-git-send-email-fabio.porcedda@gmail.com> <5326A778.7070507@mind.be> From: Fabio Porcedda Date: Wed, 19 Mar 2014 12:10:23 +0100 Message-ID: To: Arnout Vandecappelle Cc: "buildroot@uclibc.org" Subject: Re: [Buildroot] [PATCH 6/6] Makefile: do not add the toolchain target to the TARGETS variable X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On Mon, Mar 17, 2014 at 8:42 AM, Arnout Vandecappelle wrote: > On 03/11/14 13:17, Fabio Porcedda wrote: >> Do not add the toolchain target to the TARGETS variable because now the >> toolchain target is a dependency added automatically so it is not >> necessary to add it anymore. > > I disagree with this one. When you run make, you expect buildroot to > build the toolchain even if no target package is selected. One use case I > can think of: when preparing an internal toolchain for use as an external > toolchain in later builds. Take in account that the "toolchain" target is always built because is a dependency of the "busybox" package that is always build and cannot be disabled and the "toolchain-buildroot" and "toolchain-external" are always enabled in the Config.in. I was thinking that the "toolchain" target is a package that uses tha package infrastructure, what about using the Config.in: I think this is more coherent to other always enabled packages like busybox and toolchain-*. Best regards diff --git a/toolchain/Config.in b/toolchain/Config.in index 44f3ac6..94a0c7d 100644 --- a/toolchain/Config.in +++ b/toolchain/Config.in @@ -1,5 +1,9 @@ menu "Toolchain" +config BR2_TOOLCHAIN + bool + default y + # Should be selected for glibc or eglibc config BR2_TOOLCHAIN_USES_GLIBC bool diff --git a/Makefile b/Makefile index 384693a..3df9144 100644 --- a/Makefile +++ b/Makefile @@ -299,7 +299,7 @@ GNU_HOST_NAME:=$(shell support/gnuconfig/config.guess) # ################################################################################ -TARGETS:= toolchain +TARGETS := # silent mode requested? QUIET:=$(if $(findstring s,$(MAKEFLAGS)),-q)