| Message ID | CAHkwnC-Pm8qE8beKmaJKkHsioOuGjWrgcM8oyxni2AuDChYF+Q@mail.gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi! On Thu, Feb 20, 2014 at 02:42:17PM +0100, Fabio Porcedda wrote: > On Thu, Feb 20, 2014 at 10:55 AM, Eric Le Bihan > <eric.le.bihan.dev@free.fr> wrote: > > Hi! > > > > I am currently testing the -next branch and I've encountered the following > > problem: the copy of my overlay and the execution of my post-build script is > > now performed *after* the generation of my image. > > > > Reverting commit a24877586a566e052897e50e6a0c2f53cfb029f5, which adds support > > for top-level parallel make, fixes the issue. > > > > Has anyone else experienced this problem? > > > > Can you try this patch? > > diff --git a/Makefile b/Makefile > index 20aabd6..de568e3 100644 > --- a/Makefile > +++ b/Makefile > @@ -507,6 +507,8 @@ endif > STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) > STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* > $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print > > +$(TARGETS_ROOTFS): target-finalize > + > target-finalize: $(TARGETS) > rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \ > $(TARGET_DIR)/usr/lib/pkgconfig > $(TARGET_DIR)/usr/share/pkgconfig \ > @@ -534,8 +536,6 @@ endif > find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \ > xargs -r $(KSTRIPCMD); fi > > -$(TARGETS_ROOTFS): target-finalize > - > # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads > # besides the one in which crash occurred; or SIGTRAP kills my program when > # I set a breakpoint" The patch fixes the issue. Thank you very much! Best regards, ELB
Hi Fabio, On Thu, Feb 20, 2014 at 2:42 PM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote: > On Thu, Feb 20, 2014 at 10:55 AM, Eric Le Bihan > <eric.le.bihan.dev@free.fr> wrote: >> Hi! >> >> I am currently testing the -next branch and I've encountered the following >> problem: the copy of my overlay and the execution of my post-build script is >> now performed *after* the generation of my image. >> >> Reverting commit a24877586a566e052897e50e6a0c2f53cfb029f5, which adds support >> for top-level parallel make, fixes the issue. >> >> Has anyone else experienced this problem? >> > > Can you try this patch? > > diff --git a/Makefile b/Makefile > index 20aabd6..de568e3 100644 > --- a/Makefile > +++ b/Makefile > @@ -507,6 +507,8 @@ endif > STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) > STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* > $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print > > +$(TARGETS_ROOTFS): target-finalize > + > target-finalize: $(TARGETS) > rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \ > $(TARGET_DIR)/usr/lib/pkgconfig > $(TARGET_DIR)/usr/share/pkgconfig \ > @@ -534,8 +536,6 @@ endif > find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \ > xargs -r $(KSTRIPCMD); fi > > -$(TARGETS_ROOTFS): target-finalize > - > # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads > # besides the one in which crash occurred; or SIGTRAP kills my program when > # I set a breakpoint" > Why do you think this would change anything? As far as I know, the order of the dependency expression does not matter...
Hi, On Thu, Feb 20, 2014 at 3:00 PM, Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote: > Hi Fabio, > > On Thu, Feb 20, 2014 at 2:42 PM, Fabio Porcedda > <fabio.porcedda@gmail.com> wrote: >> On Thu, Feb 20, 2014 at 10:55 AM, Eric Le Bihan >> <eric.le.bihan.dev@free.fr> wrote: >>> Hi! >>> >>> I am currently testing the -next branch and I've encountered the following >>> problem: the copy of my overlay and the execution of my post-build script is >>> now performed *after* the generation of my image. >>> >>> Reverting commit a24877586a566e052897e50e6a0c2f53cfb029f5, which adds support >>> for top-level parallel make, fixes the issue. >>> >>> Has anyone else experienced this problem? >>> >> >> Can you try this patch? >> >> diff --git a/Makefile b/Makefile >> index 20aabd6..de568e3 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -507,6 +507,8 @@ endif >> STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) >> STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* >> $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print >> >> +$(TARGETS_ROOTFS): target-finalize >> + >> target-finalize: $(TARGETS) >> rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \ >> $(TARGET_DIR)/usr/lib/pkgconfig >> $(TARGET_DIR)/usr/share/pkgconfig \ >> @@ -534,8 +536,6 @@ endif >> find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \ >> xargs -r $(KSTRIPCMD); fi >> >> -$(TARGETS_ROOTFS): target-finalize >> - >> # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads >> # besides the one in which crash occurred; or SIGTRAP kills my program when >> # I set a breakpoint" >> > > > Why do you think this would change anything? > As far as I know, the order of the dependency expression does not matter... I spoke too soon. There was indeed an actual bug in the original patch, adding a new rule in between the target-finalize rule. It was not so obvious because of the many empty lines in target-finalize, though. Fabio, will you send a patch for this? Thanks, Thomas
On Thu, Feb 20, 2014 at 3:00 PM, Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote: > Hi Fabio, > > On Thu, Feb 20, 2014 at 2:42 PM, Fabio Porcedda > <fabio.porcedda@gmail.com> wrote: >> On Thu, Feb 20, 2014 at 10:55 AM, Eric Le Bihan >> <eric.le.bihan.dev@free.fr> wrote: >>> Hi! >>> >>> I am currently testing the -next branch and I've encountered the following >>> problem: the copy of my overlay and the execution of my post-build script is >>> now performed *after* the generation of my image. >>> >>> Reverting commit a24877586a566e052897e50e6a0c2f53cfb029f5, which adds support >>> for top-level parallel make, fixes the issue. >>> >>> Has anyone else experienced this problem? >>> >> >> Can you try this patch? >> >> diff --git a/Makefile b/Makefile >> index 20aabd6..de568e3 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -507,6 +507,8 @@ endif >> STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) >> STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* >> $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print >> >> +$(TARGETS_ROOTFS): target-finalize >> + >> target-finalize: $(TARGETS) >> rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \ >> $(TARGET_DIR)/usr/lib/pkgconfig >> $(TARGET_DIR)/usr/share/pkgconfig \ >> @@ -534,8 +536,6 @@ endif >> find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \ >> xargs -r $(KSTRIPCMD); fi >> >> -$(TARGETS_ROOTFS): target-finalize >> - >> # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads >> # besides the one in which crash occurred; or SIGTRAP kills my program when >> # I set a breakpoint" >> > > > Why do you think this would change anything? > As far as I know, the order of the dependency expression does not matter... It's my fault for putting the new rule inside another target so i splitted the previous target... I was confused by the empty line inside the previous rule, it was my fault. It is a bug introduced in my latest revision of the patch set :( Regards
On Thu, Feb 20, 2014 at 3:00 PM, Eric Le Bihan <eric.le.bihan.dev@free.fr> wrote: > Hi! > > On Thu, Feb 20, 2014 at 02:42:17PM +0100, Fabio Porcedda wrote: >> On Thu, Feb 20, 2014 at 10:55 AM, Eric Le Bihan >> <eric.le.bihan.dev@free.fr> wrote: >> > Hi! >> > >> > I am currently testing the -next branch and I've encountered the following >> > problem: the copy of my overlay and the execution of my post-build script is >> > now performed *after* the generation of my image. >> > >> > Reverting commit a24877586a566e052897e50e6a0c2f53cfb029f5, which adds support >> > for top-level parallel make, fixes the issue. >> > >> > Has anyone else experienced this problem? >> > >> >> Can you try this patch? >> >> diff --git a/Makefile b/Makefile >> index 20aabd6..de568e3 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -507,6 +507,8 @@ endif >> STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) >> STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* >> $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print >> >> +$(TARGETS_ROOTFS): target-finalize >> + >> target-finalize: $(TARGETS) >> rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \ >> $(TARGET_DIR)/usr/lib/pkgconfig >> $(TARGET_DIR)/usr/share/pkgconfig \ >> @@ -534,8 +536,6 @@ endif >> find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \ >> xargs -r $(KSTRIPCMD); fi >> >> -$(TARGETS_ROOTFS): target-finalize >> - >> # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads >> # besides the one in which crash occurred; or SIGTRAP kills my program when >> # I set a breakpoint" > The patch fixes the issue. Thank you very much! That's great, i will send shortly a patch to fix this issue. Thanks for reporting and testing. Sorry for the trouble. Regards
On Thu, Feb 20, 2014 at 3:03 PM, Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote: > Hi, > > On Thu, Feb 20, 2014 at 3:00 PM, Thomas De Schampheleire > <patrickdepinguin@gmail.com> wrote: >> Hi Fabio, >> >> On Thu, Feb 20, 2014 at 2:42 PM, Fabio Porcedda >> <fabio.porcedda@gmail.com> wrote: >>> On Thu, Feb 20, 2014 at 10:55 AM, Eric Le Bihan >>> <eric.le.bihan.dev@free.fr> wrote: >>>> Hi! >>>> >>>> I am currently testing the -next branch and I've encountered the following >>>> problem: the copy of my overlay and the execution of my post-build script is >>>> now performed *after* the generation of my image. >>>> >>>> Reverting commit a24877586a566e052897e50e6a0c2f53cfb029f5, which adds support >>>> for top-level parallel make, fixes the issue. >>>> >>>> Has anyone else experienced this problem? >>>> >>> >>> Can you try this patch? >>> >>> diff --git a/Makefile b/Makefile >>> index 20aabd6..de568e3 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -507,6 +507,8 @@ endif >>> STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) >>> STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* >>> $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print >>> >>> +$(TARGETS_ROOTFS): target-finalize >>> + >>> target-finalize: $(TARGETS) >>> rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \ >>> $(TARGET_DIR)/usr/lib/pkgconfig >>> $(TARGET_DIR)/usr/share/pkgconfig \ >>> @@ -534,8 +536,6 @@ endif >>> find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \ >>> xargs -r $(KSTRIPCMD); fi >>> >>> -$(TARGETS_ROOTFS): target-finalize >>> - >>> # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads >>> # besides the one in which crash occurred; or SIGTRAP kills my program when >>> # I set a breakpoint" >>> >> >> >> Why do you think this would change anything? >> As far as I know, the order of the dependency expression does not matter... > > I spoke too soon. > There was indeed an actual bug in the original patch, adding a new > rule in between the target-finalize rule. It was not so obvious > because of the many empty lines in target-finalize, though. > > Fabio, will you send a patch for this? That's for sure! Regards
diff --git a/Makefile b/Makefile index 20aabd6..de568e3 100644 --- a/Makefile +++ b/Makefile @@ -507,6 +507,8 @@ endif STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print +$(TARGETS_ROOTFS): target-finalize + target-finalize: $(TARGETS) rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \