Message ID | CAEXMXLSfJb_POn6fxsg1Gwi7odHx0yj9LWN4XQ_mc9epsi=dsg@mail.gmail.com |
---|---|
State | Changes Requested |
Headers | show |
Series | package/gcc: don't install libstdc++.so.a.b.c-gdb.py | expand |
Hello Nuno, Le 20/04/2022 à 13:24, Nuno Gonçalves a écrit : > libstdc++.so.a.b.c-gdb.py is not required and in any case it is currently > using host paths and so not functional. > > Signed-off-by: Nuno Gonçalves <nunojpg@gmail.com> > --- > package/gcc/gcc-final/gcc-final.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/gcc/gcc-final/gcc-final.mk > b/package/gcc/gcc-final/gcc-final.mk > index aa883beb7b..5018f3a6c1 100644 > --- a/package/gcc/gcc-final/gcc-final.mk > +++ b/package/gcc/gcc-final/gcc-final.mk > @@ -199,6 +199,7 @@ endef > > ifeq ($(BR2_STATIC_LIBS),) > define HOST_GCC_FINAL_INSTALL_SHARED_LIBS > + rm -f $(HOST_GCC_FINAL_GCC_LIB_DIR)/libstdc++.so*-gdb.py ; \ > for i in $(HOST_GCC_FINAL_USR_LIBS) ; do \ > cp -dpf $(HOST_GCC_FINAL_GCC_LIB_DIR)/$${i}.so* \ > $(STAGING_DIR)/usr/lib/ ; \ Indeed the libstdc++.so*-gdb.py is copied by HOST_GCC_FINAL_INSTALL_SHARED_LIBS since it match $${i}.so*. So far, only libstdc++ seems to install such file. The file contains two hardcoded path: pythondir = '<full path>/output/host/share/gcc-12.1.0/python' libdir = '<full path>/output/host/aarch64-buildroot-linux-gnu/lib/../lib64' While reviewing your patch I noticed we have a fixup for external toolchains: https://git.buildroot.net/buildroot/commit/?id=049135c409b081d37b9455cd7564c8581334e11b It seems we need this fixup for internal toolchain too. Best regards, Romain
diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk index aa883beb7b..5018f3a6c1 100644 --- a/package/gcc/gcc-final/gcc-final.mk +++ b/package/gcc/gcc-final/gcc-final.mk @@ -199,6 +199,7 @@ endef ifeq ($(BR2_STATIC_LIBS),) define HOST_GCC_FINAL_INSTALL_SHARED_LIBS + rm -f $(HOST_GCC_FINAL_GCC_LIB_DIR)/libstdc++.so*-gdb.py ; \ for i in $(HOST_GCC_FINAL_USR_LIBS) ; do \ cp -dpf $(HOST_GCC_FINAL_GCC_LIB_DIR)/$${i}.so* \ $(STAGING_DIR)/usr/lib/ ; \
libstdc++.so.a.b.c-gdb.py is not required and in any case it is currently using host paths and so not functional. Signed-off-by: Nuno Gonçalves <nunojpg@gmail.com> --- package/gcc/gcc-final/gcc-final.mk | 1 + 1 file changed, 1 insertion(+)