diff mbox series

connman: remove iptables as a fixed dependency

Message ID CAEXMXLQVQr_837fH5jR-a0HTfnGZo6Fb+meJLDHh5A1B=_=0QA@mail.gmail.com
State Accepted
Headers show
Series connman: remove iptables as a fixed dependency | expand

Commit Message

Nuno Gonçalves Dec. 15, 2021, noon UTC 
connman might depend on iptables or nftables, and those dependencies
are already selected later in this file as required.

Signed-off-by: Nuno Goncalves <nunojpg@gmail.com>
---
 package/connman/connman.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.32.0

Comments

Arnout Vandecappelle Dec. 16, 2021, 6:24 p.m. UTC | #1 
Hi Nuno,

On 15/12/2021 13:00, Nuno Gonçalves wrote:
> connman might depend on iptables or nftables, and those dependencies
> are already selected later in this file as required.
> 
> Signed-off-by: Nuno Goncalves <nunojpg@gmail.com>

  The subject line should start with "package/connman:". I also the following to 
the commit message and applied to master, thanks.

Config.in already only selects iptables if BR2_PACKAGE_CONNMAN_IPTABLES.

  Regards,
  Arnout

> ---
>   package/connman/connman.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> index 0355426e92..e5e596c973 100644
> --- a/package/connman/connman.mk
> +++ b/package/connman/connman.mk
> @@ -7,7 +7,7 @@
>   CONNMAN_VERSION = 1.40
>   CONNMAN_SOURCE = connman-$(CONNMAN_VERSION).tar.xz
>   CONNMAN_SITE = $(BR2_KERNEL_MIRROR)/linux/network/connman
> -CONNMAN_DEPENDENCIES = libglib2 dbus iptables
> +CONNMAN_DEPENDENCIES = libglib2 dbus
>   CONNMAN_INSTALL_STAGING = YES
>   CONNMAN_LICENSE = GPL-2.0
>   CONNMAN_LICENSE_FILES = COPYING
> --
> 2.32.0
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>
Peter Korsgaard Jan. 15, 2022, 3:24 p.m. UTC | #2 
>>>>> "Nuno" == Nuno Gonçalves <nunojpg@gmail.com> writes:

 > connman might depend on iptables or nftables, and those dependencies
 > are already selected later in this file as required.

 > Signed-off-by: Nuno Goncalves <nunojpg@gmail.com>

Committed to 2021.02.x and 2021.11.x, thanks.
diff mbox series

Patch

diff --git a/package/connman/connman.mk b/package/connman/connman.mk
index 0355426e92..e5e596c973 100644
--- a/package/connman/connman.mk
+++ b/package/connman/connman.mk
@@ -7,7 +7,7 @@ 
 CONNMAN_VERSION = 1.40
 CONNMAN_SOURCE = connman-$(CONNMAN_VERSION).tar.xz
 CONNMAN_SITE = $(BR2_KERNEL_MIRROR)/linux/network/connman
-CONNMAN_DEPENDENCIES = libglib2 dbus iptables
+CONNMAN_DEPENDENCIES = libglib2 dbus
 CONNMAN_INSTALL_STAGING = YES
 CONNMAN_LICENSE = GPL-2.0
 CONNMAN_LICENSE_FILES = COPYING