diff mbox series

(no subject)

Message ID AM0PR04MB40834541F92A0945F62F8F55FB190@AM0PR04MB4083.eurprd04.prod.outlook.com
State Changes Requested
Headers show
Series (no subject) | expand

Commit Message

Augustin Thiercelin Oct. 26, 2020, 9:31 p.m. UTC
From 0f755639dc7a297ff6c656d29d541b5ad2b8f7dc Mon Sep 17 00:00:00 2001
From: Augustin Thiercelin <augustin.thiercelin@outlook.com>
Date: Mon, 26 Oct 2020 20:59:10 +0100
Subject: [PATCH 1/1] package/gst-omx: fix gstomx.conf installation for
  raspberry

The commit 7e6f4e5 introduces a new bug when building the gst-omx package
for the raspberry.

GST_OMX_VARIANT variable in gst-omx.mk was shadowed to 'generic' after being
set well for raspberry. It results having the gstomx.conf not being 
installed,
and thus having gst-omx installed but none of its features available.

Signed-off-by: Augustin Thiercelin <augustin.thiercelin@outlook.com>
---
  package/gstreamer1/gst-omx/gst-omx.mk | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Peter Seiderer Oct. 27, 2020, 8:38 a.m. UTC | #1
Hello Augustin,

> Gesendet: Montag, 26. Oktober 2020 um 22:31 Uhr
> Von: "Augustin Thiercelin" <augustin.thiercelin@outlook.com>
> An: buildroot@buildroot.org
> Betreff: [Buildroot] (no subject)
>
>  From 0f755639dc7a297ff6c656d29d541b5ad2b8f7dc Mon Sep 17 00:00:00 2001
> From: Augustin Thiercelin <augustin.thiercelin@outlook.com>
> Date: Mon, 26 Oct 2020 20:59:10 +0100
> Subject: [PATCH 1/1] package/gst-omx: fix gstomx.conf installation for
>   raspberry
>
> The commit 7e6f4e5 introduces a new bug when building the gst-omx package
> for the raspberry.
>
> GST_OMX_VARIANT variable in gst-omx.mk was shadowed to 'generic' after being
> set well for raspberry. It results having the gstomx.conf not being
> installed,
> and thus having gst-omx installed but none of its features available.
>

My fault..., thanks for spotting it and providing a patch...

> Signed-off-by: Augustin Thiercelin <augustin.thiercelin@outlook.com>
> ---
>   package/gstreamer1/gst-omx/gst-omx.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/gstreamer1/gst-omx/gst-omx.mk
> b/package/gstreamer1/gst-omx/gst-omx.mk
> index cdd0e86b04..01c3ef941b 100644
> --- a/package/gstreamer1/gst-omx/gst-omx.mk
> +++ b/package/gstreamer1/gst-omx/gst-omx.mk
> @@ -17,10 +17,11 @@ GST_OMX_CONF_OPTS = \
>   	-Dtools=disabled \
>   	-Ddoc=disabled
>
> +GST_OMX_VARIANT = generic
> +
>   ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
>   GST_OMX_VARIANT = rpi
>   GST_OMX_CONF_OPTS += -Dheader_path=$(STAGING_DIR)/usr/include/IL
> -GST_OMX_VARIANT = generic
>   endif

Would prefere:

--- a/package/gstreamer1/gst-omx/gst-omx.mk
+++ b/package/gstreamer1/gst-omx/gst-omx.mk
@@ -20,6 +20,7 @@ GST_OMX_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 GST_OMX_VARIANT = rpi
 GST_OMX_CONF_OPTS += -Dheader_path=$(STAGING_DIR)/usr/include/IL
+else
 GST_OMX_VARIANT = generic
 endif


Mind to re-spin the patch with this change (by the way your patch seems
to be mangled e.g. e-mail missing subject line, try to use git send-email)?

Regards,
Peter


>
>   GST_OMX_CONF_OPTS += -Dtarget=$(GST_OMX_VARIANT)
> --
> 2.29.0
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
diff mbox series

Patch

diff --git a/package/gstreamer1/gst-omx/gst-omx.mk 
b/package/gstreamer1/gst-omx/gst-omx.mk
index cdd0e86b04..01c3ef941b 100644
--- a/package/gstreamer1/gst-omx/gst-omx.mk
+++ b/package/gstreamer1/gst-omx/gst-omx.mk
@@ -17,10 +17,11 @@  GST_OMX_CONF_OPTS = \
  	-Dtools=disabled \
  	-Ddoc=disabled

+GST_OMX_VARIANT = generic
+
  ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
  GST_OMX_VARIANT = rpi
  GST_OMX_CONF_OPTS += -Dheader_path=$(STAGING_DIR)/usr/include/IL
-GST_OMX_VARIANT = generic
  endif

  GST_OMX_CONF_OPTS += -Dtarget=$(GST_OMX_VARIANT)