Message ID | 9d8e6092e50ef50a78cd450f4a9daec38f374949.1429725549.git.yann.morin.1998@free.fr |
---|---|
State | Changes Requested |
Headers | show |
On 04/22/15 20:09, Yann E. MORIN wrote: > Currently, matchbox-panel is treated as if it were an option of the > matchbox package. > > But that's not true, since it is a real package all by itself, with its > own archive and its own buildsystem. > > So, make it a real package. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (on condition that it goes to matchbox/matchbox-panel) Regards, Arnout > --- > package/matchbox/Config.in | 7 +------ > package/matchbox/matchbox-panel/Config.in | 6 ++++++ > 2 files changed, 7 insertions(+), 6 deletions(-) > create mode 100644 package/matchbox/matchbox-panel/Config.in > > diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in > index 15b1017..e791cea 100644 > --- a/package/matchbox/Config.in > +++ b/package/matchbox/Config.in > @@ -21,12 +21,7 @@ if BR2_PACKAGE_MATCHBOX > > source "package/matchbox/matchbox-lib/Config.in" > source "package/matchbox/matchbox-wm/Config.in" > - > -config BR2_PACKAGE_MATCHBOX_PANEL > - bool "Matchbox Panel" > - help > - A flexible always present 'window bar' for holding > - application launchers. > +source "package/matchbox/matchbox-panel/Config.in" > > config BR2_PACKAGE_MATCHBOX_DESKTOP > bool "Matchbox Desktop" > diff --git a/package/matchbox/matchbox-panel/Config.in b/package/matchbox/matchbox-panel/Config.in > new file mode 100644 > index 0000000..e3daaf5 > --- /dev/null > +++ b/package/matchbox/matchbox-panel/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_MATCHBOX_PANEL > + bool "Matchbox Panel" > + select BR2_PACKAGE_MATCHBOX_LIB > + help > + A flexible always present 'window bar' for holding > + application launchers. >
On 04/22/15 20:09, Yann E. MORIN wrote: > Currently, matchbox-panel is treated as if it were an option of the > matchbox package. > > But that's not true, since it is a real package all by itself, with its > own archive and its own buildsystem. > > So, make it a real package. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > package/matchbox/Config.in | 7 +------ > package/matchbox/matchbox-panel/Config.in | 6 ++++++ > 2 files changed, 7 insertions(+), 6 deletions(-) > create mode 100644 package/matchbox/matchbox-panel/Config.in > > diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in > index 15b1017..e791cea 100644 > --- a/package/matchbox/Config.in > +++ b/package/matchbox/Config.in > @@ -21,12 +21,7 @@ if BR2_PACKAGE_MATCHBOX > > source "package/matchbox/matchbox-lib/Config.in" > source "package/matchbox/matchbox-wm/Config.in" > - > -config BR2_PACKAGE_MATCHBOX_PANEL > - bool "Matchbox Panel" > - help > - A flexible always present 'window bar' for holding > - application launchers. > +source "package/matchbox/matchbox-panel/Config.in" > > config BR2_PACKAGE_MATCHBOX_DESKTOP > bool "Matchbox Desktop" > diff --git a/package/matchbox/matchbox-panel/Config.in b/package/matchbox/matchbox-panel/Config.in > new file mode 100644 > index 0000000..e3daaf5 > --- /dev/null > +++ b/package/matchbox/matchbox-panel/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_MATCHBOX_PANEL > + bool "Matchbox Panel" Actually, to match our style, that should be "matchbox-panel". You can choose if that is in this patch or in a mass cleanup patch later in the series. Regards, Arnout > + select BR2_PACKAGE_MATCHBOX_LIB > + help > + A flexible always present 'window bar' for holding > + application launchers. >
On 04/23/15 23:46, Arnout Vandecappelle wrote: > On 04/22/15 20:09, Yann E. MORIN wrote: >> Currently, matchbox-panel is treated as if it were an option of the >> matchbox package. >> >> But that's not true, since it is a real package all by itself, with its >> own archive and its own buildsystem. >> >> So, make it a real package. >> >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> >> --- >> package/matchbox/Config.in | 7 +------ >> package/matchbox/matchbox-panel/Config.in | 6 ++++++ >> 2 files changed, 7 insertions(+), 6 deletions(-) >> create mode 100644 package/matchbox/matchbox-panel/Config.in >> >> diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in >> index 15b1017..e791cea 100644 >> --- a/package/matchbox/Config.in >> +++ b/package/matchbox/Config.in >> @@ -21,12 +21,7 @@ if BR2_PACKAGE_MATCHBOX >> >> source "package/matchbox/matchbox-lib/Config.in" >> source "package/matchbox/matchbox-wm/Config.in" >> - >> -config BR2_PACKAGE_MATCHBOX_PANEL >> - bool "Matchbox Panel" >> - help >> - A flexible always present 'window bar' for holding >> - application launchers. >> +source "package/matchbox/matchbox-panel/Config.in" >> >> config BR2_PACKAGE_MATCHBOX_DESKTOP >> bool "Matchbox Desktop" >> diff --git a/package/matchbox/matchbox-panel/Config.in b/package/matchbox/matchbox-panel/Config.in >> new file mode 100644 >> index 0000000..e3daaf5 >> --- /dev/null >> +++ b/package/matchbox/matchbox-panel/Config.in >> @@ -0,0 +1,6 @@ >> +config BR2_PACKAGE_MATCHBOX_PANEL >> + bool "Matchbox Panel" > > Actually, to match our style, that should be "matchbox-panel". You can choose > if that is in this patch or in a mass cleanup patch later in the series. Argh, it already is part of a later patch. Sorry for the noise... Regards, Arnout > > Regards, > Arnout > >> + select BR2_PACKAGE_MATCHBOX_LIB >> + help >> + A flexible always present 'window bar' for holding >> + application launchers. >> > >
diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in index 15b1017..e791cea 100644 --- a/package/matchbox/Config.in +++ b/package/matchbox/Config.in @@ -21,12 +21,7 @@ if BR2_PACKAGE_MATCHBOX source "package/matchbox/matchbox-lib/Config.in" source "package/matchbox/matchbox-wm/Config.in" - -config BR2_PACKAGE_MATCHBOX_PANEL - bool "Matchbox Panel" - help - A flexible always present 'window bar' for holding - application launchers. +source "package/matchbox/matchbox-panel/Config.in" config BR2_PACKAGE_MATCHBOX_DESKTOP bool "Matchbox Desktop" diff --git a/package/matchbox/matchbox-panel/Config.in b/package/matchbox/matchbox-panel/Config.in new file mode 100644 index 0000000..e3daaf5 --- /dev/null +++ b/package/matchbox/matchbox-panel/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_MATCHBOX_PANEL + bool "Matchbox Panel" + select BR2_PACKAGE_MATCHBOX_LIB + help + A flexible always present 'window bar' for holding + application launchers.
Currently, matchbox-panel is treated as if it were an option of the matchbox package. But that's not true, since it is a real package all by itself, with its own archive and its own buildsystem. So, make it a real package. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- package/matchbox/Config.in | 7 +------ package/matchbox/matchbox-panel/Config.in | 6 ++++++ 2 files changed, 7 insertions(+), 6 deletions(-) create mode 100644 package/matchbox/matchbox-panel/Config.in