diff mbox series

owfs: skip man pages preprocessing

Message ID 92fe5d87d2ceb63a001113f6a753f2d309c9b21f.1536900899.git.baruch@tkos.co.il
State Accepted
Headers show
Series owfs: skip man pages preprocessing | expand

Commit Message

Baruch Siach Sept. 14, 2018, 4:54 a.m. UTC
owfs optionally uses soelim with the -r option to process its man pages.
Older versions of groff don't support this option, and we don't care
about documentation on target. So just skip the soelim run.

Fixes:
http://autobuild.buildroot.net/results/bf8/bf893f1ecabb9ecadceb5d56eaa5e4869832e330/
http://autobuild.buildroot.net/results/d36/d369e2c8b90558e84ffd5a44cfe1308111c88637/
http://autobuild.buildroot.net/results/4f3/4f3dfb3cfee1678e6d5da03d09e236d0f4b55b9f/

Cc: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/owfs/owfs.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Petazzoni Sept. 14, 2018, 8:17 p.m. UTC | #1
Hello,

On Fri, 14 Sep 2018 07:54:59 +0300, Baruch Siach wrote:
> owfs optionally uses soelim with the -r option to process its man pages.
> Older versions of groff don't support this option, and we don't care
> about documentation on target. So just skip the soelim run.
> 
> Fixes:
> http://autobuild.buildroot.net/results/bf8/bf893f1ecabb9ecadceb5d56eaa5e4869832e330/
> http://autobuild.buildroot.net/results/d36/d369e2c8b90558e84ffd5a44cfe1308111c88637/
> http://autobuild.buildroot.net/results/4f3/4f3dfb3cfee1678e6d5da03d09e236d0f4b55b9f/
> 
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/owfs/owfs.mk | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master, thanks. However, it would be nice to have an
upstream patch that allows to disable manpage generation, or
alternatively that checks of soelim is available and suitable, and only
enable manage generation if that's the case.

Best regards,

Thomas
diff mbox series

Patch

diff --git a/package/owfs/owfs.mk b/package/owfs/owfs.mk
index 47626ceafc0b..fa6810d01d32 100644
--- a/package/owfs/owfs.mk
+++ b/package/owfs/owfs.mk
@@ -21,6 +21,9 @@  OWFS_INSTALL_STAGING = YES
 # https://sourceforge.net/p/owfs/support-requests/32/
 OWFS_CONF_OPTS += --disable-owphp --without-php
 
+# Skip man pages processing
+OWFS_CONF_ENV += ac_cv_path_SOELIM=true
+
 ifeq ($(BR2_PACKAGE_LIBFUSE),y)
 OWFS_DEPENDENCIES += libfuse
 OWFS_CONF_OPTS += \