From patchwork Wed Sep 4 09:15:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 272523 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 670902C0085 for ; Wed, 4 Sep 2013 19:23:33 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9730E8B676; Wed, 4 Sep 2013 09:23:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c16uAPklrs-4; Wed, 4 Sep 2013 09:23:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id C978A8B209; Wed, 4 Sep 2013 09:23:30 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id CC7221BF9F1 for ; Wed, 4 Sep 2013 09:23:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 82DD231DCA; Wed, 4 Sep 2013 09:23:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LwVYM+1uJPZh; Wed, 4 Sep 2013 09:23:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by silver.osuosl.org (Postfix) with ESMTPS id 25BB93148A; Wed, 4 Sep 2013 09:23:18 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id hm2so1931255wib.4 for ; Wed, 04 Sep 2013 02:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=N3tbMXiDKjFRSaZ5EqtTvpK83kTHmKFm+yyUMsI1k38=; b=Yt7p9xZAp99z/c2v5N+DsrfKCkt1T84ihSonmIK60x3oyzsepJsKHGqf7RLIz/uIRw jSF/+p7vQh6BmsD0FlKGmSDzgIf5mRDbTSZ5uWChSxHBXjE5ylwHjBv221W8Evt9j4Dz ilsW2fvQtwU8DC7SM3QExDayoZRSkic6v+hXn/325XZy8N7wIABpkJjkRgHyNsLg7zK7 vzY/D3jyee3FxiowsylMjNPGQfhebxAKkuO3rbODNzCD/091XsDdg/K/Z0uipS9lFuUO pEK4DsBUBzX3m/tH/xtTsB1oylXVozE+hItPvvck3MH1Qte28xR37L7zTUftiqErxnWG inIg== X-Received: by 10.180.182.228 with SMTP id eh4mr1186491wic.45.1378286129699; Wed, 04 Sep 2013 02:15:29 -0700 (PDT) Received: from dell.be.48ers.dk ([91.183.168.190]) by mx.google.com with ESMTPSA id mw9sm2454945wic.4.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 04 Sep 2013 02:15:28 -0700 (PDT) Received: from peko by dell.be.48ers.dk with local (Exim 4.80) (envelope-from ) id 1VH9BP-0007DY-4d; Wed, 04 Sep 2013 11:15:27 +0200 From: Peter Korsgaard To: Ruud Commandeur References: <15AE5A936F5E3A42A9144E66875A0A8934DB3B@server1-derijp.CLB-Benelux.lokaal> <87sixm558s.fsf@dell.be.48ers.dk> <52260E11.4090103@mind.be> <15AE5A936F5E3A42A9144E66875A0A8934DB3E@server1-derijp.CLB-Benelux.lokaal> <20130904100754.297bb0d6@skate> <15AE5A936F5E3A42A9144E66875A0A8934DB3F@server1-derijp.CLB-Benelux.lokaal> Date: Wed, 04 Sep 2013 11:15:27 +0200 In-Reply-To: <15AE5A936F5E3A42A9144E66875A0A8934DB3F@server1-derijp.CLB-Benelux.lokaal> (Ruud Commandeur's message of "Wed, 4 Sep 2013 10:57:33 +0200") Message-ID: <87zjrt3q34.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Cc: Thomas Petazzoni , buildroot@uclibc.org Subject: Re: [Buildroot] SVN process started at make X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net >>>>> "Ruud" == Ruud Commandeur writes: Ruud> Dear Thomas, Ruud> Well, I did take a quick look at this file, but could have seen this Ruud> myself indeed :-) Ruud> So it runs an "svn info" and "svn status". This last command can take Ruud> quite some time for a large repository, so this explains the delay. Ok, I'm afraid there's not much to do about svn being crap :/ How come you are only seeing this now? We've been calling setlocalversion since 2010. Did you recently upgrade your svn version? Looking at the kernel history (where setlocalversion comes from), I see a commit from Mike Frysinger where the svn status step is skipped as it was deemed too slow, so perhaps we should just resync our setlocalversion script with the kernel: Author: Mike Frysinger Date: Thu Feb 5 16:13:32 2009 +0800 kbuild,setlocalversion: shorten the make time when using svn Don't bother doing `svn st` as it takes a retarded amount of time when the source is cold Signed-off-by: Mike Frysinger Signed-off-by: Bryan Wu Signed-off-by: Sam Ravnborg I'll do that now. diff --git a/scripts/setlocalversion b/scripts/setlocalversion index f6946cf..f1c4b35 100755 --- a/scripts/setlocalversion +++ b/scripts/setlocalversion @@ -58,14 +58,7 @@ fi # Check for svn and a svn repo. if rev=`svn info 2>/dev/null | grep '^Last Changed Rev'`; then rev=`echo $rev | awk '{print $NF}'` - changes=`svn status 2>/dev/null | grep '^[AMD]' | wc -l` - - # Are there uncommitted changes? - if [ $changes != 0 ]; then - printf -- '-svn%s%s' "$rev" -dirty - else - printf -- '-svn%s' "$rev" - fi + printf -- '-svn%s' "$rev" # All done with svn exit