| Message ID | 661e87dcda8a33ae3aa6416cf37427165982f119.1636810092.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | core: add show-vars, a json-formatted equivalent to printvars (branch yem/show-vars) | expand |
On Sat, 13 Nov 2021 14:28:16 +0100 "Yann E. MORIN" <yann.morin.1998@free.fr> wrote: > Similarly to what we just did for conditionally-set-empty variables, > unconditionally setting empty variables serves no purpose in Makefiles, > as unset variables are just expanded as empty... > > Even though we have numerous python packages, the speed gain was not > measurable, with delta much less than the noise. > > Still, for consistency, we just do not set those variables. > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > --- > package/pkg-python.mk | 3 --- > 1 file changed, 3 deletions(-) Applied to master, thanks. Thomas
diff --git a/package/pkg-python.mk b/package/pkg-python.mk index ce0fc97283..4cc416cea0 100644 --- a/package/pkg-python.mk +++ b/package/pkg-python.mk @@ -127,7 +127,6 @@ $(2)_BASE_INSTALL_STAGING_OPTS = $$(PKG_PYTHON_DISTUTILS_INSTALL_STAGING_OPTS) else $(2)_BASE_ENV = $$(HOST_PKG_PYTHON_DISTUTILS_ENV) $(2)_BASE_BUILD_TGT = build -$(2)_BASE_BUILD_OPTS = $(2)_BASE_INSTALL_OPTS = $$(HOST_PKG_PYTHON_DISTUTILS_INSTALL_OPTS) endif # Setuptools @@ -135,13 +134,11 @@ else ifeq ($$($(2)_SETUP_TYPE),setuptools) ifeq ($(4),target) $(2)_BASE_ENV = $$(PKG_PYTHON_SETUPTOOLS_ENV) $(2)_BASE_BUILD_TGT = build -$(2)_BASE_BUILD_OPTS = $(2)_BASE_INSTALL_TARGET_OPTS = $$(PKG_PYTHON_SETUPTOOLS_INSTALL_TARGET_OPTS) $(2)_BASE_INSTALL_STAGING_OPTS = $$(PKG_PYTHON_SETUPTOOLS_INSTALL_STAGING_OPTS) else $(2)_BASE_ENV = $$(HOST_PKG_PYTHON_SETUPTOOLS_ENV) $(2)_BASE_BUILD_TGT = build -$(2)_BASE_BUILD_OPTS = $(2)_BASE_INSTALL_OPTS = $$(HOST_PKG_PYTHON_SETUPTOOLS_INSTALL_OPTS) endif else
Similarly to what we just did for conditionally-set-empty variables, unconditionally setting empty variables serves no purpose in Makefiles, as unset variables are just expanded as empty... Even though we have numerous python packages, the speed gain was not measurable, with delta much less than the noise. Still, for consistency, we just do not set those variables. Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- package/pkg-python.mk | 3 --- 1 file changed, 3 deletions(-)