Message ID | 627b2a8dc8d8772672b79e7bd2f3d36eb401dca1.1429725549.git.yann.morin.1998@free.fr |
---|---|
State | Changes Requested |
Headers | show |
On 04/22/15 20:09, Yann E. MORIN wrote: > Use the package names instead of some fancy human-readable strings. ;-) > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > package/matchbox/Config.in | 2 +- > package/matchbox/matchbox-common/Config.in | 4 ++-- > package/matchbox/matchbox-desktop/Config.in | 2 +- > package/matchbox/matchbox-keyboard/Config.in | 2 +- > package/matchbox/matchbox-panel/Config.in | 2 +- > 5 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in > index 7d06bb2..e58aaf2 100644 > --- a/package/matchbox/Config.in > +++ b/package/matchbox/Config.in > @@ -1,5 +1,5 @@ > config BR2_PACKAGE_MATCHBOX > - bool "MatchBox Window Manager" > + bool "matchbox" Not so sure about this one... The upstream name is matchbox-window-manager, and it is useful information that it's a window manager. OTOH that's already in the comment right above it. So in the end I'm OK either way. Regards, Arnout > depends on BR2_PACKAGE_XORG7 > depends on BR2_USE_MMU # fork() > select BR2_PACKAGE_FONTCONFIG > diff --git a/package/matchbox/matchbox-common/Config.in b/package/matchbox/matchbox-common/Config.in > index 7d22d05..f1c4ce3 100644 > --- a/package/matchbox/matchbox-common/Config.in > +++ b/package/matchbox/matchbox-common/Config.in > @@ -1,9 +1,9 @@ > config BR2_PACKAGE_MATCHBOX_COMMON > - bool "Matchbox session common files" > + bool "matchbox-common" > depends on BR2_PACKAGE_MATCHBOX_PANEL && BR2_PACKAGE_MATCHBOX_DESKTOP > help > Common desktop folders and matchbox-session script. > > config BR2_PACKAGE_MATCHBOX_COMMON_PDA > - bool "PDA style desktop folders" > + bool "PDA style app folder" > depends on BR2_PACKAGE_MATCHBOX_COMMON > diff --git a/package/matchbox/matchbox-desktop/Config.in b/package/matchbox/matchbox-desktop/Config.in > index c9fd196..ed80c22 100644 > --- a/package/matchbox/matchbox-desktop/Config.in > +++ b/package/matchbox/matchbox-desktop/Config.in > @@ -1,5 +1,5 @@ > config BR2_PACKAGE_MATCHBOX_DESKTOP > - bool "Matchbox Desktop" > + bool "matchbox-desktop" > select BR2_PACKAGE_ZLIB > help > A PDA style application launcher or 'item browser'. > diff --git a/package/matchbox/matchbox-keyboard/Config.in b/package/matchbox/matchbox-keyboard/Config.in > index e017358..056a255 100644 > --- a/package/matchbox/matchbox-keyboard/Config.in > +++ b/package/matchbox/matchbox-keyboard/Config.in > @@ -1,5 +1,5 @@ > config BR2_PACKAGE_MATCHBOX_KEYBOARD > - bool "Matchbox Virtual Keyboard" > + bool "matchbox-keyboard" > select BR2_PACKAGE_XLIB_LIBXTST > select BR2_PACKAGE_XLIB_LIBXFT if !BR2_PACKAGE_CAIRO > select BR2_PACKAGE_MATCHBOX_FAKEKEY > diff --git a/package/matchbox/matchbox-panel/Config.in b/package/matchbox/matchbox-panel/Config.in > index e3daaf5..47bd10a 100644 > --- a/package/matchbox/matchbox-panel/Config.in > +++ b/package/matchbox/matchbox-panel/Config.in > @@ -1,5 +1,5 @@ > config BR2_PACKAGE_MATCHBOX_PANEL > - bool "Matchbox Panel" > + bool "matchbox-panel" > select BR2_PACKAGE_MATCHBOX_LIB > help > A flexible always present 'window bar' for holding >
Arnout, All, On 2015-04-24 00:26 +0200, Arnout Vandecappelle spake thusly: > On 04/22/15 20:09, Yann E. MORIN wrote: > > Use the package names instead of some fancy human-readable strings. ;-) > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > --- > > package/matchbox/Config.in | 2 +- > > package/matchbox/matchbox-common/Config.in | 4 ++-- > > package/matchbox/matchbox-desktop/Config.in | 2 +- > > package/matchbox/matchbox-keyboard/Config.in | 2 +- > > package/matchbox/matchbox-panel/Config.in | 2 +- > > 5 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in > > index 7d06bb2..e58aaf2 100644 > > --- a/package/matchbox/Config.in > > +++ b/package/matchbox/Config.in > > @@ -1,5 +1,5 @@ > > config BR2_PACKAGE_MATCHBOX > > - bool "MatchBox Window Manager" > > + bool "matchbox" > > Not so sure about this one... The upstream name is matchbox-window-manager, and > it is useful information that it's a window manager. OTOH that's already in the > comment right above it. Well, even though I agree on principle: - "matchbox-window-manager" is a bit long - as you said, it's in the "Window Manager" section - the global stuff is named "matchbox", and I suppose users would expect to see just "matchbox" > So in the end I'm OK either way. I can see if naming that package accordingly to the upstream name, and if it proves to cumbersome, I'll just let it as it is now... Regards, Yann E. MORIN.
diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in index 7d06bb2..e58aaf2 100644 --- a/package/matchbox/Config.in +++ b/package/matchbox/Config.in @@ -1,5 +1,5 @@ config BR2_PACKAGE_MATCHBOX - bool "MatchBox Window Manager" + bool "matchbox" depends on BR2_PACKAGE_XORG7 depends on BR2_USE_MMU # fork() select BR2_PACKAGE_FONTCONFIG diff --git a/package/matchbox/matchbox-common/Config.in b/package/matchbox/matchbox-common/Config.in index 7d22d05..f1c4ce3 100644 --- a/package/matchbox/matchbox-common/Config.in +++ b/package/matchbox/matchbox-common/Config.in @@ -1,9 +1,9 @@ config BR2_PACKAGE_MATCHBOX_COMMON - bool "Matchbox session common files" + bool "matchbox-common" depends on BR2_PACKAGE_MATCHBOX_PANEL && BR2_PACKAGE_MATCHBOX_DESKTOP help Common desktop folders and matchbox-session script. config BR2_PACKAGE_MATCHBOX_COMMON_PDA - bool "PDA style desktop folders" + bool "PDA style app folder" depends on BR2_PACKAGE_MATCHBOX_COMMON diff --git a/package/matchbox/matchbox-desktop/Config.in b/package/matchbox/matchbox-desktop/Config.in index c9fd196..ed80c22 100644 --- a/package/matchbox/matchbox-desktop/Config.in +++ b/package/matchbox/matchbox-desktop/Config.in @@ -1,5 +1,5 @@ config BR2_PACKAGE_MATCHBOX_DESKTOP - bool "Matchbox Desktop" + bool "matchbox-desktop" select BR2_PACKAGE_ZLIB help A PDA style application launcher or 'item browser'. diff --git a/package/matchbox/matchbox-keyboard/Config.in b/package/matchbox/matchbox-keyboard/Config.in index e017358..056a255 100644 --- a/package/matchbox/matchbox-keyboard/Config.in +++ b/package/matchbox/matchbox-keyboard/Config.in @@ -1,5 +1,5 @@ config BR2_PACKAGE_MATCHBOX_KEYBOARD - bool "Matchbox Virtual Keyboard" + bool "matchbox-keyboard" select BR2_PACKAGE_XLIB_LIBXTST select BR2_PACKAGE_XLIB_LIBXFT if !BR2_PACKAGE_CAIRO select BR2_PACKAGE_MATCHBOX_FAKEKEY diff --git a/package/matchbox/matchbox-panel/Config.in b/package/matchbox/matchbox-panel/Config.in index e3daaf5..47bd10a 100644 --- a/package/matchbox/matchbox-panel/Config.in +++ b/package/matchbox/matchbox-panel/Config.in @@ -1,5 +1,5 @@ config BR2_PACKAGE_MATCHBOX_PANEL - bool "Matchbox Panel" + bool "matchbox-panel" select BR2_PACKAGE_MATCHBOX_LIB help A flexible always present 'window bar' for holding
Use the package names instead of some fancy human-readable strings. ;-) Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- package/matchbox/Config.in | 2 +- package/matchbox/matchbox-common/Config.in | 4 ++-- package/matchbox/matchbox-desktop/Config.in | 2 +- package/matchbox/matchbox-keyboard/Config.in | 2 +- package/matchbox/matchbox-panel/Config.in | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)