From patchwork Mon Dec 28 19:08:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 561388 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 2ACC3140C97 for ; Tue, 29 Dec 2015 06:09:07 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=zJ0Nwd4P; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 59A37935D8; Mon, 28 Dec 2015 19:09:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g+pRftg8unw6; Mon, 28 Dec 2015 19:09:05 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id A678B9362D; Mon, 28 Dec 2015 19:09:05 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 643B31C11F4 for ; Mon, 28 Dec 2015 19:09:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5BF1693461 for ; Mon, 28 Dec 2015 19:09:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nq6Z2FX2HDRZ for ; Mon, 28 Dec 2015 19:09:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by hemlock.osuosl.org (Postfix) with ESMTPS id 6DB53932AC for ; Mon, 28 Dec 2015 19:09:00 +0000 (UTC) Received: by mail-wm0-f42.google.com with SMTP id f206so16956972wmf.0 for ; Mon, 28 Dec 2015 11:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=AWwE8A2afbYdDQ8l0XieLO40FkhGuTXVGvz/pKij8so=; b=zJ0Nwd4PWdpzyPUXabDxtjgFUrrK9cycx4+1vq4qwbrua2okbRfD0nF0MrsLE+OlWs K6Wrii8QY3v8WxAcGYBGyvZlzmuABlhht0WEw9FqiICr0rqFcNJyzc44kfOX4e1phb/7 2HxqP3S5cbR3Uabn4+WIMNMBuOKJIQPZ9QKs/G+DwCeubxhslJLGvI3FWOIJ4m7sX87X HLIZ75sq2beHUKfFwWHDWtoeQ+ISSg540hIQ25QS5wA5r+bSonswHnFx1xhexrFEFBYN 1VHuzBBlkOKPododIkSEE9rLGnThmt9eqGJv5L/CMhixB34u80sUPdpR+a+O240MI3vG /1dg== X-Received: by 10.28.48.131 with SMTP id w125mr45523846wmw.18.1451329739155; Mon, 28 Dec 2015 11:08:59 -0800 (PST) Received: from gourin.bzh.lan (ns304657.ip-46-105-103.eu. [46.105.103.66]) by smtp.gmail.com with ESMTPSA id u12sm24064116wmu.10.2015.12.28.11.08.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 28 Dec 2015 11:08:58 -0800 (PST) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Mon, 28 Dec 2015 20:08:55 +0100 Message-Id: <5f7632a3d6ed3e3ab0f324e31be21a0ea18245d4.1451329553.git.yann.morin.1998@free.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: Cc: "Yann E. MORIN" Subject: [Buildroot] [PATCH 2/2] package/jack2: add missing optional dependencies X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" jack2 can optionally use opus, readline and eigen3, but those dependencies were not expressed in out jack2 package, potentially leading to unreproducible builds. Add them. Note that the optinal dependency on celt is not added, because we only have celt-0.5.1 and jack2 requires celt >= 0.5.2 (even though it does look for celt >= 0.5.0, it does not build with celt- < 0.5.2). Sinc ewe can not upgrade celt (for now), we just never make jack2 depend on celt051, and it won;t find it either, as it just searches for celt.pc and we have celt051.pc. Signed-off-by: "Yann E. MORIN" --- package/jack2/jack2.mk | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk index e4ad36e..5566b78 100644 --- a/package/jack2/jack2.mk +++ b/package/jack2/jack2.mk @@ -24,6 +24,23 @@ JACK2_DEPENDENCIES += dbus JACK2_CONF_OPTS += --dbus endif +ifeq ($(BR2_PACKAGE_OPUS),y) +JACK2_DEPENDENCIES += opus +endif + +ifeq ($(BR2_PACKAGE_READLINE),y) +JACK2_DEPENDENCIES += readline +endif + +ifeq ($(BR2_PACKAGE_EIGEN),y) +JACK2_DEPENDENCIES += eigen +endif + +# Even though it advertises support for celt-0.5.x, jack2 really requires +# celt >= 0.5.2 but we only have 0.5.1.3 and we can not upgrade, so we do +# not add a dependency to celt051, which it can't find anyway as it looks +# for celt.pc but we only have celt-51.pc. + define JACK2_CONFIGURE_CMDS (cd $(@D); \ $(TARGET_CONFIGURE_OPTS) \