| Message ID | 5293a67121d1cc996d6cd48bc15e2fc29d45e1a7.1629958236.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] package/mtd: change ubifs-utils depend to select | expand |
On 26/08/2021 08:10, Baruch Siach wrote: > ubihealthd requires getrandom(2) that was introduced in kernel version > 3.17. ubihealthd does not build when getrandom(2) is not detected, so > the following installation step fails. > > Technically the dependency should also be on glibc version 2.25+. But we > have no way to depend on glibc versions of external toolchains. > Toolchain built with kernel headers older than 3.17 can build > ubihealthd, but it will fail at run-time. So this is a pretty close > approximation of the actual dependency. > > Fixes: > http://autobuild.buildroot.net/results/2d42b0a626367e4051d0e2aadcce39e974fe09d4/ > http://autobuild.buildroot.net/results/a2b6dbf707275e3f8262479c0650cfc7cb9abc8d/ > > Cc: Matt Weber <matthew.weber@collins.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Applied to master, thanks (after fixup because I didn't apply 1/2). Regards, Arnout > --- > package/mtd/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/mtd/Config.in b/package/mtd/Config.in > index 1bd143d47e7d..4bd9118aecc1 100644 > --- a/package/mtd/Config.in > +++ b/package/mtd/Config.in > @@ -147,6 +147,7 @@ config BR2_PACKAGE_MTD_UBIHEALTHD > bool "ubihealthd" > default y > select BR2_PACKAGE_MTD_UBIFS_UTILS > + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # getrandom() > > config BR2_PACKAGE_MTD_UBIMKVOL > bool "ubimkvol" >
diff --git a/package/mtd/Config.in b/package/mtd/Config.in index 1bd143d47e7d..4bd9118aecc1 100644 --- a/package/mtd/Config.in +++ b/package/mtd/Config.in @@ -147,6 +147,7 @@ config BR2_PACKAGE_MTD_UBIHEALTHD bool "ubihealthd" default y select BR2_PACKAGE_MTD_UBIFS_UTILS + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # getrandom() config BR2_PACKAGE_MTD_UBIMKVOL bool "ubimkvol"
ubihealthd requires getrandom(2) that was introduced in kernel version 3.17. ubihealthd does not build when getrandom(2) is not detected, so the following installation step fails. Technically the dependency should also be on glibc version 2.25+. But we have no way to depend on glibc versions of external toolchains. Toolchain built with kernel headers older than 3.17 can build ubihealthd, but it will fail at run-time. So this is a pretty close approximation of the actual dependency. Fixes: http://autobuild.buildroot.net/results/2d42b0a626367e4051d0e2aadcce39e974fe09d4/ http://autobuild.buildroot.net/results/a2b6dbf707275e3f8262479c0650cfc7cb9abc8d/ Cc: Matt Weber <matthew.weber@collins.com> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- package/mtd/Config.in | 1 + 1 file changed, 1 insertion(+)