Message ID | 50D1B74F.805@syscom.ch |
---|---|
State | Superseded |
Headers | show |
Dear Arnaud Rébillout, On Wed, 19 Dec 2012 13:47:11 +0100, Arnaud Rébillout wrote: > I need to use mkenvimage. And it seems that the easiest way is to > automatically install it in the HOST_UBOOT_TOOLS_INSTALL_CMDS target. > The tool mkenvimage appeared v2011.12 of uboot, so it's present in all > the versions that buildroot supports. > The patch is a simple line, if anyone is interested. Indeed, mkenvimage is useful. However: *) Could you send a proper git patch, with a description, Signed-off-by line, and sent using git send-email so that it doesn't get line-wrapped by your mail client. *) I would like to see an option being added in the U-Boot configuration options to pass a txt file containing an environment definition, which would be passed through mkenvimage to generate an image environment, and then installed in $(BINARIES_DIR). Could you cook such a patch, or do you prefer if someone else does it? Thanks, Thomas
Hi Mr. Petazzoni, > *) Could you send a proper git patch, with a description, > Signed-off-by line, and sent using git send-email so that it doesn't > get line-wrapped by your mail client. Ok I will look at that and do my best. > *) I would like to see an option being added in the U-Boot > configuration options to pass a txt file containing an environment > definition, which would be passed through mkenvimage to generate an > image environment, and then installed in $(BINARIES_DIR). Could you > cook such a patch, or do you prefer if someone else does it? Sounds good to me, I will send you a new patch. Hopefully before the end of the week. Thanks, On 19/12/12 13:58, Thomas Petazzoni wrote: > Dear Arnaud Rébillout, > > On Wed, 19 Dec 2012 13:47:11 +0100, Arnaud Rébillout wrote: > >> I need to use mkenvimage. And it seems that the easiest way is to >> automatically install it in the HOST_UBOOT_TOOLS_INSTALL_CMDS target. >> The tool mkenvimage appeared v2011.12 of uboot, so it's present in all >> the versions that buildroot supports. >> The patch is a simple line, if anyone is interested. > Indeed, mkenvimage is useful. > > However: > > *) Could you send a proper git patch, with a description, > Signed-off-by line, and sent using git send-email so that it doesn't > get line-wrapped by your mail client. > > *) I would like to see an option being added in the U-Boot > configuration options to pass a txt file containing an environment > definition, which would be passed through mkenvimage to generate an > image environment, and then installed in $(BINARIES_DIR). Could you > cook such a patch, or do you prefer if someone else does it? > > Thanks, > > Thomas
Dear Arnaud Rébillout, On Wed, 19 Dec 2012 14:03:25 +0100, Arnaud Rébillout wrote: > > *) Could you send a proper git patch, with a description, > > Signed-off-by line, and sent using git send-email so that it doesn't > > get line-wrapped by your mail client. > Ok I will look at that and do my best. No problem. If you need help, don't hesitate to ask. Basically, your mail should look like: ================================================================== u-boot: add support for mkenvimage installation and usage U-Boot has an utility called mkenvimage that allows blablabla. This commit installs this utility and provides configuration options for blablabla. Signed-off-by: Arnaud Rébillout <rebillout@syscom.ch> --- <the patch goes here> ================================================================== This gets done automatically by Git as long as you provide the text above as the commit log. > > *) I would like to see an option being added in the U-Boot > > configuration options to pass a txt file containing an environment > > definition, which would be passed through mkenvimage to generate an > > image environment, and then installed in $(BINARIES_DIR). Could you > > cook such a patch, or do you prefer if someone else does it? > Sounds good to me, I will send you a new patch. Hopefully before the end > of the week. Excellent, thanks! Thomas
diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk index 7628b77..57c59bb 100644 --- a/package/uboot-tools/uboot-tools.mk +++ b/package/uboot-tools/uboot-tools.mk @@ -49,6 +49,7 @@ endef define HOST_UBOOT_TOOLS_INSTALL_CMDS $(INSTALL) -m 0755 -D $(@D)/tools/mkimage $(HOST_DIR)/usr/bin/mkimage + $(INSTALL) -m 0755 -D $(@D)/tools/mkenvimage $(HOST_DIR)/usr/bin/mkenvimage endef