diff mbox series

[1/4] support/test/cpio: test for pv already done by listing the cpio archive

Message ID 446f8241f76f0bb59b032b5368e3028e769830f9.1660931225.git.yann.morin.1998@free.fr
State Accepted
Headers show
Series dracut: extend support and tests (branch yem/dracut) | expand

Commit Message

Yann E. MORIN Aug. 19, 2022, 5:50 p.m. UTC
Since we do not pivot_root/switch_root from the cpio, whatever we get
in the rootfs was exactly what we got by listing the cpio archive.

Drop the test for the presence of pv, it's redundant.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Thierry Bultel <thierry.bultel@linatsea.fr>
Cc: Adam Duskett <aduskett@gmail.com>
---
 support/testing/tests/fs/test_cpio.py | 4 ----
 1 file changed, 4 deletions(-)

Comments

Arnout Vandecappelle Sept. 17, 2022, 8:13 p.m. UTC | #1
On 19/08/2022 19:50, Yann E. MORIN wrote:
> Since we do not pivot_root/switch_root from the cpio, whatever we get
> in the rootfs was exactly what we got by listing the cpio archive.
> 
> Drop the test for the presence of pv, it's redundant.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Thierry Bultel <thierry.bultel@linatsea.fr>
> Cc: Adam Duskett <aduskett@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   support/testing/tests/fs/test_cpio.py | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/support/testing/tests/fs/test_cpio.py b/support/testing/tests/fs/test_cpio.py
> index 3f661e370c..9a529f1edd 100644
> --- a/support/testing/tests/fs/test_cpio.py
> +++ b/support/testing/tests/fs/test_cpio.py
> @@ -57,10 +57,6 @@ class TestCpioDracutBase(infra.basetest.BRTest):
>                                self.builddir)
>           self.assertEqual(exit_code, 0)
>   
> -        # No pivot_root is done, so pv shouldn't be there
> -        _, exit_code = self.emulator.run("ls -l /usr/bin/pv")
> -        self.assertNotEqual(exit_code, 0)
> -
>   
>   class TestCpioDracutUclibc(TestCpioDracutBase):
>       config = TestCpioDracutBase.config + \
diff mbox series

Patch

diff --git a/support/testing/tests/fs/test_cpio.py b/support/testing/tests/fs/test_cpio.py
index 3f661e370c..9a529f1edd 100644
--- a/support/testing/tests/fs/test_cpio.py
+++ b/support/testing/tests/fs/test_cpio.py
@@ -57,10 +57,6 @@  class TestCpioDracutBase(infra.basetest.BRTest):
                              self.builddir)
         self.assertEqual(exit_code, 0)
 
-        # No pivot_root is done, so pv shouldn't be there
-        _, exit_code = self.emulator.run("ls -l /usr/bin/pv")
-        self.assertNotEqual(exit_code, 0)
-
 
 class TestCpioDracutUclibc(TestCpioDracutBase):
     config = TestCpioDracutBase.config + \