diff mbox series

[1/1] package/uuu: add target support

Message ID 20250430130142.47069-1-amer.alshanawany@openpixelsystems.org
State Changes Requested
Delegated to: Julien Olivain
Headers show
Series [1/1] package/uuu: add target support | expand

Commit Message

Amer Alshanawany April 30, 2025, 1:01 p.m. UTC
Signed-off-by: Amer Alshanawany <amer.alshanawany@openpixelsystems.org>
---
 package/Config.in     |  1 +
 package/uuu/Config.in | 19 +++++++++++++++++++
 package/uuu/uuu.mk    |  2 ++
 3 files changed, 22 insertions(+)
 create mode 100644 package/uuu/Config.in

Comments

Julien Olivain May 17, 2025, 1:36 p.m. UTC | #1
Hi Amer,

Thanks for the patch. It introduces new build failures, for some
toolchain/configuration. See:
https://gitlab.com/jolivain/buildroot/-/pipelines/1822839699

See below.

On 30/04/2025 15:01, Amer Alshanawany wrote:
> Signed-off-by: Amer Alshanawany <amer.alshanawany@openpixelsystems.org>
> ---
>  package/Config.in     |  1 +
>  package/uuu/Config.in | 19 +++++++++++++++++++
>  package/uuu/uuu.mk    |  2 ++
>  3 files changed, 22 insertions(+)
>  create mode 100644 package/uuu/Config.in
> 
> diff --git a/package/Config.in b/package/Config.in
> index 167965d64b..1730898247 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -2809,6 +2809,7 @@ comment "Utilities"
>  	source "package/tini/Config.in"
>  	source "package/tmux/Config.in"
>  	source "package/ttyd/Config.in"
> +	source "package/uuu/Config.in"
>  	source "package/which/Config.in"
>  	source "package/wlr-randr/Config.in"
>  	source "package/wtfutil/Config.in"
> diff --git a/package/uuu/Config.in b/package/uuu/Config.in
> new file mode 100644
> index 0000000000..bccb96bb13
> --- /dev/null
> +++ b/package/uuu/Config.in
> @@ -0,0 +1,19 @@
> +config BR2_PACKAGE_UUU
> +	bool "uuu"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_USE_WCHAR # libuuu

Here the comment should preferably be:

depends on BR2_USE_WCHAR # libuuu uses wchar_t

Also, there is possibly other dependencies missing here.

> +	select BR2_PACKAGE_BZIP2
> +	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_LIBUSB
> +	select BR2_PACKAGE_TINYXML2
> +	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_ZSTD
> +	help
> +	  UUU (Universal Update Utility) is Freescale/NXP I.MX Chip
> +	  image deploy tool. UUU is an evolution of MFGTools
> +	  (aka MFGTools v3).
> +
> +	  https://github.com/nxp-imx/mfgtools
> +
> +comment "uuu needs a toolchain w/ C++, wchar"
> +	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/uuu/uuu.mk b/package/uuu/uuu.mk
> index 4683cbeec1..9c27c4c1d6 100644
> --- a/package/uuu/uuu.mk
> +++ b/package/uuu/uuu.mk
> @@ -9,6 +9,7 @@ UUU_SOURCE = uuu_source-uuu_$(UUU_VERSION).tar.gz
>  UUU_SITE = 
> https://github.com/nxp-imx/mfgtools/releases/download/uuu_$(UUU_VERSION)
>  UUU_LICENSE = BSD 3-Clause "New" or "Revised" License
>  UUU_LICENSE_FILES = LICENSE
> +UUU_DEPENDENCIES = bzip2 libusb openssl tinyxml2 zlib zstd
>  HOST_UUU_DEPENDENCIES = \
>  	host-bzip2 \
>  	host-libusb \
> @@ -17,4 +18,5 @@ HOST_UUU_DEPENDENCIES = \
>  	host-zlib \
>  	host-zstd
> 
> +$(eval $(cmake-package))
>  $(eval $(host-cmake-package))
> --
> 2.49.0

Could you have a look to fix those, please?

Best regards,

Julien.
diff mbox series

Patch

diff --git a/package/Config.in b/package/Config.in
index 167965d64b..1730898247 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -2809,6 +2809,7 @@  comment "Utilities"
 	source "package/tini/Config.in"
 	source "package/tmux/Config.in"
 	source "package/ttyd/Config.in"
+	source "package/uuu/Config.in"
 	source "package/which/Config.in"
 	source "package/wlr-randr/Config.in"
 	source "package/wtfutil/Config.in"
diff --git a/package/uuu/Config.in b/package/uuu/Config.in
new file mode 100644
index 0000000000..bccb96bb13
--- /dev/null
+++ b/package/uuu/Config.in
@@ -0,0 +1,19 @@ 
+config BR2_PACKAGE_UUU
+	bool "uuu"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_USE_WCHAR # libuuu
+	select BR2_PACKAGE_BZIP2
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_TINYXML2
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_ZSTD
+	help
+	  UUU (Universal Update Utility) is Freescale/NXP I.MX Chip
+	  image deploy tool. UUU is an evolution of MFGTools
+	  (aka MFGTools v3).
+
+	  https://github.com/nxp-imx/mfgtools
+
+comment "uuu needs a toolchain w/ C++, wchar"
+	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/uuu/uuu.mk b/package/uuu/uuu.mk
index 4683cbeec1..9c27c4c1d6 100644
--- a/package/uuu/uuu.mk
+++ b/package/uuu/uuu.mk
@@ -9,6 +9,7 @@  UUU_SOURCE = uuu_source-uuu_$(UUU_VERSION).tar.gz
 UUU_SITE = https://github.com/nxp-imx/mfgtools/releases/download/uuu_$(UUU_VERSION)
 UUU_LICENSE = BSD 3-Clause "New" or "Revised" License
 UUU_LICENSE_FILES = LICENSE
+UUU_DEPENDENCIES = bzip2 libusb openssl tinyxml2 zlib zstd
 HOST_UUU_DEPENDENCIES = \
 	host-bzip2 \
 	host-libusb \
@@ -17,4 +18,5 @@  HOST_UUU_DEPENDENCIES = \
 	host-zlib \
 	host-zstd
 
+$(eval $(cmake-package))
 $(eval $(host-cmake-package))