diff mbox series

[1/2] package/pixman: Don't require vector when BR2_RISCV_ISA_RVV

Message ID 20250430-uprev_pixman_46-v1-1-c1608b4d4bd7@rivosinc.com
State New
Headers show
Series package/pixman: Uprev pixman | expand

Commit Message

Charlie Jenkins April 30, 2025, 7:10 p.m. UTC
If -Drvv=enabled is set but the toolchain doesn't have kernel headers
with vector support, pixman will fail with the error:

"RISC-V Vector Support unavailable, but required"

When BR2_RISCV_ISA_RVV is set, let pixman decide if it wants to use
vector instead.

Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Fixes: 386e6bb47994 ("package/pixman: only compile with riscv vector support when selected")
---
 package/pixman/pixman.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Arnout Vandecappelle May 2, 2025, 11:03 a.m. UTC | #1
On 30/04/2025 21:10, Charlie Jenkins wrote:
> If -Drvv=enabled is set but the toolchain doesn't have kernel headers
> with vector support, pixman will fail with the error:
> 
> "RISC-V Vector Support unavailable, but required"
> 
> When BR2_RISCV_ISA_RVV is set, let pixman decide if it wants to use
> vector instead.
> 
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Fixes: 386e6bb47994 ("package/pixman: only compile with riscv vector support when selected")

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> ---
>   package/pixman/pixman.mk | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/package/pixman/pixman.mk b/package/pixman/pixman.mk
> index 76e72d6d96161f9458cad71a8437e46b3fdf4d95..78ab20da5915f2b7b9d5710b46b5ca8011e32240 100644
> --- a/package/pixman/pixman.mk
> +++ b/package/pixman/pixman.mk
> @@ -74,9 +74,7 @@ else
>   PIXMAN_CONF_OPTS += -Da64-neon=disabled
>   endif
>   
> -ifeq ($(BR2_RISCV_ISA_RVV),y)
> -PIXMAN_CONF_OPTS += -Drvv=enabled
> -else
> +ifneq ($(BR2_RISCV_ISA_RVV),y)
>   PIXMAN_CONF_OPTS += -Drvv=disabled
>   endif
>   
>
diff mbox series

Patch

diff --git a/package/pixman/pixman.mk b/package/pixman/pixman.mk
index 76e72d6d96161f9458cad71a8437e46b3fdf4d95..78ab20da5915f2b7b9d5710b46b5ca8011e32240 100644
--- a/package/pixman/pixman.mk
+++ b/package/pixman/pixman.mk
@@ -74,9 +74,7 @@  else
 PIXMAN_CONF_OPTS += -Da64-neon=disabled
 endif
 
-ifeq ($(BR2_RISCV_ISA_RVV),y)
-PIXMAN_CONF_OPTS += -Drvv=enabled
-else
+ifneq ($(BR2_RISCV_ISA_RVV),y)
 PIXMAN_CONF_OPTS += -Drvv=disabled
 endif