| Message ID | 20250208150332.172207-1-thomas.petazzoni@bootlin.com |
|---|---|
| State | Accepted |
| Delegated to: | Julien Olivain |
| Headers | show |
| Series | [1/2] package/heimdal: host package needs host-libxcrypt | expand |
On 08/02/2025 16:03, Thomas Petazzoni wrote: > The host-heimdal package has always needed a crypt library, but now > that libcrypt is no longer part of glibc, we're seeing build failures > on machines with recent host glibc versions. To fix this, we add > host-libxcrypt to the dependencies, and ensure host-heimdal links with > it. > > Fixes: > > > http://autobuild.buildroot.net/results/864003e1005fcd847b4ec3bd94316638f8f56553/ > https://gitlab.com/buildroot.org/buildroot/-/issues/86 > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Series applied to master, thanks.
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes: > On 08/02/2025 16:03, Thomas Petazzoni wrote: >> The host-heimdal package has always needed a crypt library, but now >> that libcrypt is no longer part of glibc, we're seeing build failures >> on machines with recent host glibc versions. To fix this, we add >> host-libxcrypt to the dependencies, and ensure host-heimdal links with >> it. >> Fixes: >> http://autobuild.buildroot.net/results/864003e1005fcd847b4ec3bd94316638f8f56553/ >> https://gitlab.com/buildroot.org/buildroot/-/issues/86 >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Series applied to master, thanks. And to 2024.02.x / 2024.11.x as well, thanks.
diff --git a/package/heimdal/heimdal.mk b/package/heimdal/heimdal.mk index 786d94a1aa..155cb66e1f 100644 --- a/package/heimdal/heimdal.mk +++ b/package/heimdal/heimdal.mk @@ -6,7 +6,7 @@ HEIMDAL_VERSION = f4faaeaba371fff3f8d1bc14389f5e6d70ca8e17 HEIMDAL_SITE = $(call github,heimdal,heimdal,$(HEIMDAL_VERSION)) -HOST_HEIMDAL_DEPENDENCIES = host-e2fsprogs host-ncurses host-pkgconf +HOST_HEIMDAL_DEPENDENCIES = host-e2fsprogs host-ncurses host-pkgconf host-libxcrypt HOST_HEIMDAL_AUTORECONF = YES HEIMDAL_INSTALL_STAGING = YES # static because of -fPIC issues with e2fsprogs on x86_64 host @@ -29,7 +29,7 @@ HOST_HEIMDAL_CONF_OPTS = \ --disable-heimdal-documentation # Don't use compile_et from e2fsprogs as it raises a build failure with samba4 -HOST_HEIMDAL_CONF_ENV = ac_cv_prog_COMPILE_ET=no MAKEINFO=true +HOST_HEIMDAL_CONF_ENV = ac_cv_prog_COMPILE_ET=no MAKEINFO=true LIBS=-lcrypt HEIMDAL_LICENSE = BSD-3-Clause HEIMDAL_LICENSE_FILES = LICENSE HEIMDAL_CPE_ID_VALID = YES
The host-heimdal package has always needed a crypt library, but now that libcrypt is no longer part of glibc, we're seeing build failures on machines with recent host glibc versions. To fix this, we add host-libxcrypt to the dependencies, and ensure host-heimdal links with it. Fixes: http://autobuild.buildroot.net/results/864003e1005fcd847b4ec3bd94316638f8f56553/ https://gitlab.com/buildroot.org/buildroot/-/issues/86 Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- package/heimdal/heimdal.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)