| Message ID | 20241003165926.849456-1-james.hilliard1@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] package/bluez5_utils: enable asha when building audio plugins | expand |
Hello James, On Thu, 3 Oct 2024 10:59:26 -0600 James Hilliard <james.hilliard1@gmail.com> wrote: > Symbols from the asha plugin are required when building a2dp > support as part of the audio plugins, so always enable asha > when audio plugins are selected. > > Fixes: > - http://autobuild.buildroot.net/results/5a3/5a306356f5f190a14a0a2294a4428544b1a018bb > - http://autobuild.buildroot.net/results/353/3539c83deaa45a3548bcd488659148c62af3fc73 > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> Could you please indicate since when this problem is occurring. It seems to be appearing since the recent bump, but is it really the case? A bug fix submitted to Buildroot should *always* carry an explanation of since when the problem started occurring. Thanks! Thomas
On Thu, Oct 3, 2024 at 2:06 PM Thomas Petazzoni < thomas.petazzoni@bootlin.com> wrote: > Hello James, > > On Thu, 3 Oct 2024 10:59:26 -0600 > James Hilliard <james.hilliard1@gmail.com> wrote: > > > Symbols from the asha plugin are required when building a2dp > > support as part of the audio plugins, so always enable asha > > when audio plugins are selected. > > > > Fixes: > > - > http://autobuild.buildroot.net/results/5a3/5a306356f5f190a14a0a2294a4428544b1a018bb > > - > http://autobuild.buildroot.net/results/353/3539c83deaa45a3548bcd488659148c62af3fc73 > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > Could you please indicate since when this problem is occurring. It > seems to be appearing since the recent bump, but is it really the case? > Looks like it was introduced in ce4e5fd129b557ac0411d0a0704be43717310d6d > > A bug fix submitted to Buildroot should *always* carry an explanation > of since when the problem started occurring. > > Thanks! > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com >
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk index 13a8ce2f0b..10bb067dd3 100644 --- a/package/bluez5_utils/bluez5_utils.mk +++ b/package/bluez5_utils/bluez5_utils.mk @@ -28,7 +28,6 @@ BLUEZ5_UTILS_CONF_OPTS = \ --disable-lsan \ --disable-ubsan \ --disable-pie \ - --disable-asha \ --with-dbusconfdir=/etc ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_OBEX),y) @@ -68,6 +67,7 @@ endif ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO),y) BLUEZ5_UTILS_CONF_OPTS += \ --enable-a2dp \ + --enable-asha \ --enable-avrcp \ --enable-bap \ --enable-mcp \ @@ -75,6 +75,7 @@ BLUEZ5_UTILS_CONF_OPTS += \ else BLUEZ5_UTILS_CONF_OPTS += \ --disable-a2dp \ + --disable-asha \ --disable-avrcp \ --disable-bap \ --disable-mcp \
Symbols from the asha plugin are required when building a2dp support as part of the audio plugins, so always enable asha when audio plugins are selected. Fixes: - http://autobuild.buildroot.net/results/5a3/5a306356f5f190a14a0a2294a4428544b1a018bb - http://autobuild.buildroot.net/results/353/3539c83deaa45a3548bcd488659148c62af3fc73 Signed-off-by: James Hilliard <james.hilliard1@gmail.com> --- package/bluez5_utils/bluez5_utils.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)