diff mbox series

[1/1] package/qt5webengine: add missing opus dependency

Message ID 20240731145754.330678-1-gael.portay@rtone.fr
State Accepted
Headers show
Series [1/1] package/qt5webengine: add missing opus dependency | expand

Commit Message

Gaël PORTAY July 31, 2024, 2:57 p.m. UTC
The package opus is selected but it is not listed in the dependencies.

This adds opus to QT5WEBENGINE_DEPENDENCIES.

Fixes:

	$ make qt5webengine
	(...)
	ERROR: Feature 'webengine-system-opus' was enabled, but the pre-condition 'config.unix && libs.webengine-opus' failed.

Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>
---
 package/qt5/qt5webengine/qt5webengine.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnout Vandecappelle May 17, 2025, 9:20 p.m. UTC | #1
On 31/07/2024 16:57, Gaël PORTAY wrote:
> The package opus is selected but it is not listed in the dependencies.
> 
> This adds opus to QT5WEBENGINE_DEPENDENCIES.
> 
> Fixes:
> 
> 	$ make qt5webengine
> 	(...)
> 	ERROR: Feature 'webengine-system-opus' was enabled, but the pre-condition 'config.unix && libs.webengine-opus' failed.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/qt5/qt5webengine/qt5webengine.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/qt5/qt5webengine/qt5webengine.mk b/package/qt5/qt5webengine/qt5webengine.mk
> index 529a83df6c..f84f056e94 100644
> --- a/package/qt5/qt5webengine/qt5webengine.mk
> +++ b/package/qt5/qt5webengine/qt5webengine.mk
> @@ -78,6 +78,7 @@ QT5WEBENGINE_DEPENDENCIES += \
>   	libvpx \
>   	libxml2 \
>   	libxslt \
> +	opus \
>   	snappy \
>   	webp
>
Arnout Vandecappelle May 31, 2025, 5:05 p.m. UTC | #2
On 31/07/2024 16:57, Gaël PORTAY wrote:
> The package opus is selected but it is not listed in the dependencies.
> 
> This adds opus to QT5WEBENGINE_DEPENDENCIES.
> 
> Fixes:
> 
> 	$ make qt5webengine
> 	(...)
> 	ERROR: Feature 'webengine-system-opus' was enabled, but the pre-condition 'config.unix && libs.webengine-opus' failed.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> ---
>   package/qt5/qt5webengine/qt5webengine.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/qt5/qt5webengine/qt5webengine.mk b/package/qt5/qt5webengine/qt5webengine.mk
> index 529a83df6c..f84f056e94 100644
> --- a/package/qt5/qt5webengine/qt5webengine.mk
> +++ b/package/qt5/qt5webengine/qt5webengine.mk
> @@ -78,6 +78,7 @@ QT5WEBENGINE_DEPENDENCIES += \
>   	libvpx \
>   	libxml2 \
>   	libxslt \
> +	opus \
>   	snappy \
>   	webp
>
diff mbox series

Patch

diff --git a/package/qt5/qt5webengine/qt5webengine.mk b/package/qt5/qt5webengine/qt5webengine.mk
index 529a83df6c..f84f056e94 100644
--- a/package/qt5/qt5webengine/qt5webengine.mk
+++ b/package/qt5/qt5webengine/qt5webengine.mk
@@ -78,6 +78,7 @@  QT5WEBENGINE_DEPENDENCIES += \
 	libvpx \
 	libxml2 \
 	libxslt \
+	opus \
 	snappy \
 	webp