diff mbox series

[1/1] package/ima-evm-utils: bump version to 1.6

Message ID 20240712184241.256166-1-petr.vorel@gmail.com
State Accepted
Headers show
Series [1/1] package/ima-evm-utils: bump version to 1.6 | expand

Commit Message

Petr Vorel July 12, 2024, 6:42 p.m. UTC
Upstream moved git repository.

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
 package/ima-evm-utils/ima-evm-utils.hash | 6 +++---
 package/ima-evm-utils/ima-evm-utils.mk   | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Petr Vorel July 12, 2024, 7 p.m. UTC | #1
Hi all,

FYI tested:
                    bootlin-armv5-uclibc [1/6]: OK
                     bootlin-armv7-glibc [2/6]: OK
                   bootlin-armv7m-uclibc [3/6]: SKIPPED
                     bootlin-x86-64-musl [4/6]: OK
                      br-arm-full-static [5/6]: SKIPPED
                             arm-aarch64 [6/6]: OK
6 builds, 2 skipped, 0 build failed, 0 legal-info failed, 0 show-info failed

Kind regards,
Petr
Thomas Petazzoni July 12, 2024, 8:44 p.m. UTC | #2
On Fri, 12 Jul 2024 20:42:41 +0200
Petr Vorel <petr.vorel@gmail.com> wrote:

> Upstream moved git repository.
> 
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>

Thanks for the update, one important comment below.

> -IMA_EVM_UTILS_VERSION = 1.5
> -IMA_EVM_UTILS_SITE = https://github.com/mimizohar/ima-evm-utils/releases/download/v$(IMA_EVM_UTILS_VERSION)
> +IMA_EVM_UTILS_VERSION = 1.6
> +IMA_EVM_UTILS_SITE = https://github.com/linux-integrity/ima-evm-utils/releases/download/v$(IMA_EVM_UTILS_VERSION)
>  IMA_EVM_UTILS_LICENSE = GPL-2.0
> -IMA_EVM_UTILS_LICENSE_FILES = COPYING
> +IMA_EVM_UTILS_LICENSE_FILES = LICENSES.txt

This change should have called for a review of what changed... and
there has actually been some change. If you look at the LICENSES.txt
file, it clarifies the licensing, and our statement GPL-2.0 is no
longer correct. It should now be:

+IMA_EVM_UTILS_LICENSE = LGPL-2.0+ (libimaevm), GPL-2.0+ (evmctl)

I fixed that up and applied to master. Thanks!

Thomas
Petr Vorel July 13, 2024, 5:27 a.m. UTC | #3
Hi Thomas,

> On Fri, 12 Jul 2024 20:42:41 +0200
> Petr Vorel <petr.vorel@gmail.com> wrote:

> > Upstream moved git repository.

> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>

> Thanks for the update, one important comment below.

> > -IMA_EVM_UTILS_VERSION = 1.5
> > -IMA_EVM_UTILS_SITE = https://github.com/mimizohar/ima-evm-utils/releases/download/v$(IMA_EVM_UTILS_VERSION)
> > +IMA_EVM_UTILS_VERSION = 1.6
> > +IMA_EVM_UTILS_SITE = https://github.com/linux-integrity/ima-evm-utils/releases/download/v$(IMA_EVM_UTILS_VERSION)
> >  IMA_EVM_UTILS_LICENSE = GPL-2.0
> > -IMA_EVM_UTILS_LICENSE_FILES = COPYING
> > +IMA_EVM_UTILS_LICENSE_FILES = LICENSES.txt

> This change should have called for a review of what changed... and
> there has actually been some change. If you look at the LICENSES.txt
> file, it clarifies the licensing, and our statement GPL-2.0 is no
> longer correct. It should now be:

> +IMA_EVM_UTILS_LICENSE = LGPL-2.0+ (libimaevm), GPL-2.0+ (evmctl)

> I fixed that up and applied to master. Thanks!

I'm sorry, thanks for fixing this!

BTW I wonder if it should be:

IMA_EVM_UTILS_LICENSE = LGPL-2.0+ with OpenSSL exception (libimaevm), GPL-2.0+ (evmctl) with OpenSSL exception

The specified the exception before moving to SPDX. Now it does not have it, but
I suppose they fix it once ask for project specific SPDX OpenSSL exception.
Or, maybe it can wait till the next release when they specify it (or till it
appears in their git repository.

Kind regards,
Petr

> Thomas
diff mbox series

Patch

diff --git a/package/ima-evm-utils/ima-evm-utils.hash b/package/ima-evm-utils/ima-evm-utils.hash
index 9777c7f213..844ba0d4fe 100644
--- a/package/ima-evm-utils/ima-evm-utils.hash
+++ b/package/ima-evm-utils/ima-evm-utils.hash
@@ -1,3 +1,3 @@ 
-# https://github.com/mimizohar/ima-evm-utils/releases/download/v1.5/ima-evm-utils-1.5.tar.gz.sha256
-sha256  45f1caa3ad59ec59a1d6a74ea5df38c413488cd952ab62d98cf893c15e6f246d  ima-evm-utils-1.5.tar.gz
-sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
+# https://github.com/linux-integrity/ima-evm-utils/releases/download/v1.6/ima-evm-utils-1.6.tar.gz.sha256
+sha256  3d09e77a09e985b285891f13d458653f44913879147679dce30bdbf00380d40e  ima-evm-utils-1.6.tar.gz
+sha256  d037fb0b5fdb4d1e09e246a56bdb8049fc6d9b1f9270c0ec2ae4bc8f9285165b  LICENSES.txt
diff --git a/package/ima-evm-utils/ima-evm-utils.mk b/package/ima-evm-utils/ima-evm-utils.mk
index b969b4709e..052400eea3 100644
--- a/package/ima-evm-utils/ima-evm-utils.mk
+++ b/package/ima-evm-utils/ima-evm-utils.mk
@@ -4,10 +4,10 @@ 
 #
 ################################################################################
 
-IMA_EVM_UTILS_VERSION = 1.5
-IMA_EVM_UTILS_SITE = https://github.com/mimizohar/ima-evm-utils/releases/download/v$(IMA_EVM_UTILS_VERSION)
+IMA_EVM_UTILS_VERSION = 1.6
+IMA_EVM_UTILS_SITE = https://github.com/linux-integrity/ima-evm-utils/releases/download/v$(IMA_EVM_UTILS_VERSION)
 IMA_EVM_UTILS_LICENSE = GPL-2.0
-IMA_EVM_UTILS_LICENSE_FILES = COPYING
+IMA_EVM_UTILS_LICENSE_FILES = LICENSES.txt
 IMA_EVM_UTILS_INSTALL_STAGING = YES
 IMA_EVM_UTILS_DEPENDENCIES = host-pkgconf keyutils openssl tpm2-tss