| Message ID | 20240513064039.2091596-1-neal.frager@amd.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1,1/2] package/newlib-bare-metal: add patch for gcc 14.1.0 | expand |
Hello, On Mon, 13 May 2024 07:40:38 +0100 Neal Frager via buildroot <buildroot@buildroot.org> wrote: > This patch is needed for building newlib with gcc 14.1.0. Without this patch, > the following build error will occur: > > ../../.././libgloss/microblaze/linux-outbyte.c: In function 'outbyte': > ../../.././libgloss/microblaze/linux-outbyte.c:3:9: error: implicit declaration of function '_write' [-Wimplicit-function-declaration] > 3 | _write(1, &c, 1); > > This patch has been submitted upstream: > https://patchwork.sourceware.org/project/newlib/patch/20240513062419.2042278-1-neal.frager@amd.com/ > > Signed-off-by: Neal Frager <neal.frager@amd.com> > --- > ...oblaze-fix-read-and-_write-declarati.patch | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch > > diff --git a/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch b/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch > new file mode 100644 > index 0000000000..8901f60c3c > --- /dev/null > +++ b/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch This patch should have been directly in package/newlib-bare-metal/, there is no need for a per-version directory. Such subdirectories are only needed when multiple versions of the package are supported (gcc, binutils, gdb, etc.) but not for normal packages that have a fixed version. > @@ -0,0 +1,39 @@ > +From 1ebecb83607e9c0cc44ad1e518169ae03c0f2d26 Mon Sep 17 00:00:00 2001 > +From: Neal Frager <neal.frager@amd.com> > +Date: Mon, 13 May 2024 07:22:47 +0100 > +Subject: [PATCH] libgloss: microblaze: fix read and _write declarations > + > +This patch resolves the following build error which occurs with gcc 14.1.0: > +../../.././libgloss/microblaze/linux-outbyte.c: In function 'outbyte': > +../../.././libgloss/microblaze/linux-outbyte.c:3:9: error: implicit declaration of function '_write' [-Wimplicit-function-declaration] > + 3 | _write(1, &c, 1); > + > +Signed-off-by: Neal Frager <neal.frager@amd.com> The "Upstream:" tag was missing here, and this issue was reported by "make check-package": WARNING: package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch:0: missing Upstream in the header (https://nightly.buildroot.org/#_additional_patch_documentation) I fixed both issues and applied. Thanks! Thomas
diff --git a/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch b/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch new file mode 100644 index 0000000000..8901f60c3c --- /dev/null +++ b/package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch @@ -0,0 +1,39 @@ +From 1ebecb83607e9c0cc44ad1e518169ae03c0f2d26 Mon Sep 17 00:00:00 2001 +From: Neal Frager <neal.frager@amd.com> +Date: Mon, 13 May 2024 07:22:47 +0100 +Subject: [PATCH] libgloss: microblaze: fix read and _write declarations + +This patch resolves the following build error which occurs with gcc 14.1.0: +../../.././libgloss/microblaze/linux-outbyte.c: In function 'outbyte': +../../.././libgloss/microblaze/linux-outbyte.c:3:9: error: implicit declaration of function '_write' [-Wimplicit-function-declaration] + 3 | _write(1, &c, 1); + +Signed-off-by: Neal Frager <neal.frager@amd.com> +--- + libgloss/microblaze/linux-inbyte.c | 2 ++ + libgloss/microblaze/linux-outbyte.c | 2 ++ + 2 files changed, 4 insertions(+) + +diff --git a/libgloss/microblaze/linux-inbyte.c b/libgloss/microblaze/linux-inbyte.c +index 58fdf1957..2f8d33871 100644 +--- a/libgloss/microblaze/linux-inbyte.c ++++ b/libgloss/microblaze/linux-inbyte.c +@@ -1,3 +1,5 @@ ++extern int read (int, char *, int); ++ + int inbyte(void) + { + char ch = 0; +diff --git a/libgloss/microblaze/linux-outbyte.c b/libgloss/microblaze/linux-outbyte.c +index 9d7bc4890..46de511f6 100644 +--- a/libgloss/microblaze/linux-outbyte.c ++++ b/libgloss/microblaze/linux-outbyte.c +@@ -1,3 +1,5 @@ ++extern int _write (int, char *, int); ++ + void outbyte (unsigned char c) + { + _write(1, &c, 1); +-- +2.25.1 +
This patch is needed for building newlib with gcc 14.1.0. Without this patch, the following build error will occur: ../../.././libgloss/microblaze/linux-outbyte.c: In function 'outbyte': ../../.././libgloss/microblaze/linux-outbyte.c:3:9: error: implicit declaration of function '_write' [-Wimplicit-function-declaration] 3 | _write(1, &c, 1); This patch has been submitted upstream: https://patchwork.sourceware.org/project/newlib/patch/20240513062419.2042278-1-neal.frager@amd.com/ Signed-off-by: Neal Frager <neal.frager@amd.com> --- ...oblaze-fix-read-and-_write-declarati.patch | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 package/newlib-bare-metal/4.4.0.20231231/0001-libgloss-microblaze-fix-read-and-_write-declarati.patch