| Message ID | 20240506213038.418213-1-romain.naour@smile.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/python-rpds-py: bump to version 0.18.1 | expand |
On Mon, 6 May 2024 23:30:38 +0200 Romain Naour <romain.naour@smile.fr> wrote: > As reported by Antoine Coutant on the Buildroot mailing list [1]: > > rpds depends on the crate pyo3. This crate uses > > "std::sync::atomic::AtomicI64" > > which doesn't exist for 32 bits targets. > That leads to an error as reported by Buildroot Gitlab-ci. > > An issue have been opened on pyo3's github [2]. > A fix have been accepted by pyo3 [3] and merged in pyo3 0.20.3 release > [4]. This pyo3 0.20.3 uses crate portable-atomic [5] to provide atomic > types and compare and swap operations for all targets that can use std. > > python-rpds-py 0.18.1 is the first release that use pyo3 0.20.3. > > Before python-rpds-py 0.18.1 release fixing this issue would require > that we be able to patch a package during the Cargo vendoring step [6]. > > [1] http://lists.busybox.net/pipermail/buildroot/2024-February/684867.html > [2]: https://github.com/PyO3/pyo3/issues/3614 > [3]: https://github.com/PyO3/pyo3/pull/3619 > [4]: https://github.com/PyO3/pyo3/blob/v0.20.3/CHANGELOG.md > [5]: https://github.com/taiki-e/portable-atomic > [6]: http://lists.busybox.net/pipermail/buildroot/2024-February/684886.html > > Fixes: > https://gitlab.com/buildroot.org/buildroot/-/jobs/6783811842 (TestPythonPy3Dtschema) > https://gitlab.com/buildroot.org/buildroot/-/jobs/6783811860 (TestPythonPy3FlaskExpectsJson) > > Reported-by: Antoine Coutant <antoine.coutant@smile.fr> > Cc: James Hilliard <james.hilliard1@gmail.com> > Signed-off-by: Romain Naour <romain.naour@smile.fr> > --- > package/python-rpds-py/python-rpds-py.hash | 2 +- > package/python-rpds-py/python-rpds-py.mk | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Applied to master, thanks. Thomas
>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes: > As reported by Antoine Coutant on the Buildroot mailing list [1]: > rpds depends on the crate pyo3. This crate uses > "std::sync::atomic::AtomicI64" > which doesn't exist for 32 bits targets. > That leads to an error as reported by Buildroot Gitlab-ci. > An issue have been opened on pyo3's github [2]. > A fix have been accepted by pyo3 [3] and merged in pyo3 0.20.3 release > [4]. This pyo3 0.20.3 uses crate portable-atomic [5] to provide atomic > types and compare and swap operations for all targets that can use std. > python-rpds-py 0.18.1 is the first release that use pyo3 0.20.3. > Before python-rpds-py 0.18.1 release fixing this issue would require > that we be able to patch a package during the Cargo vendoring step [6]. > [1] http://lists.busybox.net/pipermail/buildroot/2024-February/684867.html > [2]: https://github.com/PyO3/pyo3/issues/3614 > [3]: https://github.com/PyO3/pyo3/pull/3619 > [4]: https://github.com/PyO3/pyo3/blob/v0.20.3/CHANGELOG.md > [5]: https://github.com/taiki-e/portable-atomic > [6]: http://lists.busybox.net/pipermail/buildroot/2024-February/684886.html > Fixes: > https://gitlab.com/buildroot.org/buildroot/-/jobs/6783811842 (TestPythonPy3Dtschema) > https://gitlab.com/buildroot.org/buildroot/-/jobs/6783811860 (TestPythonPy3FlaskExpectsJson) > Reported-by: Antoine Coutant <antoine.coutant@smile.fr> > Cc: James Hilliard <james.hilliard1@gmail.com> > Signed-off-by: Romain Naour <romain.naour@smile.fr> Committed to 2024.02.x, thanks.
diff --git a/package/python-rpds-py/python-rpds-py.hash b/package/python-rpds-py/python-rpds-py.hash index 4650d9c385..62b508ae6b 100644 --- a/package/python-rpds-py/python-rpds-py.hash +++ b/package/python-rpds-py/python-rpds-py.hash @@ -1,4 +1,4 @@ # Locally calculated after vendoring -sha256 760b05720269195d86071ac7cf627b3a4ab9366680d8d449a6a63b84d96a5bc0 rpds_py-0.17.1.tar.gz +sha256 d9b542bf5321495737005a78d9fbf40541b898d1e2b3309cbe36a2431977be8b rpds_py-0.18.1.tar.gz # Locally computed sha256 checksums sha256 314e4e91be3baa93c0fb4bccc9e4e97cd643eb839b065af921782c2175fe9909 LICENSE diff --git a/package/python-rpds-py/python-rpds-py.mk b/package/python-rpds-py/python-rpds-py.mk index cee2ff290a..c38f749521 100644 --- a/package/python-rpds-py/python-rpds-py.mk +++ b/package/python-rpds-py/python-rpds-py.mk @@ -4,9 +4,9 @@ # ################################################################################ -PYTHON_RPDS_PY_VERSION = 0.17.1 +PYTHON_RPDS_PY_VERSION = 0.18.1 PYTHON_RPDS_PY_SOURCE = rpds_py-$(PYTHON_RPDS_PY_VERSION).tar.gz -PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/b7/0a/e3bdcc977e6db3bf32a3f42172f583adfa7c3604091a03d512333e0161fe +PYTHON_RPDS_PY_SITE = https://files.pythonhosted.org/packages/2d/aa/e7c404bdee1db7be09860dff423d022ffdce9269ec8e6532cce09ee7beea PYTHON_RPDS_PY_SETUP_TYPE = maturin PYTHON_RPDS_PY_LICENSE = MIT PYTHON_RPDS_PY_LICENSE_FILES = LICENSE
As reported by Antoine Coutant on the Buildroot mailing list [1]: rpds depends on the crate pyo3. This crate uses "std::sync::atomic::AtomicI64" which doesn't exist for 32 bits targets. That leads to an error as reported by Buildroot Gitlab-ci. An issue have been opened on pyo3's github [2]. A fix have been accepted by pyo3 [3] and merged in pyo3 0.20.3 release [4]. This pyo3 0.20.3 uses crate portable-atomic [5] to provide atomic types and compare and swap operations for all targets that can use std. python-rpds-py 0.18.1 is the first release that use pyo3 0.20.3. Before python-rpds-py 0.18.1 release fixing this issue would require that we be able to patch a package during the Cargo vendoring step [6]. [1] http://lists.busybox.net/pipermail/buildroot/2024-February/684867.html [2]: https://github.com/PyO3/pyo3/issues/3614 [3]: https://github.com/PyO3/pyo3/pull/3619 [4]: https://github.com/PyO3/pyo3/blob/v0.20.3/CHANGELOG.md [5]: https://github.com/taiki-e/portable-atomic [6]: http://lists.busybox.net/pipermail/buildroot/2024-February/684886.html Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/6783811842 (TestPythonPy3Dtschema) https://gitlab.com/buildroot.org/buildroot/-/jobs/6783811860 (TestPythonPy3FlaskExpectsJson) Reported-by: Antoine Coutant <antoine.coutant@smile.fr> Cc: James Hilliard <james.hilliard1@gmail.com> Signed-off-by: Romain Naour <romain.naour@smile.fr> --- package/python-rpds-py/python-rpds-py.hash | 2 +- package/python-rpds-py/python-rpds-py.mk | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)