Message ID | 20240415162229.1357491-2-thomas.perale@mind.be |
---|---|
State | New |
Headers | show |
Series | support for a pre-built Go compiler | expand |
Thomas, All, On 2024-04-15 18:22 +0200, Thomas Perale via buildroot spake thusly: > Signed-off-by: Thomas Perale <thomas.perale@mind.be> Your From and Signed-off-by are still not the same: @essensium.com vs. @mind.be. Check your ~/.gitconfig for the proper user.email key. If you also set format.signOff, it should automatically inject the proper SoB line, but if you, like me, explicitly inject SoB lines [0], check your code snippet. [0] I use vim's snipmate plugin https://github.com/garbas/vim-snipmate with my own snippets for SoB lines: snippet sob Signed-off-by: snippet ME Yann E. MORIN <yann.morin.1998@free.fr> (so that I can reflex-type sob<TAB>ME<TAB> for my SoB lines.) For this series, no need to respin _just_ for this: just reply whether to use the SoB line (@mind) or the From field (@essentium), and I can fix it locally when applying. Regards, Yann E. MORIN. > --- > DEVELOPERS | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/DEVELOPERS b/DEVELOPERS > index 399b2931ff..039b803d50 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -2979,6 +2979,9 @@ F: package/frotz/ > F: package/kvm-unit-tests/ > F: package/xorcurses/ > > +N: Thomas Perale <thomas.perale@mind.be> > +F: package/go/ > + > N: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > F: arch/Config.in.arm > F: board/beaglev/ > -- > 2.44.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Yann, Please use SoB @mind.be. I subscribed with the @essensium email to the buildroot ML and if i recall correctly i received an error when sending with the @mind alias and didn't really bothered fixing it. Regards, PERALE Thomas On 4/15/24 6:44 PM, Yann E. MORIN wrote: > Thomas, All, > > On 2024-04-15 18:22 +0200, Thomas Perale via buildroot spake thusly: >> Signed-off-by: Thomas Perale <thomas.perale@mind.be> > Your From and Signed-off-by are still not the same: @essensium.com vs. > @mind.be. > > Check your ~/.gitconfig for the proper user.email key. If you also set > format.signOff, it should automatically inject the proper SoB line, but > if you, like me, explicitly inject SoB lines [0], check your code > snippet. > > [0] I use vim's snipmate plugin https://github.com/garbas/vim-snipmate > with my own snippets for SoB lines: > > snippet sob > Signed-off-by: > snippet ME > Yann E. MORIN <yann.morin.1998@free.fr> > > (so that I can reflex-type sob<TAB>ME<TAB> for my SoB lines.) > > For this series, no need to respin _just_ for this: just reply whether > to use the SoB line (@mind) or the From field (@essentium), and I can > fix it locally when applying. > > Regards, > Yann E. MORIN. > >> --- >> DEVELOPERS | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/DEVELOPERS b/DEVELOPERS >> index 399b2931ff..039b803d50 100644 >> --- a/DEVELOPERS >> +++ b/DEVELOPERS >> @@ -2979,6 +2979,9 @@ F: package/frotz/ >> F: package/kvm-unit-tests/ >> F: package/xorcurses/ >> >> +N: Thomas Perale <thomas.perale@mind.be> >> +F: package/go/ >> + >> N: Thomas Petazzoni <thomas.petazzoni@bootlin.com> >> F: arch/Config.in.arm >> F: board/beaglev/ >> -- >> 2.44.0 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot
On 2024-04-15 19:38 +0200, Thomas Perale spake thusly: > Please use SoB @mind.be. > > I subscribed with the @essensium email to the buildroot ML and if i recall > correctly i received an error when sending with the @mind alias and didn't > really bothered fixing it. In that case, I think you can tell git send-email to always inject the pseudo From-header at the beginning of the commit, and when we git-am, that's what get used instead of the mail's From field. I had a similar issue with my @work setup [0], I'll dig up the git config I use there tomorrow. [0] https://lore.kernel.org/buildroot/ZNCU8E59+%2FD%2Frn5T@tl-lnx-nyma7486-2/ Regards, Yann E. MORIN. > Regards, > PERALE Thomas > > On 4/15/24 6:44 PM, Yann E. MORIN wrote: > > Thomas, All, > > > > On 2024-04-15 18:22 +0200, Thomas Perale via buildroot spake thusly: > > > Signed-off-by: Thomas Perale <thomas.perale@mind.be> > > Your From and Signed-off-by are still not the same: @essensium.com vs. > > @mind.be. > > > > Check your ~/.gitconfig for the proper user.email key. If you also set > > format.signOff, it should automatically inject the proper SoB line, but > > if you, like me, explicitly inject SoB lines [0], check your code > > snippet. > > > > [0] I use vim's snipmate plugin https://github.com/garbas/vim-snipmate > > with my own snippets for SoB lines: > > > > snippet sob > > Signed-off-by: > > snippet ME > > Yann E. MORIN <yann.morin.1998@free.fr> > > > > (so that I can reflex-type sob<TAB>ME<TAB> for my SoB lines.) > > > > For this series, no need to respin _just_ for this: just reply whether > > to use the SoB line (@mind) or the From field (@essentium), and I can > > fix it locally when applying. > > > > Regards, > > Yann E. MORIN. > > > > > --- > > > DEVELOPERS | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/DEVELOPERS b/DEVELOPERS > > > index 399b2931ff..039b803d50 100644 > > > --- a/DEVELOPERS > > > +++ b/DEVELOPERS > > > @@ -2979,6 +2979,9 @@ F: package/frotz/ > > > F: package/kvm-unit-tests/ > > > F: package/xorcurses/ > > > > > > +N: Thomas Perale <thomas.perale@mind.be> > > > +F: package/go/ > > > + > > > N: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > > > F: arch/Config.in.arm > > > F: board/beaglev/ > > > -- > > > 2.44.0 > > > > > > _______________________________________________ > > > buildroot mailing list > > > buildroot@buildroot.org > > > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/DEVELOPERS b/DEVELOPERS index 399b2931ff..039b803d50 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -2979,6 +2979,9 @@ F: package/frotz/ F: package/kvm-unit-tests/ F: package/xorcurses/ +N: Thomas Perale <thomas.perale@mind.be> +F: package/go/ + N: Thomas Petazzoni <thomas.petazzoni@bootlin.com> F: arch/Config.in.arm F: board/beaglev/
Signed-off-by: Thomas Perale <thomas.perale@mind.be> --- DEVELOPERS | 3 +++ 1 file changed, 3 insertions(+) -- 2.44.0