| Message ID | 20240404194723.1346001-1-fontaine.fabrice@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] package/privoxy: fix build with root | expand |
On Thu, 4 Apr 2024 21:47:23 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > Set GROUP_T when installing configuration files as root to avoid the > following build failure raised since commit > b6816034ebddd522a8fef9daa454c28fa1230dd6: > > /usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc' > > Fixes: b6816034ebddd522a8fef9daa454c28fa1230dd6 > - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > ...0002-GNUMakefile.in-fix-root-install.patch | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 package/privoxy/0002-GNUMakefile.in-fix-root-install.patch I'm confused because the Buildroot build does not run as root. So why does this happen? Thomas
Hi, Le lun. 8 avr. 2024 à 23:08, Thomas Petazzoni <thomas.petazzoni@bootlin.com> a écrit : > > On Thu, 4 Apr 2024 21:47:23 +0200 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > > > Set GROUP_T when installing configuration files as root to avoid the > > following build failure raised since commit > > b6816034ebddd522a8fef9daa454c28fa1230dd6: > > > > /usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc' > > > > Fixes: b6816034ebddd522a8fef9daa454c28fa1230dd6 > > - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883 > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > ...0002-GNUMakefile.in-fix-root-install.patch | 35 +++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 package/privoxy/0002-GNUMakefile.in-fix-root-install.patch > > I'm confused because the Buildroot build does not run as root. So why > does this happen? This only happens with armabuilder from Sébastien Szymanski and I assume that the buildroot build on this autobuilder really runs as root. > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Best Regards, Fabrice
diff --git a/package/privoxy/0002-GNUMakefile.in-fix-root-install.patch b/package/privoxy/0002-GNUMakefile.in-fix-root-install.patch new file mode 100644 index 0000000000..89347c214e --- /dev/null +++ b/package/privoxy/0002-GNUMakefile.in-fix-root-install.patch @@ -0,0 +1,35 @@ +From 25bd5ae1664f5603c05c72b2c38525602f33da0a Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <fontaine.fabrice@gmail.com> +Date: Sun, 31 Mar 2024 19:17:45 +0200 +Subject: [PATCH] GNUMakefile.in: fix root install + +Set GROUP_T when installing configuration files as root to avoid the +following build failure since commit +4b3b267db159dc23314de3062859481b7c397e32: + +/usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc' + +Fixes: + - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883 + +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> +Upstream: https://lists.privoxy.org/pipermail/privoxy-devel/2024-March/000760.html +--- + GNUmakefile.in | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/GNUmakefile.in b/GNUmakefile.in +index cf79aae1..db1bab59 100644 +--- a/GNUmakefile.in ++++ b/GNUmakefile.in +@@ -927,6 +927,7 @@ install: CONF_DEST LOG_DEST PID_DEST check_doc GROUP_T + $(ECHO) " and to install the config files as that user and/or group!" ;\ + $(ECHO) " Please read INSTALL, and create a privoxy user and group!" ;\ + $(ECHO) "*******************************************************************" ;\ ++ GROUP_T=$(GROUP) ;\ + fi ;\ + else \ + GROUP_T=$(GROUP) ;\ +-- +2.43.0 +
Set GROUP_T when installing configuration files as root to avoid the following build failure raised since commit b6816034ebddd522a8fef9daa454c28fa1230dd6: /usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc' Fixes: b6816034ebddd522a8fef9daa454c28fa1230dd6 - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- ...0002-GNUMakefile.in-fix-root-install.patch | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 package/privoxy/0002-GNUMakefile.in-fix-root-install.patch