diff mbox series

[1/1] package/giflib: fix host build without convert

Message ID 20240331164354.94483-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/giflib: fix host build without convert | expand

Commit Message

Fabrice Fontaine March 31, 2024, 4:43 p.m. UTC
Do not build docs for host-giflib to avoid the following build failure
without convert on host raised since bump to version 5.2.2 in commit
f98239dada59270efe19de9d9fae50ec9ab9d28c and
https://sourceforge.net/p/giflib/code/ci/d565f6fa04be8973425bd7cd3f169908ac9e95c2:

convert ../pic/gifgrid.gif -resize 50x50 giflib-logo.gif
make[2]: convert: No such file or directory

Fixes: f98239dada59270efe19de9d9fae50ec9ab9d28c
 - http://autobuild.buildroot.org/results/04dd54f5060881cb8aa030de34edb4ceea863fa6

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/giflib/giflib.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN April 1, 2024, 1:09 p.m. UTC | #1
Fabrice, All,

On 2024-03-31 18:43 +0200, Fabrice Fontaine spake thusly:
> Do not build docs for host-giflib to avoid the following build failure
> without convert on host raised since bump to version 5.2.2 in commit
> f98239dada59270efe19de9d9fae50ec9ab9d28c and
> https://sourceforge.net/p/giflib/code/ci/d565f6fa04be8973425bd7cd3f169908ac9e95c2:
> 
> convert ../pic/gifgrid.gif -resize 50x50 giflib-logo.gif
> make[2]: convert: No such file or directory
> 
> Fixes: f98239dada59270efe19de9d9fae50ec9ab9d28c
>  - http://autobuild.buildroot.org/results/04dd54f5060881cb8aa030de34edb4ceea863fa6
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/giflib/giflib.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/giflib/giflib.mk b/package/giflib/giflib.mk
> index 770338507b..f37ec8af21 100644
> --- a/package/giflib/giflib.mk
> +++ b/package/giflib/giflib.mk
> @@ -27,7 +27,7 @@ define GIFLIB_BUILD_CMDS
>  endef
>  
>  define HOST_GIFLIB_BUILD_CMDS
> -	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)
> +	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) shared-lib
>  endef
>  
>  define GIFLIB_INSTALL_STAGING_CMDS
> @@ -42,7 +42,7 @@ endef
>  
>  define HOST_GIFLIB_INSTALL_CMDS
>  	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) \
> -		PREFIX=/usr install
> +		PREFIX=/usr install-include install-shared-lib
>  endef
>  
>  $(eval $(generic-package))
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard April 28, 2024, 7:35 p.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Do not build docs for host-giflib to avoid the following build failure
 > without convert on host raised since bump to version 5.2.2 in commit
 > f98239dada59270efe19de9d9fae50ec9ab9d28c and
 > https://sourceforge.net/p/giflib/code/ci/d565f6fa04be8973425bd7cd3f169908ac9e95c2:

 > convert ../pic/gifgrid.gif -resize 50x50 giflib-logo.gif
 > make[2]: convert: No such file or directory

 > Fixes: f98239dada59270efe19de9d9fae50ec9ab9d28c
 >  - http://autobuild.buildroot.org/results/04dd54f5060881cb8aa030de34edb4ceea863fa6

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x, thanks.
diff mbox series

Patch

diff --git a/package/giflib/giflib.mk b/package/giflib/giflib.mk
index 770338507b..f37ec8af21 100644
--- a/package/giflib/giflib.mk
+++ b/package/giflib/giflib.mk
@@ -27,7 +27,7 @@  define GIFLIB_BUILD_CMDS
 endef
 
 define HOST_GIFLIB_BUILD_CMDS
-	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) shared-lib
 endef
 
 define GIFLIB_INSTALL_STAGING_CMDS
@@ -42,7 +42,7 @@  endef
 
 define HOST_GIFLIB_INSTALL_CMDS
 	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(HOST_DIR) \
-		PREFIX=/usr install
+		PREFIX=/usr install-include install-shared-lib
 endef
 
 $(eval $(generic-package))