diff mbox series

package/nodejs: bump to 20.12.0

Message ID 20240328110058.2037303-1-buildroot@bubu1.eu
State New
Headers show
Series package/nodejs: bump to 20.12.0 | expand

Commit Message

Marcus Hoffmann March 28, 2024, 11 a.m. UTC
Release Notes: https://nodejs.org/en/blog/release/v20.12.0

LICENSE hash changed due to changes in vendored components:

* copyright year updates [1][2]
* version name update [3]
* change from "Unicode, Inc. License - Data Files and Software"
  to the "Unicode License v3" [4]. This is in the icu vendored
  dependency which is unused in buildroot.
* new build tooling script [5] under BSD style license

[1] https://github.com/nodejs/node/commit/347e1dd06a5f927d9fd64ce72d776c56d5101910
[2] https://github.com/nodejs/node/commit/b88170d602791fa62fc45ac80ca9953bc1bdd25b
[3] https://github.com/nodejs/node/commit/c8233912e9fd7464898b549d6762130722bf0bf4
[4] https://github.com/nodejs/node/commit/625fd69b76b5a8f59152f803b31941c8986d924b
[5] https://github.com/nodejs/node/commit/b5bc597871ca701bab750c46d31ed626decd7f89

Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
---
 package/nodejs/nodejs.hash | 14 +++++++-------
 package/nodejs/nodejs.mk   |  2 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Thomas Petazzoni April 10, 2024, 9:25 p.m. UTC | #1
Hello Marcus,

On Thu, 28 Mar 2024 12:00:58 +0100
Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote:

> Release Notes: https://nodejs.org/en/blog/release/v20.12.0
> 
> LICENSE hash changed due to changes in vendored components:
> 
> * copyright year updates [1][2]
> * version name update [3]
> * change from "Unicode, Inc. License - Data Files and Software"
>   to the "Unicode License v3" [4]. This is in the icu vendored
>   dependency which is unused in buildroot.
> * new build tooling script [5] under BSD style license
> 
> [1] https://github.com/nodejs/node/commit/347e1dd06a5f927d9fd64ce72d776c56d5101910
> [2] https://github.com/nodejs/node/commit/b88170d602791fa62fc45ac80ca9953bc1bdd25b
> [3] https://github.com/nodejs/node/commit/c8233912e9fd7464898b549d6762130722bf0bf4
> [4] https://github.com/nodejs/node/commit/625fd69b76b5a8f59152f803b31941c8986d924b
> [5] https://github.com/nodejs/node/commit/b5bc597871ca701bab750c46d31ed626decd7f89
> 
> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>

Thanks for this bump. Did you run our NodeJS tests after this bump? In
particular one aspect about which we need to be careful is that we
offer two ways of installing NodeJS: install a pre-compiled binary, or
build entirely from source. Running our NodeJS tests ensures that both
situations have been verified after a bump.

Thanks!

Thomas
Marcus Hoffmann April 15, 2024, 12:38 p.m. UTC | #2
Hi Thomas,

On 10.04.24 23:25, Thomas Petazzoni wrote:
> Hello Marcus,
> 
> On Thu, 28 Mar 2024 12:00:58 +0100
> Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote:
> 
>> Release Notes: https://nodejs.org/en/blog/release/v20.12.0
>>
>> LICENSE hash changed due to changes in vendored components:
>>
>> * copyright year updates [1][2]
>> * version name update [3]
>> * change from "Unicode, Inc. License - Data Files and Software"
>>    to the "Unicode License v3" [4]. This is in the icu vendored
>>    dependency which is unused in buildroot.
>> * new build tooling script [5] under BSD style license
>>
>> [1] https://github.com/nodejs/node/commit/347e1dd06a5f927d9fd64ce72d776c56d5101910
>> [2] https://github.com/nodejs/node/commit/b88170d602791fa62fc45ac80ca9953bc1bdd25b
>> [3] https://github.com/nodejs/node/commit/c8233912e9fd7464898b549d6762130722bf0bf4
>> [4] https://github.com/nodejs/node/commit/625fd69b76b5a8f59152f803b31941c8986d924b
>> [5] https://github.com/nodejs/node/commit/b5bc597871ca701bab750c46d31ed626decd7f89
>>
>> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
> 
> Thanks for this bump. Did you run our NodeJS tests after this bump? In
> particular one aspect about which we need to be careful is that we
> offer two ways of installing NodeJS: install a pre-compiled binary, or
> build entirely from source. Running our NodeJS tests ensures that both
> situations have been verified after a bump.

I did not (yet, will do now when I don't need my PC for day ;-)). What I 
did was build nodejs for our target which uses host-nodejs prebuilt and 
target nodejs from source. That continued to work as expected.

I'll report back about the tests once I get around to it.

> 
> Thanks!
> 
> Thomas

Marcus
diff mbox series

Patch

diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
index ddab345e0a..2cbbf766f5 100644
--- a/package/nodejs/nodejs.hash
+++ b/package/nodejs/nodejs.hash
@@ -1,8 +1,8 @@ 
-# From https://nodejs.org/dist/v20.11.1/SHASUMS256.txt.asc
-sha256  c957f29eb4e341903520caf362534f0acd1db7be79c502ae8e283994eed07fe1  node-v20.11.1-linux-arm64.tar.xz
-sha256  28e0120d2d150a8f41717899d33167b8b32053778665583d49ff971bfd188d1b  node-v20.11.1-linux-armv7l.tar.xz
-sha256  51343cacf5cdf5c4b5e93e919d19dd373d6ef43d5f2c666eae299f26e31d08b5  node-v20.11.1-linux-ppc64le.tar.xz
-sha256  d8dab549b09672b03356aa2257699f3de3b58c96e74eb26a8b495fbdc9cf6fbe  node-v20.11.1-linux-x64.tar.xz
-sha256  77813edbf3f7f16d2d35d3353443dee4e61d5ee84d9e3138c7538a3c0ca5209e  node-v20.11.1.tar.xz
+# From https://nodejs.org/dist/v20.12.0/SHASUMS256.txt.asc
+sha256  007ca2699cf6e84290e5bed844ed66ef9d707d23561dfaf117212b7dce216ba7  node-v20.12.0-linux-arm64.tar.xz
+sha256  668fb421a24be596c98f00a31049fbf6ada14d221b7382e0f1caa55ab421431a  node-v20.12.0-linux-armv7l.tar.xz
+sha256  78dc3b7ad993c332684802e35c1f0de2b76193d13394bc89e3bab216828587c7  node-v20.12.0-linux-ppc64le.tar.xz
+sha256  0a126adf5b6a5eb11a37bad76a0c626a18f20b6811322e68aae0e3cf9bf580bd  node-v20.12.0-linux-x64.tar.xz
+sha256  76e5346cebfd581528f699f764f4d1a6e87cb818b696708f235ddcb625a0f78d  node-v20.12.0.tar.xz
 # Locally calculated
-sha256  7b0bbdca72f925bd78b764914651244a4432a753c7325d061a565cd7eac1193d  LICENSE
+sha256  d3a9fbfe0a1fb78627ee296cd5ca5b498822d4d1c5da3b8e8100c41bd7b791fd  LICENSE
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 858c6a86f5..9ed51fbe9b 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -5,7 +5,7 @@ 
 ################################################################################
 
 # _VERSION, _SOURCE and _SITE must be kept empty to avoid downloading anything
-NODEJS_COMMON_VERSION = 20.11.1
+NODEJS_COMMON_VERSION = 20.12.0
 NODEJS_COMMON_SOURCE = node-v$(NODEJS_COMMON_VERSION).tar.xz
 NODEJS_COMMON_SITE = http://nodejs.org/dist/v$(NODEJS_COMMON_VERSION)