| Message ID | 20240306111212.1331451-1-anaumann@ultratronik.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/imx-gpu-viv: fix masking fb option | expand |
Hi Andreas, On 06/03/2024 12:12, Andreas Naumann wrote: > Only the 32bit ARM blob provides the framebuffer backend. This is > apparently independent of which imx8 derivate is used, so changed > the condition for the config option accordingly. You should have included some references here so other people can double-check this information. > > Signed-off-by: Andreas Naumann <anaumann@ultratronik.de> > --- > package/freescale-imx/imx-gpu-viv/Config.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/freescale-imx/imx-gpu-viv/Config.in b/package/freescale-imx/imx-gpu-viv/Config.in > index 3e095b730cf..b8dff8f9ab6 100644 > --- a/package/freescale-imx/imx-gpu-viv/Config.in > +++ b/package/freescale-imx/imx-gpu-viv/Config.in > @@ -45,8 +45,8 @@ choice > > config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_FB > bool "Framebuffer" > - # The i.MX8 blob doesn't support FB output > - depends on !BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M > + # The i.MX8 aarch64 blob doesn't support FB output Or you can still add that later in a comment here. Applied to master, thanks. Regards, Arnout > + depends on BR2_arm > > config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_WL > bool "Wayland"
Hi Arnout, all, On 07.04.24 18:11, Arnout Vandecappelle via buildroot wrote: > Hi Andreas, > > On 06/03/2024 12:12, Andreas Naumann wrote: >> Only the 32bit ARM blob provides the framebuffer backend. This is >> apparently independent of which imx8 derivate is used, so changed >> the condition for the config option accordingly. > > You should have included some references here so other people can > double-check this information. I have no reference other than whats available in the blobs. There are two different blobs for 32 and 64 bit arch and only the 32bit variant provides the gpu-core/usr/lib/fb/ subfolder with the relevant .so files. > >> >> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de> >> --- >> package/freescale-imx/imx-gpu-viv/Config.in | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/package/freescale-imx/imx-gpu-viv/Config.in >> b/package/freescale-imx/imx-gpu-viv/Config.in >> index 3e095b730cf..b8dff8f9ab6 100644 >> --- a/package/freescale-imx/imx-gpu-viv/Config.in >> +++ b/package/freescale-imx/imx-gpu-viv/Config.in >> @@ -45,8 +45,8 @@ choice >> config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_FB >> bool "Framebuffer" >> - # The i.MX8 blob doesn't support FB output >> - depends on !BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M >> + # The i.MX8 aarch64 blob doesn't support FB output > > Or you can still add that later in a comment here. > > Applied to master, thanks. thanks, Andreas > > Regards, > Arnout > >> + depends on BR2_arm >> config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_WL >> bool "Wayland" > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot >
diff --git a/package/freescale-imx/imx-gpu-viv/Config.in b/package/freescale-imx/imx-gpu-viv/Config.in index 3e095b730cf..b8dff8f9ab6 100644 --- a/package/freescale-imx/imx-gpu-viv/Config.in +++ b/package/freescale-imx/imx-gpu-viv/Config.in @@ -45,8 +45,8 @@ choice config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_FB bool "Framebuffer" - # The i.MX8 blob doesn't support FB output - depends on !BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M + # The i.MX8 aarch64 blob doesn't support FB output + depends on BR2_arm config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_WL bool "Wayland"
Only the 32bit ARM blob provides the framebuffer backend. This is apparently independent of which imx8 derivate is used, so changed the condition for the config option accordingly. Signed-off-by: Andreas Naumann <anaumann@ultratronik.de> --- package/freescale-imx/imx-gpu-viv/Config.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)