| Message ID | 20240303132222.151704-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/google-breakpad: needs C++17 | expand |
On 03/03/2024 14:22, Fabrice Fontaine wrote: > Fix the following build failure raised since commit > 32c1fbad554d4c2bfbe56a652333195c8ae67904: > > configure: error: *** A compiler with support for C++17 language features is required. > > Fixes: 32c1fbad554d4c2bfbe56a652333195c8ae67904 > - http://autobuild.buildroot.org/results/451bae7151a74cbcb5d199b8516e9c255a0953fe > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> You forgot to update BR2_GOOGLE_BREAKPAD_ENABLE in Config.in. Applied to master with that fixed, thanks. Regards, Arnout > --- > package/google-breakpad/Config.in | 6 +++--- > package/sentry-native/Config.in | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in > index 5c7f4bb7ba..4e2d98eb04 100644 > --- a/package/google-breakpad/Config.in > +++ b/package/google-breakpad/Config.in > @@ -6,7 +6,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS > config BR2_PACKAGE_GOOGLE_BREAKPAD > bool "google-breakpad" > depends on BR2_INSTALL_LIBSTDCPP > - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11 > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 > depends on BR2_USE_WCHAR > depends on BR2_TOOLCHAIN_HAS_THREADS > depends on BR2_TOOLCHAIN_USES_GLIBC > @@ -45,10 +45,10 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS > > endif > > -comment "google-breakpad requires a glibc toolchain w/ wchar, thread, C++, gcc >= 4.8" > +comment "google-breakpad requires a glibc toolchain w/ wchar, threads, C++, gcc >= 7" > depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS > depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > !BR2_TOOLCHAIN_HAS_THREADS || \ > !BR2_TOOLCHAIN_USES_GLIBC || \ > - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 > + !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > diff --git a/package/sentry-native/Config.in b/package/sentry-native/Config.in > index 7a3cbd36ad..88db2779f1 100644 > --- a/package/sentry-native/Config.in > +++ b/package/sentry-native/Config.in > @@ -1,7 +1,7 @@ > config BR2_PACKAGE_SENTRY_NATIVE > bool "sentry-native" > depends on BR2_INSTALL_LIBSTDCPP # google-breakpad > - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # google-breakpad > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # google-breakpad > depends on BR2_USE_WCHAR # google-breakpad > depends on BR2_TOOLCHAIN_HAS_THREADS # google-breakpad > # google-breakpad is restricted to glibc or uClibc, but > @@ -19,10 +19,10 @@ config BR2_PACKAGE_SENTRY_NATIVE > > https://github.com/getsentry/sentry-native > > -comment "sentry-native needs a glibc toolchain with w/ wchar, thread, C++, gcc >= 4.8" > +comment "sentry-native needs a glibc toolchain with w/ wchar, threads, C++, gcc >= 7" > depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS > depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > !BR2_TOOLCHAIN_HAS_THREADS || \ > !BR2_TOOLCHAIN_USES_GLIBC || \ > - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 > + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in index 5c7f4bb7ba..4e2d98eb04 100644 --- a/package/google-breakpad/Config.in +++ b/package/google-breakpad/Config.in @@ -6,7 +6,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS config BR2_PACKAGE_GOOGLE_BREAKPAD bool "google-breakpad" depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11 + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 depends on BR2_USE_WCHAR depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_TOOLCHAIN_USES_GLIBC @@ -45,10 +45,10 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS endif -comment "google-breakpad requires a glibc toolchain w/ wchar, thread, C++, gcc >= 4.8" +comment "google-breakpad requires a glibc toolchain w/ wchar, threads, C++, gcc >= 7" depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ !BR2_TOOLCHAIN_HAS_THREADS || \ !BR2_TOOLCHAIN_USES_GLIBC || \ - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + !BR2_TOOLCHAIN_GCC_AT_LEAST_7 diff --git a/package/sentry-native/Config.in b/package/sentry-native/Config.in index 7a3cbd36ad..88db2779f1 100644 --- a/package/sentry-native/Config.in +++ b/package/sentry-native/Config.in @@ -1,7 +1,7 @@ config BR2_PACKAGE_SENTRY_NATIVE bool "sentry-native" depends on BR2_INSTALL_LIBSTDCPP # google-breakpad - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # google-breakpad + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # google-breakpad depends on BR2_USE_WCHAR # google-breakpad depends on BR2_TOOLCHAIN_HAS_THREADS # google-breakpad # google-breakpad is restricted to glibc or uClibc, but @@ -19,10 +19,10 @@ config BR2_PACKAGE_SENTRY_NATIVE https://github.com/getsentry/sentry-native -comment "sentry-native needs a glibc toolchain with w/ wchar, thread, C++, gcc >= 4.8" +comment "sentry-native needs a glibc toolchain with w/ wchar, threads, C++, gcc >= 7" depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ !BR2_TOOLCHAIN_HAS_THREADS || \ !BR2_TOOLCHAIN_USES_GLIBC || \ - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Fix the following build failure raised since commit 32c1fbad554d4c2bfbe56a652333195c8ae67904: configure: error: *** A compiler with support for C++17 language features is required. Fixes: 32c1fbad554d4c2bfbe56a652333195c8ae67904 - http://autobuild.buildroot.org/results/451bae7151a74cbcb5d199b8516e9c255a0953fe Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/google-breakpad/Config.in | 6 +++--- package/sentry-native/Config.in | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)