diff mbox series

[v2] package/minisign: new package

Message ID 20240108222957.3567-1-patrick.oppenlander@gmail.com
State Accepted
Headers show
Series [v2] package/minisign: new package | expand

Commit Message

Patrick Oppenlander Jan. 8, 2024, 10:25 p.m. UTC
From: Patrick Oppenlander <patrick.oppenlander@gmail.com>

Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
---

Changes from v1 (reviewed by Baruch Siach):
* host-libsodium dependency was incorrectly on to the target dependencies list.

 package/Config.in               |  1 +
 package/Config.in.host          |  1 +
 package/minisign/Config.in      |  8 ++++++++
 package/minisign/Config.in.host |  6 ++++++
 package/minisign/minisign.hash  |  3 +++
 package/minisign/minisign.mk    | 19 +++++++++++++++++++
 6 files changed, 38 insertions(+)
 create mode 100644 package/minisign/Config.in
 create mode 100644 package/minisign/Config.in.host
 create mode 100644 package/minisign/minisign.hash
 create mode 100644 package/minisign/minisign.mk

Comments

Peter Korsgaard Feb. 7, 2024, 8:16 a.m. UTC | #1
>>>>> "patrick" == patrick oppenlander <patrick.oppenlander@gmail.com> writes:

 > From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
 > Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
 > ---

 > Changes from v1 (reviewed by Baruch Siach):
 > * host-libsodium dependency was incorrectly on to the target dependencies list.

./utils/check-package points out a few minor issues:

package/Config.in:1572: Packages in: menu "Crypto",
                        are not alphabetically ordered;
                        correct order: '-', '_', digits, capitals, lowercase;
                        first incorrect package: minisign
package/minisign/Config.in:6: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/minisign/Config.in.host:4: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

You put it in Libraries/Crypto, but I isn't a library, so I think it
makes more sense to put it under "shell and utilities" like we do for gnupg2.

Committed with those issues fixed and an entry in DEVELOPERS added, thanks.
diff mbox series

Patch

diff --git a/package/Config.in b/package/Config.in
index 5a3410d758..1b7a667ea1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1538,6 +1538,7 @@  menu "Crypto"
 	source "package/ustream-ssl/Config.in"
 	source "package/wolfssl/Config.in"
 	source "package/wolftpm/Config.in"
+	source "package/minisign/Config.in"
 endmenu
 
 menu "Database"
diff --git a/package/Config.in.host b/package/Config.in.host
index c80842c33a..f03ca16b7b 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -64,6 +64,7 @@  menu "Host utilities"
 	source "package/meson-tools/Config.in.host"
 	source "package/mfgtools/Config.in.host"
 	source "package/microchip-hss-payload-generator/Config.in.host"
+	source "package/minisign/Config.in.host"
 	source "package/mkpasswd/Config.in.host"
 	source "package/moby-buildkit/Config.in.host"
 	source "package/mosquitto/Config.in.host"
diff --git a/package/minisign/Config.in b/package/minisign/Config.in
new file mode 100644
index 0000000000..cfba5586b1
--- /dev/null
+++ b/package/minisign/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_MINISIGN
+	bool "minisign"
+	select BR2_PACKAGE_LIBSODIUM
+	select BR2_PACKAGE_LIBSODIUM_FULL
+	help
+          Minisign is a dead simple tool to sign files and verify signatures.
+
+          https://github.com/jedisct1/minisign
diff --git a/package/minisign/Config.in.host b/package/minisign/Config.in.host
new file mode 100644
index 0000000000..8ed57cdbfc
--- /dev/null
+++ b/package/minisign/Config.in.host
@@ -0,0 +1,6 @@ 
+config BR2_PACKAGE_HOST_MINISIGN
+	bool "host minisign"
+	help
+          Minisign is a dead simple tool to sign files and verify signatures.
+
+          https://github.com/jedisct1/minisign
diff --git a/package/minisign/minisign.hash b/package/minisign/minisign.hash
new file mode 100644
index 0000000000..12cde42a43
--- /dev/null
+++ b/package/minisign/minisign.hash
@@ -0,0 +1,3 @@ 
+# Locally calculated
+sha256  74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55  minisign-0.11.tar.gz
+sha256  d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b  LICENSE
diff --git a/package/minisign/minisign.mk b/package/minisign/minisign.mk
new file mode 100644
index 0000000000..34b3f4046e
--- /dev/null
+++ b/package/minisign/minisign.mk
@@ -0,0 +1,19 @@ 
+################################################################################
+#
+# minisign
+#
+################################################################################
+
+MINISIGN_VERSION = 0.11
+MINISIGN_SITE = $(call github,jedisct1,minisign,$(MINISIGN_VERSION))
+MINISIGN_LICENSE = ISC
+MINISIGN_LICENSE_FILES = LICENSE
+MINISIGN_DEPENDENCIES = libsodium
+HOST_MINISIGN_DEPENDENCIES = host-libsodium
+
+ifeq ($(BR2_STATIC_LIBS),y)
+MINISIGN_CONF_OPTS += -DBUILD_STATIC_EXECUTABLES=1
+endif
+
+$(eval $(cmake-package))
+$(eval $(host-cmake-package))