| Message ID | 20230808180959.28091-2-ps.report@gmx.net |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on' | expand |
On Tue, 8 Aug 2023 20:09:59 +0200 Peter Seiderer <ps.report@gmx.net> wrote: > Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit > 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by > changing an dtoverlay option wrongly to an extra line (instead of changing > to an proper dtparam line), but as no one complained since 2021 just I'm failing to pase the "changing an dtoverlay option wrongly to an extra line (instead of changing to an proper dtparam line)". I'm confused by the "to an extra line". Do you mean that: dtoverlay=krnbt=on should have been: dtparam=krnbt=on ? Thomas
Hello Thomas, On Wed, 9 Aug 2023 00:12:12 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > On Tue, 8 Aug 2023 20:09:59 +0200 > Peter Seiderer <ps.report@gmx.net> wrote: > > > Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit > > 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by > > changing an dtoverlay option wrongly to an extra line (instead of changing > > to an proper dtparam line), but as no one complained since 2021 just > > I'm failing to pase the "changing an dtoverlay option wrongly to an > extra line (instead of changing to an proper dtparam line)". I'm > confused by the "to an extra line". > > Do you mean that: > > dtoverlay=krnbt=on To be precise the original was (and as documented here [1]) dtoverlay=miniuart-bt,krnbt=on > > should have been: > > dtparam=krnbt=on Yes (as documented here [2])... Regards, Peter [1] https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L2371 [2] https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L213 > > ? > > Thomas
diff --git a/board/raspberrypi/config_0w.txt b/board/raspberrypi/config_0w.txt index 195bad449e..771b975046 100644 --- a/board/raspberrypi/config_0w.txt +++ b/board/raspberrypi/config_0w.txt @@ -24,6 +24,3 @@ gpu_mem_1024=100 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console dtoverlay=miniuart-bt - -# enable autoprobing of Bluetooth driver without need of hciattach/btattach -dtoverlay=krnbt=on diff --git a/board/raspberrypi/config_3.txt b/board/raspberrypi/config_3.txt index 195bad449e..771b975046 100644 --- a/board/raspberrypi/config_3.txt +++ b/board/raspberrypi/config_3.txt @@ -24,6 +24,3 @@ gpu_mem_1024=100 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console dtoverlay=miniuart-bt - -# enable autoprobing of Bluetooth driver without need of hciattach/btattach -dtoverlay=krnbt=on diff --git a/board/raspberrypi/config_3_64bit.txt b/board/raspberrypi/config_3_64bit.txt index 34412fa9e8..ac5a09c486 100644 --- a/board/raspberrypi/config_3_64bit.txt +++ b/board/raspberrypi/config_3_64bit.txt @@ -25,8 +25,5 @@ gpu_mem_1024=100 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console dtoverlay=miniuart-bt -# enable autoprobing of Bluetooth driver without need of hciattach/btattach -dtoverlay=krnbt=on - # enable 64bits support arm_64bit=1 diff --git a/board/raspberrypi/config_4.txt b/board/raspberrypi/config_4.txt index ea02d3f071..01f60395b3 100644 --- a/board/raspberrypi/config_4.txt +++ b/board/raspberrypi/config_4.txt @@ -24,6 +24,3 @@ gpu_mem_1024=100 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console dtoverlay=miniuart-bt - -# enable autoprobing of Bluetooth driver without need of hciattach/btattach -dtoverlay=krnbt=on diff --git a/board/raspberrypi/config_4_64bit.txt b/board/raspberrypi/config_4_64bit.txt index 4a77fb3f1b..139f6a8788 100644 --- a/board/raspberrypi/config_4_64bit.txt +++ b/board/raspberrypi/config_4_64bit.txt @@ -25,8 +25,5 @@ gpu_mem_1024=100 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console dtoverlay=miniuart-bt -# enable autoprobing of Bluetooth driver without need of hciattach/btattach -dtoverlay=krnbt=on - # enable 64bits support arm_64bit=1 diff --git a/board/raspberrypi/config_zero2w.txt b/board/raspberrypi/config_zero2w.txt index 9e6b7f5ccf..151e446b5d 100644 --- a/board/raspberrypi/config_zero2w.txt +++ b/board/raspberrypi/config_zero2w.txt @@ -24,6 +24,3 @@ gpu_mem_1024=100 # fixes rpi (3B, 3B+, 3A+, 4B ,zero W and zero 2) ttyAMA0 serial console dtoverlay=miniuart-bt - -# enable autoprobing of Bluetooth driver without need of hciattach/btattach -dtoverlay=krnbt=on
Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by changing an dtoverlay option wrongly to an extra line (instead of changing to an proper dtparam line), but as no one complained since 2021 just drop it (and upcoming raspberry pi kernel/device tree will enable it by default [2]). Fixes (on the board): $ cat /proc/device-tree/chosen/user-warnings Failed to load overlay 'krnbt=on' [1] https://git.buildroot.net/buildroot/commit/?id=689b9ac439ab7b507c8982b6102bddf59d03efbf [2] https://github.com/raspberrypi/linux/commit/ec08e93837efa2e75e5cab4d80427fdf7ea23da1 Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- board/raspberrypi/config_0w.txt | 3 --- board/raspberrypi/config_3.txt | 3 --- board/raspberrypi/config_3_64bit.txt | 3 --- board/raspberrypi/config_4.txt | 3 --- board/raspberrypi/config_4_64bit.txt | 3 --- board/raspberrypi/config_zero2w.txt | 3 --- 6 files changed, 18 deletions(-)