diff mbox series

[5/5] package/ipython: add missing dependencies

Message ID 20230528190111.2430580-5-romain.naour@gmail.com
State Accepted
Headers show
Series [1/5] package/python-executing: new package | expand

Commit Message

Romain Naour May 28, 2023, 7:01 p.m. UTC
As reported [1], the test TestIPythonPy3 fail since it was updated
to 8.6.0 release just after 2022.11.

  ModuleNotFoundError: No module named 'stack_data'

Indeed there is no such python3-stack-data in Buildroot.
For example, Fedora packaging added python3-stack-data while updating
to ipython 8.0.1.

With python-stack-data added, the test TestIPythonPy3 still fail
with:

  ModuleNotFoundError: No module named 'sqlite3'

Since ipython 8 sqlite3 fallback imports has been removed [2].

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4322819089

[1] http://lists.busybox.net/pipermail/buildroot/2023-May/668086.html
[2] https://github.com/ipython/ipython/commit/7a0bdabecfa745b60c3a711e1da2df378687e746

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
Due to the number of new packages required to fix ipython,
we may consider reverting to ipython 7.31.1 for 2023.05 and 2023.02.
---
 package/python-ipython/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Peter Korsgaard June 2, 2023, 7:46 p.m. UTC | #1
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > As reported [1], the test TestIPythonPy3 fail since it was updated
 > to 8.6.0 release just after 2022.11.

 >   ModuleNotFoundError: No module named 'stack_data'

 > Indeed there is no such python3-stack-data in Buildroot.
 > For example, Fedora packaging added python3-stack-data while updating
 > to ipython 8.0.1.

 > With python-stack-data added, the test TestIPythonPy3 still fail
 > with:

 >   ModuleNotFoundError: No module named 'sqlite3'

 > Since ipython 8 sqlite3 fallback imports has been removed [2].

 > Fixes:
 > https://gitlab.com/buildroot.org/buildroot/-/jobs/4322819089

 > [1] http://lists.busybox.net/pipermail/buildroot/2023-May/668086.html
 > [2] https://github.com/ipython/ipython/commit/7a0bdabecfa745b60c3a711e1da2df378687e746

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>

Committed, thanks.
Peter Korsgaard June 14, 2023, 11:40 a.m. UTC | #2
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > As reported [1], the test TestIPythonPy3 fail since it was updated
 > to 8.6.0 release just after 2022.11.

 >   ModuleNotFoundError: No module named 'stack_data'

 > Indeed there is no such python3-stack-data in Buildroot.
 > For example, Fedora packaging added python3-stack-data while updating
 > to ipython 8.0.1.

 > With python-stack-data added, the test TestIPythonPy3 still fail
 > with:

 >   ModuleNotFoundError: No module named 'sqlite3'

 > Since ipython 8 sqlite3 fallback imports has been removed [2].

 > Fixes:
 > https://gitlab.com/buildroot.org/buildroot/-/jobs/4322819089

 > [1] http://lists.busybox.net/pipermail/buildroot/2023-May/668086.html
 > [2] https://github.com/ipython/ipython/commit/7a0bdabecfa745b60c3a711e1da2df378687e746

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>

Committed to 2023.02.x, thanks.
diff mbox series

Patch

diff --git a/package/python-ipython/Config.in b/package/python-ipython/Config.in
index 3de49ae574..c217efcfd1 100644
--- a/package/python-ipython/Config.in
+++ b/package/python-ipython/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_PYTHON_IPYTHON
 	bool "python-ipython"
+	select BR2_PACKAGE_PYTHON3_SQLITE # runtime
 	select BR2_PACKAGE_PYTHON_BACKCALL # runtime
 	select BR2_PACKAGE_PYTHON_DECORATOR # runtime
 	select BR2_PACKAGE_PYTHON_JEDI # runtime
@@ -7,6 +8,7 @@  config BR2_PACKAGE_PYTHON_IPYTHON
 	select BR2_PACKAGE_PYTHON_PROMPT_TOOLKIT # runtime
 	select BR2_PACKAGE_PYTHON_PYGMENTS  # runtime
 	select BR2_PACKAGE_PYTHON_PEXPECT # runtime
+	select BR2_PACKAGE_PYTHON_STACK_DATA # runtime
 	select BR2_PACKAGE_PYTHON_TRAITLETS  # runtime
 	help
 	  IPython is a command shell for interactive computing in